public inbox for linux-riscv@lists.infradead.org
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: Heiko Stuebner <heiko@sntech.de>
Cc: linux-riscv@lists.infradead.org, palmer@dabbelt.com,
	christoph.muellner@vrull.eu, philipp.tomsich@vrull.eu,
	abrestic@rivosinc.com, Heiko Stuebner <heiko.stuebner@vrull.eu>
Subject: Re: [PATCH] RISC-V: Fix do_notify_resume / do_work_pending prototype
Date: Wed, 18 Jan 2023 15:40:52 +0000	[thread overview]
Message-ID: <Y8gTBJsB22LSzZFy@spud> (raw)
In-Reply-To: <20230118142252.337103-1-heiko@sntech.de>


[-- Attachment #1.1: Type: text/plain, Size: 1245 bytes --]

On Wed, Jan 18, 2023 at 03:22:52PM +0100, Heiko Stuebner wrote:
> From: Heiko Stuebner <heiko.stuebner@vrull.eu>
> 
> Commit b0f4c74eadbf ("RISC-V: Fix unannoted hardirqs-on in return to
> userspace slow-path") renamed the do_notify_resume function to
> do_work_pending but did not change the prototype in signal.h
> Do that now, as the original function does not exist anymore.
> 
> Fixes: b0f4c74eadbf ("RISC-V: Fix unannoted hardirqs-on in return to userspace slow-path")
> Signed-off-by: Heiko Stuebner <heiko.stuebner@vrull.eu>
> ---
>  arch/riscv/include/asm/signal.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/riscv/include/asm/signal.h b/arch/riscv/include/asm/signal.h
> index 532c29ef0376..956ae0a01bad 100644
> --- a/arch/riscv/include/asm/signal.h
> +++ b/arch/riscv/include/asm/signal.h
> @@ -7,6 +7,6 @@
>  #include <uapi/asm/ptrace.h>
>  
>  asmlinkage __visible
> -void do_notify_resume(struct pt_regs *regs, unsigned long thread_info_flags);
> +void do_work_pending(struct pt_regs *regs, unsigned long thread_info_flags);

Is that an auto-builder blind spot as it gets jumped to from asm?
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  parent reply	other threads:[~2023-01-18 15:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-18 14:22 [PATCH] RISC-V: Fix do_notify_resume / do_work_pending prototype Heiko Stuebner
2023-01-18 15:10 ` Andrew Jones
2023-01-18 15:40 ` Conor Dooley [this message]
2023-01-27 13:59   ` Heiko Stübner
2023-01-31 18:30 ` patchwork-bot+linux-riscv

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y8gTBJsB22LSzZFy@spud \
    --to=conor@kernel.org \
    --cc=abrestic@rivosinc.com \
    --cc=christoph.muellner@vrull.eu \
    --cc=heiko.stuebner@vrull.eu \
    --cc=heiko@sntech.de \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=philipp.tomsich@vrull.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox