From: Conor Dooley <conor.dooley@microchip.com>
To: shravan kumar <shravan.chippa@microchip.com>
Cc: <green.wan@sifive.com>, <vkoul@kernel.org>, <palmer@dabbelt.com>,
<paul.walmsley@sifive.com>, <linux-kernel@vger.kernel.org>,
<linux-riscv@lists.infradead.org>, <dmaengine@vger.kernel.org>
Subject: Re: [PATCH v1] dmaengine: sf-pdma: pdma_desc memory leak fix
Date: Fri, 20 Jan 2023 10:50:01 +0000 [thread overview]
Message-ID: <Y8px2Qky3GZ5wazl@wendy> (raw)
In-Reply-To: <20230120100623.3530634-1-shravan.chippa@microchip.com>
[-- Attachment #1.1: Type: text/plain, Size: 1648 bytes --]
Hey Shravan,
On Fri, Jan 20, 2023 at 03:36:23PM +0530, shravan kumar wrote:
> From: Shravan Chippa <shravan.chippa@microchip.com>
>
> Commit b2cc5c465c2c ("dmaengine: sf-pdma: Add multithread support for a
> DMA channel") changed sf_pdma_prep_dma_memcpy() to unconditionally
> allocate a new sf_pdma_desc each time it is called.
>
> The driver previously recycled descs, by checking the in_use flag, only
> allocating additional descs if the existing one was in use. This logic
> was removed in commit b2cc5c465c2c ("dmaengine: sf-pdma: Add multithread
> support for a DMA channel"), but sf_pdma_free_desc() was not changed to
> handle the new behaviour.
>
> As a result, each time sf_pdma_prep_dma_memcpy() is called, the previous
> descriptor is leaked, over time leading to memory starvation:
>
> unreferenced object 0xffffffe008447300 (size 192):
> comm "irq/39-mchp_dsc", pid 343, jiffies 4294906910 (age 981.200s)
> hex dump (first 32 bytes):
> 00 00 00 ff 00 00 00 00 b8 c1 00 00 00 00 00 00 ................
> 00 00 70 08 10 00 00 00 00 00 00 c0 00 00 00 00 ..p.............
> backtrace:
> [<00000000064a04f4>] kmemleak_alloc+0x1e/0x28
> [<00000000018927a7>] kmem_cache_alloc+0x11e/0x178
> [<000000002aea8d16>] sf_pdma_prep_dma_memcpy+0x40/0x112
>
> Add the missing kfree() to sf_pdma_free_desc(), and remove the redundant
> in_use flag.
>
> Fixes: b2cc5c465c2c ("dmaengine: sf-pdma: Add multithread support for a DMA channel")
> Signed-off-by: Shravan Chippa <shravan.chippa@microchip.com>
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-01-20 10:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-20 10:06 [PATCH v1] dmaengine: sf-pdma: pdma_desc memory leak fix shravan kumar
2023-01-20 10:50 ` Conor Dooley [this message]
2023-02-07 18:15 ` Conor Dooley
2023-02-10 5:46 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8px2Qky3GZ5wazl@wendy \
--to=conor.dooley@microchip.com \
--cc=dmaengine@vger.kernel.org \
--cc=green.wan@sifive.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=shravan.chippa@microchip.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox