Re: [PATCH -next v13 01/19] riscv: Rename __switch_to_aux -> fpu

Conor Dooley
2023-01-25T21:16:07Z

[-- Attachment #1.1: Type: text/plain, Size: 1990 bytes --]

On Wed, Jan 25, 2023 at 02:20:38PM +0000, Andy Chiu wrote:
> From: Guo Ren <ren_guo@c-sky.com>
>
> The name of __switch_to_aux is not clear and rename it with the
> determine function: __switch_to_fpu. Next we could add other regs'
> switch.
>
> Signed-off-by: Guo Ren <ren_guo@c-sky.com>
> Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
> Signed-off-by: Greentime Hu <greentime.hu@sifive.com>
> Reviewed-by: Anup Patel <anup@brainfault.org>
> Reviewed-by: Palmer Dabbelt <palmer@rivosinc.com>

With your SoB added here:
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

> ---
> arch/riscv/include/asm/switch_to.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/riscv/include/asm/switch_to.h b/arch/riscv/include/asm/switch_to.h
> index 11463489fec6..df1aa589b7fd 100644
> --- a/arch/riscv/include/asm/switch_to.h
> +++ b/arch/riscv/include/asm/switch_to.h
> @@ -46,7 +46,7 @@ static inline void fstate_restore(struct task_struct *task,
> }
> }
>
> -static inline void __switch_to_aux(struct task_struct *prev,
> +static inline void __switch_to_fpu(struct task_struct *prev,
> struct task_struct *next)
> {
> struct pt_regs *regs;
> @@ -65,7 +65,7 @@ static __always_inline bool has_fpu(void)
> static __always_inline bool has_fpu(void) { return false; }
> #define fstate_save(task, regs) do { } while (0)
> #define fstate_restore(task, regs) do { } while (0)
> -#define __switch_to_aux(__prev, __next) do { } while (0)
> +#define __switch_to_fpu(__prev, __next) do { } while (0)
> #endif
>
> extern struct task_struct *__switch_to(struct task_struct *,
> @@ -76,7 +76,7 @@ do { \
> struct task_struct *__prev = (prev); \
> struct task_struct *__next = (next); \
> if (has_fpu()) \
> - __switch_to_aux(__prev, __next); \
> + __switch_to_fpu(__prev, __next); \
> ((last) = __switch_to(__prev, __next)); \
> } while (0)
>
> --
> 2.17.1
>

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]