Re: [PATCH v2 4/4] mm, arch: add generic implementation of pfn_valid() for FLATMEM

David Hildenbrand
2023-02-03T14:35:47Z

On 29.01.23 13:42, Mike Rapoport wrote:
> From: "Mike Rapoport (IBM)" <rppt@kernel.org>
>
> Every architecture that supports FLATMEM memory model defines its own
> version of pfn_valid() that essentially compares a pfn to max_mapnr.
>
> Use mips/powerpc version implemented as static inline as a generic
> implementation of pfn_valid() and drop its per-architecture definitions.
>
> Signed-off-by: Mike Rapoport (IBM) <rppt@kernel.org>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
> Acked-by: Guo Ren <guoren@kernel.org> # csky
> Acked-by: Huacai Chen <chenhuacai@loongson.cn> # LoongArch
> Acked-by: Stafford Horne <shorne@gmail.com> # OpenRISC
> ---

LGTM with the fixup

Reviewed-by: David Hildenbrand <david@redhat.com>

--
Thanks,

David / dhildenb