From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C68ADC433B4 for ; Tue, 4 May 2021 12:24:44 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 242FA613B4 for ; Tue, 4 May 2021 12:24:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 242FA613B4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BWL7JaF2rIwFjsJKkuKIv3bxkwxDLJ2GFSTqhEITodg=; b=MhhmEt0RAfuQkzRZ7cWiaR8Yb z+nAjVDSFN7pE1bWoXFc3DHXQd08Ec5AxfUexRe0sJxzvublfNU50Yab98h2Jg+J+G4GV3z1QfJH7 Xy+gU5wQa4OUHYclV6YTe+kVQLlVqlR2UIoV2UZizPxWADuIDxV+9I4VK/x5dUCbJ9bZ5F7p2QnYD JlxcryIPh20+yYPfESnAXet4Owe2KaBngzH/4UuyKyXdcTLXXbmUQZDK/wR7QfrMB6nVdbTn7UCdY dBQnczPmuXhMD1YZxMfqp2xEB4oZPNv2jw9xOANgLKwD8iBqkrzGEzAKSTXlRnCTxSbd3nsju7LPd ooWywpzEQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1ldu6H-00GB84-SF; Tue, 04 May 2021 12:24:29 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ldu6G-00GB7q-AO for linux-riscv@desiato.infradead.org; Tue, 04 May 2021 12:24:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=UTwe46S8I5PAwK9GY1KUO9JmWI3rtri2kBSKPlVXfEY=; b=RwcNpR1tkiGvWPED2gWqwIdyeC JaIJi4Y1x7xcNc2ECS+m81RKtSuKEI0ajuaEsYxa2p5cybJvlSxjgs/nD9edYb0j05pbkGTtLqlRl Jx+swGw1LV5SH5FF5KXhltTI37NhgQqS3cypdxcBOP6HIdBVmn+tjcy7fWfLFqLsIrYfb3CN4Yft8 hm0pP+uQCbrpXkFW1gMSfWUwEFLeSlS40qNVH6OTokr7Ak5s3Zw891rha0x0lefMPkx4dQEMKwli+ RIaTtzBpH3KvYMElAyR01cA00dsNiAOdLZ162D1BkeS2gcrmoWLMcKC+9B9XtQOXJX9eKi17cM5Hi 7jHXK2lw==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ldu6D-003xss-Oe for linux-riscv@lists.infradead.org; Tue, 04 May 2021 12:24:27 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 54735613B4; Tue, 4 May 2021 12:24:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620131064; bh=vArYzEMEwRqDbMRFkfiHNa4Cgeb/07wrYgojfXEM6ig=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=f8ApvRPhpj1ghZ3GYlONwF21yByVn6tOlm5gExHU9CgVbE38i4gVlkktgw2fcqEBT 2BI1Kc+8aoqMzhiK+LgMM/mkS/TOu4WchUA47NAZFl56Od8RreTRfQOpguR2XoJgc2 0ojolL9ZtF/h6+OfVzabe/ChOlHh35FJ8K09aqkFtpcDgj6RQm88Axlyp5z1fqHelY S7CNTilkyJ2Cgs79Vz8LRogTJt2ixK1EkztsdanK089ZE6wdtQB/Kj5eplasCOxeGc y7osxn+gPLsTO5KkTVn073nXPICN6pUipqsNZOOte8gfA4ULES81Kz9N2FB/7R1JP/ bHMrKkSRsKxBw== Date: Tue, 4 May 2021 15:24:19 +0300 From: Leon Romanovsky To: Greentime Hu Cc: paul.walmsley@sifive.com, hes@sifive.com, erik.danie@sifive.com, zong.li@sifive.com, bhelgaas@google.com, robh+dt@kernel.org, aou@eecs.berkeley.edu, mturquette@baylibre.com, sboyd@kernel.org, lorenzo.pieralisi@arm.com, p.zabel@pengutronix.de, alex.dewar90@gmail.com, khilman@baylibre.com, hayashi.kunihiko@socionext.com, vidyas@nvidia.com, jh80.chung@samsung.com, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, helgaas@kernel.org Subject: Re: [PATCH v6 1/6] clk: sifive: Add pcie_aux clock in prci driver for PCIe driver Message-ID: References: <20210504105940.100004-1-greentime.hu@sifive.com> <20210504105940.100004-2-greentime.hu@sifive.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210504105940.100004-2-greentime.hu@sifive.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210504_052425_845489_7381258A X-CRM114-Status: GOOD ( 17.79 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Tue, May 04, 2021 at 06:59:35PM +0800, Greentime Hu wrote: > We add pcie_aux clock in this patch so that pcie driver can use > clk_prepare_enable() and clk_disable_unprepare() to enable and disable > pcie_aux clock. > > Signed-off-by: Greentime Hu > Acked-by: Stephen Boyd > --- > drivers/clk/sifive/fu740-prci.c | 11 +++++ > drivers/clk/sifive/fu740-prci.h | 2 +- > drivers/clk/sifive/sifive-prci.c | 41 +++++++++++++++++++ > drivers/clk/sifive/sifive-prci.h | 9 ++++ > include/dt-bindings/clock/sifive-fu740-prci.h | 1 + > 5 files changed, 63 insertions(+), 1 deletion(-) > > diff --git a/drivers/clk/sifive/fu740-prci.c b/drivers/clk/sifive/fu740-prci.c > index 764d1097aa51..53f6e00a03b9 100644 > --- a/drivers/clk/sifive/fu740-prci.c > +++ b/drivers/clk/sifive/fu740-prci.c > @@ -72,6 +72,12 @@ static const struct clk_ops sifive_fu740_prci_hfpclkplldiv_clk_ops = { > .recalc_rate = sifive_prci_hfpclkplldiv_recalc_rate, <...> > +/* PCIE AUX clock APIs for enable, disable. */ > +int sifive_prci_pcie_aux_clock_is_enabled(struct clk_hw *hw) It should be bool > +{ > + struct __prci_clock *pc = clk_hw_to_prci_clock(hw); > + struct __prci_data *pd = pc->pd; > + u32 r; > + > + r = __prci_readl(pd, PRCI_PCIE_AUX_OFFSET); > + > + if (r & PRCI_PCIE_AUX_EN_MASK) > + return 1; > + else > + return 0; > +} and here simple "return r & PRCI_PCIE_AUX_EN_MASK;" > + > +int sifive_prci_pcie_aux_clock_enable(struct clk_hw *hw) > +{ > + struct __prci_clock *pc = clk_hw_to_prci_clock(hw); > + struct __prci_data *pd = pc->pd; > + u32 r __maybe_unused; > + > + if (sifive_prci_pcie_aux_clock_is_enabled(hw)) > + return 0; You actually call to this new function only once, put your __prci_readl() here. Thanks _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv