Re: [PATCH 2/3] riscv: Fixup PAGE_UP in asm/page.h

Christoph Hellwig
2021-05-25T06:35:13Z

On Mon, May 24, 2021 at 06:51:07AM +0000, guoren@kernel.org wrote:
> From: Guo Ren <guoren@linux.alibaba.com>
>
> Current PAGE_UP implementation is wrong. PAGE_UP(0) should be
> 0x1000, but current implementation will give out 0.
>
> Although the current PAGE_UP isn't used, it will soon be used in
> tlb_flush optimization.

Nak. Please just remove the PAGE_UP/PAGE_DOWN macros just like they
have been removed from other architectures long ago and use the
generic DIV_ROUND_UP macro for your new code like everyone else.