From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30020C4338F for ; Thu, 5 Aug 2021 18:41:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EC23760F01 for ; Thu, 5 Aug 2021 18:41:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EC23760F01 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uYGq6bQsaHQm0STzX2tt9jWGG5i0U1JjygEF/rSe274=; b=CSnlBFIsul8rfx OE9W4c4a6jZo5+kyXOK/dXhKCVXwvX1UZd4HTsLKcjeLjOMhEfNNrAAv34hQUkcOfCab2U2G/83ft 90PSNrbrJikCP9EUR9dusI7F/4TPCT/hgWFN8WIxZFa5IqpRYgCiSeoPyTvQ6DkkpyhdpmIkr83VW DAWdAeH042IgbXZ1aHvBwZoYruGE3VPGr1i/H+bojHST4IIY2r2kBJX4sRiHR/QgNPcw9Hq+yLTf2 dEF7ttrx11AxR9g9e+7c1NZRB6aEVJsjt94qhcg93BoKghqpYRKHwA765kXdseTE1hOsYPsHHQLh5 VQ6iKDribogCLybVG9Zw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBiJ9-00AXqL-8I; Thu, 05 Aug 2021 18:41:31 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBiJ6-00AXpP-4e; Thu, 05 Aug 2021 18:41:29 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id D0F0C60F01; Thu, 5 Aug 2021 18:41:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1628188887; bh=DJstyoIneDhJWe2M45tnolj4HGCE0gCrRv38Ul0FPvI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=yLSS87676hn106VIngpXBP/rOEU9YnrWCbO+LvhheiKjxKARCwKmpPaCV3EXfwCgP eswsJEhyB34IGotQMI4++5xN+H6/H2Zsa8YN4zRquACi04W3hFcBWcF1DF3HWEIxIo hfvqM78wNk4u3fnnSgFl6tYnBJF7uBTAQJcXiptc= Date: Thu, 5 Aug 2021 20:41:23 +0200 From: Greg Kroah-Hartman To: Catalin Marinas Cc: Lee Jones , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Vineet Gupta , Will Deacon , Guo Ren , Yoshinori Sato , Brian Cain , Geert Uytterhoeven , Michal Simek , Thomas Bogendoerfer , John Crispin , Ley Foon Tan , Jonas Bonn , Stefan Kristiansson , Stafford Horne , "James E . J . Bottomley" , Helge Deller , Michael Ellerman , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Rich Felker , "David S . Miller" , Jeff Dike , Richard Weinberger , Anton Ivanov , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Chris Zankel , Max Filippov , Sebastian Reichel , linux-snps-arc@lists.infradead.org, linux-csky@vger.kernel.org, uclinux-h8-devel@lists.sourceforge.jp, linux-hexagon@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org Subject: Re: [PATCH 1/3] arch: Export machine_restart() instances so they can be called from modules Message-ID: References: <20210805075032.723037-1-lee.jones@linaro.org> <20210805075032.723037-2-lee.jones@linaro.org> <20210805173625.GH6719@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210805173625.GH6719@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210805_114128_243547_1BA1520D X-CRM114-Status: GOOD ( 12.74 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Thu, Aug 05, 2021 at 06:36:25PM +0100, Catalin Marinas wrote: > On Thu, Aug 05, 2021 at 08:50:30AM +0100, Lee Jones wrote: > > diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c > > index b4bb67f17a2ca..cf89ce91d7145 100644 > > --- a/arch/arm64/kernel/process.c > > +++ b/arch/arm64/kernel/process.c > > @@ -212,6 +212,7 @@ void machine_restart(char *cmd) > > printk("Reboot failed -- System halted\n"); > > while (1); > > } > > +EXPORT_SYMBOL(machine_restart); > > Should we make this EXPORT_SYMBOL_GPL? I suppose it's not for general > use by out of tree drivers and it matches the other pm_power_off symbol > we export in this file. Yes please. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv