From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C7AD5C433F5 for ; Mon, 6 Dec 2021 17:55:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CUBpyD6rLV2Y4jnZ3gj2dDmDIKDhiCqEDuZPl/Vj3TM=; b=rDuuYIKr+9COol mEJFhins2by3QHa+hFoQK/rM+708iFK30Vx1BG5gHODZmjEKx572hiqCtS1p1mpvg/li7nAIdMVG+ STGKn+ktJQe00wNb1ePbi6cymRHQ7GzRoXTTWbeVcqjdrO/UYbbY0GwAQD3D512nAJ6HtqLm8qzQv 3iBMxBo+xcxnOexxuBZpjyvSEMcbsQUdiAngqbOZbUcnMTQrrT8rvpDo0fOA5ixZV6MxhJGJ8Jm14 oXTkMxyz8tIhMCOdjWWNDLNxYEnaz882ahDP3wpq0jzszgmRghFN62+JDEMtPqxTtYWe8yXIPts7s MJKZq/ejJTbMJrzv3mTQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1muICe-005A0y-1O; Mon, 06 Dec 2021 17:55:04 +0000 Received: from mail-qv1-f45.google.com ([209.85.219.45]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1muICb-0059zz-FW for linux-riscv@lists.infradead.org; Mon, 06 Dec 2021 17:55:03 +0000 Received: by mail-qv1-f45.google.com with SMTP id g9so10659310qvd.2 for ; Mon, 06 Dec 2021 09:55:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=lSc3DRlrnM1Lcia62pQKwlk3m2k/c66XTYP+iezKl/c=; b=xCRn7ZU/NAA/oGkFNuXqtQKjM8pdV8K3DchGL7Lw2xTgri2NJ8YN2HhmXCBpwMolj3 Hsw26vcb/R4m2wmGVuMPgKJ+1KmTlhhA26maH4/ALiIn7LEHIX62jVi+PsFN/aASM2Um t7xDnmuKjesRQVDS8PfAy2uj6zjGh+q3RRCNq9iOjKN7NFe61FSEoumKw+H6FuPt6/iE wzyuYGSlKm0T24jqQSktOcCe7MHOwIf9+Bh9Fxlsp0yegidUxpZuHYDpEAQKtdZl4O0H UobNzcJtIiNivwhqwu71c/PbnH2swApYy72DQbYbaKxqXl6fsLI+uHomLu93K+MM70L4 X1Hw== X-Gm-Message-State: AOAM530q4rL29sjtijSRrqgOStM20/0s4rVl+AT5UeEoWS4ySxIS1/QW Dlv1gjrpoMP90T0h6Fwrl+Y= X-Google-Smtp-Source: ABdhPJzvI5vnLdy++JFIB6FxTHC6xz6F71P2KZQcIqIHV9LdPxJ9qr/RTVcpbXLZOZc9szAWgP7MtQ== X-Received: by 2002:a05:6214:27ca:: with SMTP id ge10mr38415135qvb.80.1638813299388; Mon, 06 Dec 2021 09:54:59 -0800 (PST) Received: from fedora (pool-173-68-57-129.nycmny.fios.verizon.net. [173.68.57.129]) by smtp.gmail.com with ESMTPSA id m9sm6753680qkn.59.2021.12.06.09.54.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Dec 2021 09:54:58 -0800 (PST) Date: Mon, 6 Dec 2021 12:54:57 -0500 From: Dennis Zhou To: Rich Felker Cc: Rob Landley , Dennis Zhou , Vladimir Murzin , linux-arch-owner@vger.kernel.org, linux-mm@kvack.org, tj@kernel.org, cl@linux.com, akpm@linux-foundation.org, npiggin@gmail.com, hch@lst.de, arnd@arndb.de, linux-sh@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH] percpu: km: ensure it is used with NOMMU (either UP or SMP) Message-ID: References: <20211130172954.129587-1-vladimir.murzin@arm.com> <20211130172954.129587-2-vladimir.murzin@arm.com> <8c2b4666-cf13-3735-be1e-b8a1c71df113@arm.com> <20211206162140.GJ7074@brightrain.aerifal.cx> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211206162140.GJ7074@brightrain.aerifal.cx> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211206_095501_557318_4B442A1C X-CRM114-Status: GOOD ( 37.19 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Mon, Dec 06, 2021 at 11:21:46AM -0500, Rich Felker wrote: > On Mon, Dec 06, 2021 at 06:01:59AM -0600, Rob Landley wrote: > > On 12/3/21 3:02 PM, Dennis Zhou wrote: > > > On Wed, Dec 01, 2021 at 11:51:04AM +0000, Vladimir Murzin wrote: > > >> Hi, > > >> > > >> On 11/30/21 5:41 PM, Dennis Zhou wrote: > > >> > Hello, > > >> > > > >> > On Tue, Nov 30, 2021 at 05:29:54PM +0000, Vladimir Murzin wrote: > > >> >> Currently, NOMMU pull km allocator via !SMP dependency because most of > > >> >> them are UP, yet for SMP+NOMMU vm allocator gets pulled which: > > >> >> > > >> >> * may lead to broken build [1] > > >> >> * ...or not working runtime due to [2] > > >> >> > > >> >> It looks like SMP+NOMMU case was overlooked in bbddff054587 ("percpu: > > >> >> use percpu allocator on UP too") so restore that. > > >> >> > > >> >> [1] > > >> >> For ARM SMP+NOMMU (R-class cores) > > >> >> > > >> >> arm-none-linux-gnueabihf-ld: mm/percpu.o: in function `pcpu_post_unmap_tlb_flush': > > >> >> mm/percpu-vm.c:188: undefined reference to `flush_tlb_kernel_range' > > >> >> > > >> >> [2] > > >> >> static inline > > >> >> int vmap_pages_range_noflush(unsigned long addr, unsigned long end, > > >> >> pgprot_t prot, struct page **pages, unsigned int page_shift) > > >> >> { > > >> >> return -EINVAL; > > >> >> } > > >> >> > > >> >> Signed-off-by: Vladimir Murzin > > >> >> --- > > >> >> mm/Kconfig | 3 +-- > > >> >> 1 file changed, 1 insertion(+), 2 deletions(-) > > >> >> > > >> >> diff --git a/mm/Kconfig b/mm/Kconfig > > >> >> index d16ba92..66331e0 100644 > > >> >> --- a/mm/Kconfig > > >> >> +++ b/mm/Kconfig > > >> >> @@ -425,9 +425,8 @@ config THP_SWAP > > >> >> # UP and nommu archs use km based percpu allocator > > >> >> # > > >> >> config NEED_PER_CPU_KM > > >> >> - depends on !SMP > > >> >> bool > > >> >> - default y > > >> >> + default !SMP || !MMU > > >> >> > > >> > > > >> > Should this be `depends on !SMP || !MMU` with default yes? Because with > > >> > SMP && MMU, it shouldn't be an option to run with percpu-km. > > >> > > >> IIUC these are equivalent, truth table would not change if is under "depends" > > >> or "default" > > >> > > >> SMP MMU NEED_PER_CPU_KM > > >> y y !y || !y => n || n => n > > >> y n !y || !n => n || y => y > > >> n y !n || !y => y || n => y > > >> n n !n || !n => y || y => y > > >> > > > > > > I may be wrong, but I think this is slightly different as we're using > > > #ifdef / #if defined(). > > > > > >> > > > >> >> config CLEANCACHE > > >> >> bool "Enable cleancache driver to cache clean pages if tmem is present" > > >> >> -- > > >> >> 2.7.4 > > >> >> > > >> > > > >> > It's interesting to me that this is all coming up at once. Earlier this > > >> > month I had the same conversation with people involved with sh [1]. > > >> > > > >> > [1] https://lore.kernel.org/linux-sh/YY7tp5attRyK42Zk@fedora/ > > >> > > > >> > I can pull this shortly once I see whatever happened to linux-sh. > > >> > > >> Ahh, good to know! Adding SH folks here (start of discussion [0]). I see you came > > >> to the same conclusion, right? > > > > > > Yeah, I don't see anything else from linux-sh. So I'll go ahead and > > > apply this with my change if you're fine with that. > > > > I can't test against current until I get some unrelated fixes from Rich Felker > > (who's been busy over the weekend), but I tested the "depends" version on 5.10 > > and got a shell prompt on my "make ARCH=sh j2_defconfig" board. > > > > Tested-by: Rob Landley > > Tested-by: Rich Felker > > I've tested the version as originally posted and it works for j2 (sh2) > (both build and runtime checked). I'd tested the other (depends > version) before and I'm fine with either going upstream. > > Rich > Thank you all for testing and bearing with me. I've applied this to for-5.16-fixes. Will send it up later in the week. Thanks, Dennis _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv