From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Alistair Francis <alistair.francis@opensource.wdc.com>
Cc: linux-kernel@vger.kernel.org, dave@stgolabs.net,
dvhart@infradead.org, arnd@arndb.de, alistair23@gmail.com,
namhyung@kernel.org, jolsa@redhat.com,
linux-perf-users@vger.kernel.org,
alexander.shishkin@linux.intel.com, mark.rutland@arm.com,
mingo@redhat.com, peterz@infradead.org, tglx@linutronix.de,
Alistair Francis <alistair.francis@wdc.com>,
Atish Patra <atish.patra@wdc.com>,
linux-riscv@lists.infradead.org,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [PATCH v5 1/6] perf bench futex: Add support for 32-bit systems with 64-bit time_t
Date: Fri, 10 Dec 2021 10:44:35 -0300 [thread overview]
Message-ID: <YbNZw1/cUXJ8up5b@kernel.org> (raw)
In-Reply-To: <YbNX3mRT0A9/N2il@kernel.org>
Em Fri, Dec 10, 2021 at 10:36:30AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Fri, Dec 10, 2021 at 09:58:52AM +1000, Alistair Francis escreveu:
> > From: Alistair Francis <alistair.francis@wdc.com>
> >
> > Some 32-bit architectures (such are 32-bit RISC-V) only have a 64-bit
> > time_t and as such don't have the SYS_futex syscall. This patch will
> > allow us to use the SYS_futex_time64 syscall on those platforms.
> >
> > This also converts the futex calls to be y2038 safe (when built for a
> > 5.1+ kernel).
> >
> > This is a revert of commit ba4026b09d83acf56c040b6933eac7916c27e728
> > "Revert "perf bench futex: Add support for 32-bit systems with 64-bit time_t"".
> >
> > The original commit was reverted as including linux/time_types.h would
> > fail to compile on older kernels. This commit doesn't include
> > linux/time_types.h to avoid this issue.
>
> 10 9.99 alpine:3.12 : FAIL gcc version 9.3.0 (Alpine 9.3.0)
> In file included from bench/futex-hash.c:29:
> bench/futex.h:37:2: error: unknown type name '__kernel_old_time_t'
> 37 | __kernel_old_time_t tv_sec; /* seconds */
> | ^~~~~~~~~~~~~~~~~~~
> In file included from bench/futex-wake.c:25:
> bench/futex.h:37:2: error: unknown type name '__kernel_old_time_t'
> 37 | __kernel_old_time_t tv_sec; /* seconds */
> | ^~~~~~~~~~~~~~~~~~~
> make[3]: *** [/git/perf-5.16.0-rc4/tools/build/Makefile.build:139: bench] Error 2
> 11 114.27 alpine:3.13 : Ok gcc (Alpine 10.2.1_pre1) 10.2.1 20201203 , Alpine clang version 10.0.1
> 12 100.12 alpine:3.14 : Ok gcc (Alpine 10.3.1_git20210424) 10.3.1 20210424 , Alpine clang version 11.1.0
> 13 101.06 alpine:3.15 : Ok gcc (Alpine 10.3.1_git20211027) 10.3.1 20211027 , Alpine clang version 12.0.1
> 14 101.96 alpine:edge : Ok gcc (Alpine 11.2.1_git20211128) 11.2.1 20211128 , Alpine clang version 12.0.1
> 15 6.98 alt:p8 : FAIL gcc version 5.3.1 20151207 (ALT p8 5.3.1-alt3.M80P.1) (GCC)
> In file included from bench/futex-hash.c:29:0:
> bench/futex.h:37:2: error: unknown type name '__kernel_old_time_t'
> __kernel_old_time_t tv_sec; /* seconds */
> ^
> In file included from bench/futex-wake.c:25:0:
> bench/futex.h:37:2: error: unknown type name '__kernel_old_time_t'
> __kernel_old_time_t tv_sec; /* seconds */
> ^
> In file included from bench/futex-wake-parallel.c:31:0:
> bench/futex.h:37:2: error: unknown type name '__kernel_old_time_t'
> __kernel_old_time_t tv_sec; /* seconds */
> ^
> make[3]: *** [bench] Error 2
> 16 73.65 alt:p9 : Ok x86_64-alt-linux-gcc (GCC) 8.4.1 20200305 (ALT p9 8.4.1-alt0.p9.1) , clang version 10.0.0
> 17 72.34 alt:sisyphus : Ok x86_64-alt-linux-gcc (GCC) 11.2.1 20210911 (ALT Sisyphus 11.2.1-alt1) , ALT Linux Team clang version 12.0.1
> 18 7.58 amazonlinux:1 : FAIL gcc version 7.2.1 20170915 (Red Hat 7.2.1-2) (GCC)
> In file included from bench/futex-hash.c:29:0:
> bench/futex.h:37:2: error: unknown type name '__kernel_old_time_t'
> __kernel_old_time_t tv_sec; /* seconds */
> ^~~~~~~~~~~~~~~~~~~
> In file included from bench/futex-wake.c:25:0:
> bench/futex.h:37:2: error: unknown type name '__kernel_old_time_t'
> __kernel_old_time_t tv_sec; /* seconds */
> ^~~~~~~~~~~~~~~~~~~
> make[3]: *** [bench] Error 2
> 19 8.28 amazonlinux:2 : FAIL gcc version 7.3.1 20180712 (Red Hat 7.3.1-13) (GCC)
> In file included from bench/futex-hash.c:29:0:
> bench/futex.h:37:2: error: unknown type name '__kernel_old_time_t'
> __kernel_old_time_t tv_sec; /* seconds */
> ^~~~~~~~~~~~~~~~~~~
> make[3]: *** [bench] Error 2
> 20 79.16 centos:8 : Ok gcc (GCC) 8.4.1 20200928 (Red Hat 8.4.1-1) , clang version 11.0.1 (Red Hat 11.0.1-1.module_el8.4.0+966+2995ef20)
>
>
> Still building on the other containers.
Some more:
21 94.54 centos:stream : Ok gcc (GCC) 8.5.0 20210514 (Red Hat 8.5.0-3) , clang version 12.0.1 (Red Hat 12.0.1-2.module_el8.6.0+937+1cafe22c)
22 48.51 clearlinux:latest : Ok gcc (Clear Linux OS for Intel Architecture) 11.2.1 20211202 releases/gcc-11.2.0-549-g2d5be1fca0 , clang version 11.1.0
23 7.38 debian:9 : FAIL gcc version 6.3.0 20170516 (Debian 6.3.0-18+deb9u1)
In file included from bench/futex-wake.c:25:0:
bench/futex.h:37:2: error: unknown type name '__kernel_old_time_t'
__kernel_old_time_t tv_sec; /* seconds */
^~~~~~~~~~~~~~~~~~~
In file included from bench/futex-hash.c:29:0:
bench/futex.h:37:2: error: unknown type name '__kernel_old_time_t'
__kernel_old_time_t tv_sec; /* seconds */
^~~~~~~~~~~~~~~~~~~
/git/perf-5.16.0-rc4/tools/build/Makefile.build:139: recipe for target 'bench' failed
make[3]: *** [bench] Error 2
24 7.08 debian:10 : FAIL gcc version 8.3.0 (Debian 8.3.0-6)
In file included from bench/futex-hash.c:29:
bench/futex.h:37:2: error: unknown type name '__kernel_old_time_t'
__kernel_old_time_t tv_sec; /* seconds */
^~~~~~~~~~~~~~~~~~~
In file included from bench/futex-wake.c:25:
bench/futex.h:37:2: error: unknown type name '__kernel_old_time_t'
__kernel_old_time_t tv_sec; /* seconds */
^~~~~~~~~~~~~~~~~~~
make[3]: *** [/git/perf-5.16.0-rc4/tools/build/Makefile.build:139: bench] Error 2
25 79.95 debian:11 : Ok gcc (Debian 10.2.1-6) 10.2.1 20210110 , Debian clang version 11.0.1-2
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2021-12-10 13:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 23:58 [PATCH v5 1/6] perf bench futex: Add support for 32-bit systems with 64-bit time_t Alistair Francis
2021-12-10 13:12 ` Arnaldo Carvalho de Melo
2021-12-10 13:36 ` Arnaldo Carvalho de Melo
2021-12-10 13:44 ` Arnaldo Carvalho de Melo [this message]
2021-12-10 14:23 ` Arnd Bergmann
2021-12-11 11:28 ` Arnaldo Carvalho de Melo
2022-02-01 5:37 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbNZw1/cUXJ8up5b@kernel.org \
--to=acme@kernel.org \
--cc=acme@redhat.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=alistair.francis@opensource.wdc.com \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=arnd@arndb.de \
--cc=atish.patra@wdc.com \
--cc=dave@stgolabs.net \
--cc=dvhart@infradead.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox