From: Lee Jones <lee.jones@linaro.org>
To: Zong Li <zong.li@sifive.com>
Cc: mturquette@baylibre.com, sboyd@kernel.org, palmer@dabbelt.com,
paul.walmsley@sifive.com, linux-clk@vger.kernel.org,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH v4] clk: sifive: Fix W=1 kernel build warning
Date: Mon, 10 Jan 2022 09:51:07 +0000 [thread overview]
Message-ID: <YdwBi7uwH4NHi0GD@google.com> (raw)
In-Reply-To: <20220110065536.11451-1-zong.li@sifive.com>
On Mon, 10 Jan 2022, Zong Li wrote:
> This commit reverts commit 487dc7bb6a0c ("clk: sifive: fu540-prci:
> Declare static const variable 'prci_clk_fu540' where it's used").
> For fixing W=1 kernel build warning(s) about ‘prci_clk_fu540’ defined
> but not used [-Wunused-const-variable=], the problem is that the C file
> of fu540 and fu740 doesn't use these variables, but they include the
> header files. We could refine the code by moving the definition of these
> variables into fu540 and fu740 implementation respectively instead of
> common core code, then we could still separate the SoCs-dependent data
> in their own implementation.
>
> Fixes: 487dc7bb6a0c ("clk: sifive: fu540-prci: Declare static const variable 'prci_clk_fu540' where it's used")
Okay, that's good.
My other comments still apply here though.
> Signed-off-by: Zong Li <zong.li@sifive.com>
>
> ---
> Changed in v4:
> - Rebase on v5.16
> - Modify fixes tag
>
> Changed in v3:
> - Rebase on v5.16-rc8
> - Add fixes tag
>
> Changed in v2:
> - Move definition of variable to C file from header
> ---
> drivers/clk/sifive/fu540-prci.c | 6 +++++-
> drivers/clk/sifive/fu540-prci.h | 6 +-----
> drivers/clk/sifive/fu740-prci.c | 6 +++++-
> drivers/clk/sifive/fu740-prci.h | 11 +----------
> drivers/clk/sifive/sifive-prci.c | 5 -----
> 5 files changed, 12 insertions(+), 22 deletions(-)
--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
prev parent reply other threads:[~2022-01-10 9:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-10 6:55 [PATCH v4] clk: sifive: Fix W=1 kernel build warning Zong Li
2022-01-10 9:51 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YdwBi7uwH4NHi0GD@google.com \
--to=lee.jones@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=sboyd@kernel.org \
--cc=zong.li@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).