Re: [PATCH] riscv: Work to remove kernel dependence on the M-extension

Arnd Bergmann
2022-03-09T11:49:03Z

On Wed, Mar 9, 2022 at 12:43 PM Michael T. Kloos
<michael@michaelkloos.com> wrote:
>
> Thank you for your feedback. I don't really have much of an
> opinion about that right now aside from that I know where things
> are in the current structure and am comfortable. My goal with this
> contribution was to keep it in-line with the current config
> structure. Hence, I put it right next to the menuconfig option
> to control CONFIG_RISCV_ISA_C under Platform Type.
>
> I wouldn't necessarily be opposed to rethinking the way platform
> feature selection is presented in menuconfig. If people feel that
> most users will be looking for an rv64gc config and that it should
> be made for clear, perhaps it could be done. I would need to do
> more thinking about how exactly that would look.
>
> I do think that it is outside the scope of this patch. Were you
> working on something like that and worried about a merge conflict?

As I said, I think your patch is ok, and I have no objections to it
being merged. It's just one more option among others that
can cause problems if users get it wrong.

Arnd