From: Wolfram Sang <wsa@kernel.org>
To: Conor.Dooley@microchip.com
Cc: linux-i2c@vger.kernel.org, ben.dooks@codethink.co.uk,
Daire.McNamara@microchip.com, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH v3] i2c: add support for microchip fpga i2c controllers
Date: Sat, 21 May 2022 13:28:48 +0200 [thread overview]
Message-ID: <YojM8KiGJneGh16D@shikoro> (raw)
In-Reply-To: <dbf6073c-0814-ec25-cec5-cb3cf9c931d8@microchip.com>
[-- Attachment #1.1: Type: text/plain, Size: 536 bytes --]
> > > + ret = devm_request_irq(&pdev->dev, irq, mchp_corei2c_isr, IRQF_SHARED,
> > > + pdev->name, idev);
> >
> > Really SHARED?
>
> Yeah, this driver supports both the hard peripherals & soft FPGA cores.
> The hard peripherals do not have shared IRQs, but we don't really have
> any control over what way the interrupts are wired for the soft cores.
> Worth adding a comment to explain the reason for it being shared?
Yes. Such information never hurst, I'd say.
Thanks, have a nice weekend,
Wolfram
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
prev parent reply other threads:[~2022-05-21 11:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-16 7:33 [PATCH v3] i2c: add support for microchip fpga i2c controllers Conor Dooley
2022-05-21 9:48 ` Wolfram Sang
2022-05-21 11:27 ` Conor.Dooley
2022-05-21 11:28 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YojM8KiGJneGh16D@shikoro \
--to=wsa@kernel.org \
--cc=Conor.Dooley@microchip.com \
--cc=Daire.McNamara@microchip.com \
--cc=ben.dooks@codethink.co.uk \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox