Re: [PATCH v5 7/7] KVM: selftests: Add ucall pool based implementation

Sean Christopherson
2022-08-30T04:27:29Z

On Mon, Aug 29, 2022, Andrew Jones wrote:
> On Thu, Aug 25, 2022 at 11:25:22PM +0000, Sean Christopherson wrote:
> > +static struct ucall *ucall_alloc(void)
> > +{
> > + struct ucall *uc;
> > + int i;
> > +
> > + GUEST_ASSERT(ucall_pool && ucall_pool->in_use);
>
> ucall_pool->in_use will never be null.
>
> > +
> > + for (i = 0; i < KVM_MAX_VCPUS; ++i) {
> > + if (!atomic_test_and_set_bit(i, ucall_pool->in_use)) {
> > + uc = &ucall_pool->ucalls[i];
> > + memset(uc->args, 0, sizeof(uc->args));
> > + return uc;
> > + }
> > + }
>
> nit: blank line

Got 'em. Thanks for the reviews, much appreciated!