From: Catalin Marinas <catalin.marinas@arm.com>
To: "liaochang (A)" <liaochang1@huawei.com>
Cc: will@kernel.org, guoren@kernel.org, paul.walmsley@sifive.com,
palmer@dabbelt.com, aou@eecs.berkeley.edu, mhiramat@kernel.org,
rostedt@goodmis.org, maz@kernel.org, alexandru.elisei@arm.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH 3/3] arm64/kprobe: Optimize the performance of patching single-step slot
Date: Fri, 30 Sep 2022 09:15:48 +0100 [thread overview]
Message-ID: <YzaltNF5PqYq4x4O@arm.com> (raw)
In-Reply-To: <c301bfbe-afa8-ab1a-9062-56e4612fdf2c@huawei.com>
On Fri, Sep 30, 2022 at 09:02:20AM +0800, liaochang (A) wrote:
>
>
> 在 2022/9/30 0:50, Catalin Marinas 写道:
> > On Tue, Sep 27, 2022 at 10:24:35AM +0800, Liao Chang wrote:
> >> Single-step slot would not be used until kprobe is enabled, that means
> >> no race condition occurs on it under SMP, hence it is safe to pacth ss
> >> slot without stopping machine.
> >>
> >> Since I and D caches are coherent within single-step slot from
> >> aarch64_insn_patch_text_nosync(), hence no need to do it again via
> >> flush_icache_range().
> >>
> >> Acked-by: Will Deacon <will@kernel.org>
> >> Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> >> Signed-off-by: Liao Chang <liaochang1@huawei.com>
> >> ---
> >> arch/arm64/kernel/probes/kprobes.c | 27 +++++++++++++++++++++------
> >> 1 file changed, 21 insertions(+), 6 deletions(-)
> >
> > What's your expectation with this series, should the arch maintainers
> > just pick the individual patches?
>
> Yes, or should i split this series into individual patch?
No need to, I can pick the arm64 patch. If the other maintainers don't
merge the patches, you might want to post them again individually as to
avoid confusion.
--
Catalin
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2022-09-30 8:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 2:24 [PATCH V4 0/3] kprobe: Optimize the performance of patching ss Liao Chang
2022-09-27 2:24 ` [PATCH 1/3] riscv/kprobe: Optimize the performance of patching single-step slot Liao Chang
2022-09-27 2:24 ` [PATCH 2/3] csky/kprobe: " Liao Chang
2022-09-27 2:24 ` [PATCH 3/3] arm64/kprobe: " Liao Chang
2022-09-29 16:50 ` Catalin Marinas
2022-09-30 1:02 ` liaochang (A)
2022-09-30 8:15 ` Catalin Marinas [this message]
2022-09-30 16:25 ` (subset) [PATCH V4 0/3] kprobe: Optimize the performance of patching ss Catalin Marinas
-- strict thread matches above, loose matches on Subject: below --
2022-09-23 8:46 [PATCH V3 " Liao Chang
2022-09-23 8:46 ` [PATCH 3/3] arm64/kprobe: Optimize the performance of patching single-step slot Liao Chang
2022-09-23 12:35 ` Will Deacon
2022-09-23 12:39 ` Mark Rutland
2022-09-24 1:52 ` liaochang (A)
2022-09-25 1:21 ` Masami Hiramatsu
2022-09-27 1:37 ` liaochang (A)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzaltNF5PqYq4x4O@arm.com \
--to=catalin.marinas@arm.com \
--cc=alexandru.elisei@arm.com \
--cc=aou@eecs.berkeley.edu \
--cc=guoren@kernel.org \
--cc=liaochang1@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=maz@kernel.org \
--cc=mhiramat@kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=rostedt@goodmis.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).