From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9924DE77188 for ; Tue, 14 Jan 2025 21:24:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=kbqkktmASg/Csp6Z9jhGE+dOnDVWCJCNGWYgzlhQ6jg=; b=3PVfrlbeGEXy8EPrcMcCQRpLdh kyt1aHvGgoVbgaBmeesEcFcvbHU7/7fBrjRUKMiczWl46Ui5ZdMwPuOk4fcnRabYJxxPD8sJRlH36 pP0Msz9TVuN8FMxDgt8xk5cqvFrPFp/8rbA8zDxGnvzFXwvUqIrtwVEHVPsylE5c3BPTIpLPXv7Yz KLKAbXFWAEy+TAs428nQL8mJuwpgfjqkKFDJhIScnE+gNU/t7a9rLNFnrW7AM/fo7N/xJlLo6X3F2 LP5XqIt7XZ/EljzR9RLeYnxFUlGmKG28CK09J1S8kQZg6k7lcETnXYHPY1PNps2LTecyGQTZQTMI9 3bQDqoIQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tXoOg-00000009nYJ-2EUn; Tue, 14 Jan 2025 21:24:26 +0000 Received: from mail-pj1-x1049.google.com ([2607:f8b0:4864:20::1049]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tXoOd-00000009nWY-3o6H for linux-riscv@lists.infradead.org; Tue, 14 Jan 2025 21:24:24 +0000 Received: by mail-pj1-x1049.google.com with SMTP id 98e67ed59e1d1-2efa0eb9dacso10826853a91.1 for ; Tue, 14 Jan 2025 13:24:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736889862; x=1737494662; darn=lists.infradead.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=8cSsXdzV+ZwQOEMikMUZ9KmnzJy+D1+up+g+W/Xr/ho=; b=lXVnvOZ8KFuPz2woRaZtlsneiv44NUj8cbL1rO9Q25MUho7kuTiTLNhlbk9FbFetuE xth+GCqftDmku1sshYrY/dY0Im0IkfCgCgrkQmo8hBcTA9fvTpJok0gfj8u8skQU9WM2 iq2Q7Y3dVycvUULu2a03ty3X2V06hXWXNOZOfCfLZeG0OXBzxeWFI+tDyV9g/ypU5erA GFqRyNkwusT8NxdOqLjOwgVaFAZmn5k2ai4wDw45JuX3752znFM/5/X7KfN6Dt09rN3l s4nQBl9cpru8IaWRJHrc5lskKiDBblEmo66IAaOxg/U7wZ4HP+S9nidWiXoouz2KnQb/ oZIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736889862; x=1737494662; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8cSsXdzV+ZwQOEMikMUZ9KmnzJy+D1+up+g+W/Xr/ho=; b=Q4QfQytdRJCqMhNncYVshMJTDyxr4KYe2ZCsKrANJ5YsCj3Af8ch20xh/uH0jzAhpj pmgreHqnpf6SRo0uWdDk96Bp/q2fRlhVDDNAFilYsBOhWaJJOoqfSsUOO7nWn4qLWkp4 jy8LlJVLSb1t3ubBGXztsoJkJUmMT/WbV7otX5QWs27ScW6EONvbE29ZWx8LumlsOj5x MDavLWqaxSdA8luEwjxXc+YHYdiiaFThOdi6Mn+f1ebfLluRmbaJV3kS/A0hmO0my7+P 5aVioNot3y4DT5b4zemgptXcKuDA27EIZgvGfLB5LrWetCM/2TdoTwi5niuGyLXJl+1F 9NTw== X-Forwarded-Encrypted: i=1; AJvYcCWlXj0WFyVbgqoyhQfy8WaNLuoIY19mbflEvwaRqdqCrlAztpiAo8nrXA3TuDKqfRhkhPfjFEHFSeZASQ==@lists.infradead.org X-Gm-Message-State: AOJu0Yw+YCfchQsEQy9Q04ikk1Pq3thE/FSIKBBGJqjFwUr7QlZ7nmuV pN3eRWJeXV/el4Ki0nOuIsIpz2VeUUT+oWaPTzcfHVbN4WoNshq47TGTSpQGxsRD9OKCZ7seFDG Pwg== X-Google-Smtp-Source: AGHT+IGaqEwoic7xvDyznY8cDg+F7K5+qe11MRhfXOt+1PBXtCG3HV5nSK8yv8Q3/q/HTXMyOsqLmKxvwkg= X-Received: from pjbtc8.prod.google.com ([2002:a17:90b:5408:b0:2ef:abba:8bfd]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:2b87:b0:2ee:8031:cdbc with SMTP id 98e67ed59e1d1-2f548f1ec3fmr32208440a91.23.1736889862547; Tue, 14 Jan 2025 13:24:22 -0800 (PST) Date: Tue, 14 Jan 2025 13:24:21 -0800 In-Reply-To: <20250114175143.81438-28-vschneid@redhat.com> Mime-Version: 1.0 References: <20250114175143.81438-1-vschneid@redhat.com> <20250114175143.81438-28-vschneid@redhat.com> Message-ID: Subject: Re: [PATCH v4 27/30] x86/tlb: Make __flush_tlb_local() noinstr-compliant From: Sean Christopherson To: Valentin Schneider Cc: linux-kernel@vger.kernel.org, x86@kernel.org, virtualization@lists.linux.dev, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-riscv@lists.infradead.org, linux-perf-users@vger.kernel.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, linux-arch@vger.kernel.org, rcu@vger.kernel.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, bpf@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, Juergen Gross , Ajay Kaher , Alexey Makhalov , Russell King , Catalin Marinas , Will Deacon , Huacai Chen , WANG Xuerui , Paul Walmsley , Palmer Dabbelt , Albert Ou , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Boris Ostrovsky , Josh Poimboeuf , Pawan Gupta , Paolo Bonzini , Andy Lutomirski , Arnd Bergmann , Frederic Weisbecker , "Paul E. McKenney" , Jason Baron , Steven Rostedt , Ard Biesheuvel , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Boqun Feng , Uladzislau Rezki , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Juri Lelli , Clark Williams , Yair Podemsky , Tomas Glozar , Vincent Guittot , Dietmar Eggemann , Ben Segall , Mel Gorman , Kees Cook , Andrew Morton , Christoph Hellwig , Shuah Khan , Sami Tolvanen , Miguel Ojeda , Alice Ryhl , "Mike Rapoport (Microsoft)" , Samuel Holland , Rong Xu , Nicolas Saenz Julienne , Geert Uytterhoeven , Yosry Ahmed , "Kirill A. Shutemov" , "Masami Hiramatsu (Google)" , Jinghao Jia , Luis Chamberlain , Randy Dunlap , Tiezhu Yang X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250114_132423_939831_952E5470 X-CRM114-Status: GOOD ( 13.21 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Tue, Jan 14, 2025, Valentin Schneider wrote: > Later patches will require issuing a __flush_tlb_all() from noinstr code. > This requires making both __flush_tlb_local() and __flush_tlb_global() > noinstr-compliant. > > For __flush_tlb_local(), xen_flush_tlb() has already been made noinstr, so > it's just native_flush_tlb_global(), and simply __always_inline'ing > invalidate_user_asid() gets us there > > Signed-off-by: Valentin Schneider > --- ... > @@ -1206,7 +1206,7 @@ STATIC_NOPV noinstr void native_flush_tlb_global(void) > /* > * Flush the entire current user mapping > */ > -STATIC_NOPV void native_flush_tlb_local(void) > +STATIC_NOPV noinstr void native_flush_tlb_local(void) native_write_cr3() and __native_read_cr3() need to be __always_inline. vmlinux.o: warning: objtool: native_flush_tlb_local+0x8: call to __native_read_cr3() leaves .noinstr.text section _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv