* [PATCH 12/20] clk: microchip: mpfs: remove MODULE_LICENSE in non-modules
2023-02-28 13:01 [PATCH 00/20] MODULE_LICENSE removals, fifth tranche Nick Alcock
@ 2023-02-28 13:02 ` Nick Alcock
2023-02-28 19:19 ` Conor Dooley
2023-02-28 13:02 ` [PATCH 13/20] reset: " Nick Alcock
` (2 subsequent siblings)
3 siblings, 1 reply; 10+ messages in thread
From: Nick Alcock @ 2023-02-28 13:02 UTC (permalink / raw)
To: mcgrof
Cc: linux-modules, linux-kernel, Hitomi Hasegawa, Conor Dooley,
Daire McNamara, Michael Turquette, Stephen Boyd, linux-riscv,
linux-clk
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
Cc: Conor Dooley <conor.dooley@microchip.com>
Cc: Daire McNamara <daire.mcnamara@microchip.com>
Cc: Michael Turquette <mturquette@baylibre.com>
Cc: Stephen Boyd <sboyd@kernel.org>
Cc: linux-riscv@lists.infradead.org
Cc: linux-clk@vger.kernel.org
---
drivers/clk/microchip/clk-mpfs.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/clk/microchip/clk-mpfs.c b/drivers/clk/microchip/clk-mpfs.c
index 4f0a19db7ed74..d85b345f4c08d 100644
--- a/drivers/clk/microchip/clk-mpfs.c
+++ b/drivers/clk/microchip/clk-mpfs.c
@@ -513,4 +513,3 @@ MODULE_DESCRIPTION("Microchip PolarFire SoC Clock Driver");
MODULE_AUTHOR("Padmarao Begari <padmarao.begari@microchip.com>");
MODULE_AUTHOR("Daire McNamara <daire.mcnamara@microchip.com>");
MODULE_AUTHOR("Conor Dooley <conor.dooley@microchip.com>");
-MODULE_LICENSE("GPL");
--
2.39.1.268.g9de2f9a303
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 12/20] clk: microchip: mpfs: remove MODULE_LICENSE in non-modules
2023-02-28 13:02 ` [PATCH 12/20] clk: microchip: mpfs: remove MODULE_LICENSE in non-modules Nick Alcock
@ 2023-02-28 19:19 ` Conor Dooley
0 siblings, 0 replies; 10+ messages in thread
From: Conor Dooley @ 2023-02-28 19:19 UTC (permalink / raw)
To: Nick Alcock
Cc: mcgrof, linux-modules, linux-kernel, Hitomi Hasegawa,
Conor Dooley, Daire McNamara, Michael Turquette, Stephen Boyd,
linux-riscv, linux-clk
[-- Attachment #1.1: Type: text/plain, Size: 1900 bytes --]
On Tue, Feb 28, 2023 at 01:02:07PM +0000, Nick Alcock wrote:
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
>
> So remove it in the files in this commit, none of which can be built as
> modules.
>
> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
> Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> Cc: linux-modules@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
> Cc: Conor Dooley <conor.dooley@microchip.com>
> Cc: Daire McNamara <daire.mcnamara@microchip.com>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: linux-riscv@lists.infradead.org
> Cc: linux-clk@vger.kernel.org
> ---
> drivers/clk/microchip/clk-mpfs.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/clk/microchip/clk-mpfs.c b/drivers/clk/microchip/clk-mpfs.c
> index 4f0a19db7ed74..d85b345f4c08d 100644
> --- a/drivers/clk/microchip/clk-mpfs.c
> +++ b/drivers/clk/microchip/clk-mpfs.c
> @@ -513,4 +513,3 @@ MODULE_DESCRIPTION("Microchip PolarFire SoC Clock Driver");
> MODULE_AUTHOR("Padmarao Begari <padmarao.begari@microchip.com>");
> MODULE_AUTHOR("Daire McNamara <daire.mcnamara@microchip.com>");
> MODULE_AUTHOR("Conor Dooley <conor.dooley@microchip.com>");
> -MODULE_LICENSE("GPL");
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
I'll take this via the microchip/at91 clock tree after v6.3-rc1 has been
released.
Thanks,
Conor.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 13/20] reset: remove MODULE_LICENSE in non-modules
2023-02-28 13:01 [PATCH 00/20] MODULE_LICENSE removals, fifth tranche Nick Alcock
2023-02-28 13:02 ` [PATCH 12/20] clk: microchip: mpfs: remove MODULE_LICENSE in non-modules Nick Alcock
@ 2023-02-28 13:02 ` Nick Alcock
2023-02-28 19:17 ` Conor Dooley
2023-02-28 13:47 ` [PATCH 00/20] MODULE_LICENSE removals, fifth tranche Geert Uytterhoeven
2023-03-09 16:14 ` Greg KH
3 siblings, 1 reply; 10+ messages in thread
From: Nick Alcock @ 2023-02-28 13:02 UTC (permalink / raw)
To: mcgrof
Cc: linux-modules, linux-kernel, Hitomi Hasegawa, Conor Dooley,
Daire McNamara, Philipp Zabel, linux-riscv
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
Cc: Conor Dooley <conor.dooley@microchip.com>
Cc: Daire McNamara <daire.mcnamara@microchip.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: linux-riscv@lists.infradead.org
---
drivers/reset/reset-mpfs.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/reset/reset-mpfs.c b/drivers/reset/reset-mpfs.c
index e003e50590ec5..e71ab73092abd 100644
--- a/drivers/reset/reset-mpfs.c
+++ b/drivers/reset/reset-mpfs.c
@@ -153,5 +153,4 @@ module_auxiliary_driver(mpfs_reset_driver);
MODULE_DESCRIPTION("Microchip PolarFire SoC Reset Driver");
MODULE_AUTHOR("Conor Dooley <conor.dooley@microchip.com>");
-MODULE_LICENSE("GPL");
MODULE_IMPORT_NS(MCHP_CLK_MPFS);
--
2.39.1.268.g9de2f9a303
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 13/20] reset: remove MODULE_LICENSE in non-modules
2023-02-28 13:02 ` [PATCH 13/20] reset: " Nick Alcock
@ 2023-02-28 19:17 ` Conor Dooley
2023-02-28 19:26 ` Nick Alcock
0 siblings, 1 reply; 10+ messages in thread
From: Conor Dooley @ 2023-02-28 19:17 UTC (permalink / raw)
To: Nick Alcock
Cc: mcgrof, linux-modules, linux-kernel, Hitomi Hasegawa,
Conor Dooley, Daire McNamara, Philipp Zabel, linux-riscv
[-- Attachment #1.1: Type: text/plain, Size: 1278 bytes --]
On Tue, Feb 28, 2023 at 01:02:08PM +0000, Nick Alcock wrote:
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
>
> So remove it in the files in this commit, none of which can be built as
> modules.
>
> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
> Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> Cc: linux-modules@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
> Cc: Conor Dooley <conor.dooley@microchip.com>
> Cc: Daire McNamara <daire.mcnamara@microchip.com>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: linux-riscv@lists.infradead.org
> ---
> drivers/reset/reset-mpfs.c | 1 -
I assume your script just got confused here w/ $subject, since there's
only a change for this specific file.
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH 13/20] reset: remove MODULE_LICENSE in non-modules
2023-02-28 19:17 ` Conor Dooley
@ 2023-02-28 19:26 ` Nick Alcock
2023-02-28 19:53 ` Conor Dooley
0 siblings, 1 reply; 10+ messages in thread
From: Nick Alcock @ 2023-02-28 19:26 UTC (permalink / raw)
To: Conor Dooley; +Cc: linux-modules, linux-kernel, linux-riscv
[dropped non-lists to defend innocent ears from my flaming pedantry]
On 28 Feb 2023, Conor Dooley stated:
> On Tue, Feb 28, 2023 at 01:02:08PM +0000, Nick Alcock wrote:
>> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
>> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
>> are used to identify modules. As a consequence, uses of the macro
>> in non-modules will cause modprobe to misidentify their containing
>> object file as a module when it is not (false positives), and modprobe
>> might succeed rather than failing with a suitable error message.
>>
>> So remove it in the files in this commit, none of which can be built as
>> modules.
>>
>> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
>> Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
>> Cc: Luis Chamberlain <mcgrof@kernel.org>
>> Cc: linux-modules@vger.kernel.org
>> Cc: linux-kernel@vger.kernel.org
>> Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
>> Cc: Conor Dooley <conor.dooley@microchip.com>
>> Cc: Daire McNamara <daire.mcnamara@microchip.com>
>> Cc: Philipp Zabel <p.zabel@pengutronix.de>
>> Cc: linux-riscv@lists.infradead.org
>> ---
>> drivers/reset/reset-mpfs.c | 1 -
>
> I assume your script just got confused here w/ $subject, since there's
> only a change for this specific file.
This file has had no commits since you wrote it last year, and the
subject for that commit was
reset: add polarfire soc reset support
so, er, yes, the script used 'reset:' as a prefix, mimicking the
existing commit. I'm not sure what else it could have done.
(Regarding the rest of the subject line, I suppose I could have arranged
to detect single-file commits and turned the subject into 'in this
non-module'? But there comes a time when even I think that maybe I might
be overdesigning something, and automated grammatical adjustments to the
subject line was that point!)
--
NULL && (void)
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH 13/20] reset: remove MODULE_LICENSE in non-modules
2023-02-28 19:26 ` Nick Alcock
@ 2023-02-28 19:53 ` Conor Dooley
0 siblings, 0 replies; 10+ messages in thread
From: Conor Dooley @ 2023-02-28 19:53 UTC (permalink / raw)
To: Nick Alcock; +Cc: linux-modules, linux-kernel, linux-riscv
[-- Attachment #1.1: Type: text/plain, Size: 2451 bytes --]
On Tue, Feb 28, 2023 at 07:26:55PM +0000, Nick Alcock wrote:
> [dropped non-lists to defend innocent ears from my flaming pedantry]
>
> On 28 Feb 2023, Conor Dooley stated:
>
> > On Tue, Feb 28, 2023 at 01:02:08PM +0000, Nick Alcock wrote:
> >> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> >> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> >> are used to identify modules. As a consequence, uses of the macro
> >> in non-modules will cause modprobe to misidentify their containing
> >> object file as a module when it is not (false positives), and modprobe
> >> might succeed rather than failing with a suitable error message.
> >>
> >> So remove it in the files in this commit, none of which can be built as
> >> modules.
> >>
> >> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
> >> Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
> >> Cc: Luis Chamberlain <mcgrof@kernel.org>
> >> Cc: linux-modules@vger.kernel.org
> >> Cc: linux-kernel@vger.kernel.org
> >> Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
> >> Cc: Conor Dooley <conor.dooley@microchip.com>
> >> Cc: Daire McNamara <daire.mcnamara@microchip.com>
> >> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> >> Cc: linux-riscv@lists.infradead.org
> >> ---
> >> drivers/reset/reset-mpfs.c | 1 -
> >
> > I assume your script just got confused here w/ $subject, since there's
> > only a change for this specific file.
>
> This file has had no commits since you wrote it last year, and the
> subject for that commit was
>
> reset: add polarfire soc reset support
>
> so, er, yes, the script used 'reset:' as a prefix, mimicking the
> existing commit. I'm not sure what else it could have done.
Oh ye, silly me - I didn't think of that. I guess that's a common
pattern for commits adding a driver, as the "mpfs:" doesn't really make
sense until the driver is in-tree.
I'm not too sure what you could have done either, but I'm not
complaining, or requesting that something be changed here.
> (Regarding the rest of the subject line, I suppose I could have arranged
> to detect single-file commits and turned the subject into 'in this
> non-module'? But there comes a time when even I think that maybe I might
> be overdesigning something, and automated grammatical adjustments to the
> subject line was that point!)
Yeah, I think it's not worth doing anything about really...
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 00/20] MODULE_LICENSE removals, fifth tranche
2023-02-28 13:01 [PATCH 00/20] MODULE_LICENSE removals, fifth tranche Nick Alcock
2023-02-28 13:02 ` [PATCH 12/20] clk: microchip: mpfs: remove MODULE_LICENSE in non-modules Nick Alcock
2023-02-28 13:02 ` [PATCH 13/20] reset: " Nick Alcock
@ 2023-02-28 13:47 ` Geert Uytterhoeven
2023-03-20 11:06 ` Nick Alcock
2023-03-09 16:14 ` Greg KH
3 siblings, 1 reply; 10+ messages in thread
From: Geert Uytterhoeven @ 2023-02-28 13:47 UTC (permalink / raw)
To: Nick Alcock
Cc: mcgrof, linux-clk, linux-gpio, linux-kernel, linux-modules,
linux-perf-users, linux-pm, linux-remoteproc, linux-renesas-soc,
linux-riscv, linux-serial, linux-tegra, linux-trace-devel,
linux-trace-kernel
Hi Nick,
On Tue, Feb 28, 2023 at 2:05 PM Nick Alcock <nick.alcock@oracle.com> wrote:
> This series, based on current modules-next, is part of a treewide cleanup
> suggested by Luis Chamberlain, to remove the LICENSE_MODULE usage from
> files/objects that are not tristate. Due to recent changes to kbuild, these
> uses are now problematic. See the commit logs for more details.
Does this mean you expect us to queue them for v6.3?
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH 00/20] MODULE_LICENSE removals, fifth tranche
2023-02-28 13:47 ` [PATCH 00/20] MODULE_LICENSE removals, fifth tranche Geert Uytterhoeven
@ 2023-03-20 11:06 ` Nick Alcock
0 siblings, 0 replies; 10+ messages in thread
From: Nick Alcock @ 2023-03-20 11:06 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Nick Alcock, mcgrof, linux-clk, linux-gpio, linux-kernel,
linux-modules, linux-perf-users, linux-pm, linux-remoteproc,
linux-renesas-soc, linux-riscv, linux-serial, linux-tegra,
linux-trace-devel, linux-trace-kernel
On 28 Feb 2023, Geert Uytterhoeven outgrape:
> On Tue, Feb 28, 2023 at 2:05 PM Nick Alcock <nick.alcock@oracle.com> wrote:
>> This series, based on current modules-next, is part of a treewide cleanup
>> suggested by Luis Chamberlain, to remove the LICENSE_MODULE usage from
>> files/objects that are not tristate. Due to recent changes to kbuild, these
>> uses are now problematic. See the commit logs for more details.
>
> Does this mean you expect us to queue them for v6.3?
> Thanks!
I believe Luis is planning to pull them in around -rc3, hence my
freshening the series up now, getting everyone's tags in, etc.
--
NULL && (void)
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 00/20] MODULE_LICENSE removals, fifth tranche
2023-02-28 13:01 [PATCH 00/20] MODULE_LICENSE removals, fifth tranche Nick Alcock
` (2 preceding siblings ...)
2023-02-28 13:47 ` [PATCH 00/20] MODULE_LICENSE removals, fifth tranche Geert Uytterhoeven
@ 2023-03-09 16:14 ` Greg KH
3 siblings, 0 replies; 10+ messages in thread
From: Greg KH @ 2023-03-09 16:14 UTC (permalink / raw)
To: Nick Alcock
Cc: mcgrof, linux-clk, linux-gpio, linux-kernel, linux-modules,
linux-perf-users, linux-pm, linux-remoteproc, linux-renesas-soc,
linux-riscv, linux-serial, linux-tegra, linux-trace-devel,
linux-trace-kernel
On Tue, Feb 28, 2023 at 01:01:55PM +0000, Nick Alcock wrote:
> This series, based on current modules-next, is part of a treewide cleanup
> suggested by Luis Chamberlain, to remove the LICENSE_MODULE usage from
> files/objects that are not tristate. Due to recent changes to kbuild, these
> uses are now problematic. See the commit logs for more details.
Why isn't kbuild fixed instead? These files can have MODULE_AUTHOR()
and other macros when built into the kernel, what is so special about
MODULE_LICENSE() that prevents this from working properly?
There should not be a need to remove these markings in my opinion, why
treat one MODULE_* macro more special than others?
thanks,
greg k-h
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 10+ messages in thread