From: Christoph Hellwig <hch@infradead.org>
To: Mathis Salmen <mathis.salmen@matsal.de>
Cc: linux-riscv@lists.infradead.org, palmer@dabbelt.com
Subject: Re: [PATCH] riscv: add icache flush for nommu sigreturn trampoline
Date: Wed, 5 Apr 2023 22:33:25 -0700 [thread overview]
Message-ID: <ZC5ZpVlN9Ypgy/sC@infradead.org> (raw)
In-Reply-To: <20230406001104.3361877-1-mathis.salmen@matsal.de>
On Thu, Apr 06, 2023 at 02:11:04AM +0200, Mathis Salmen wrote:
> + /* Make sure the two instructions are pushed to icache. */
> + flush_icache_range((uintptr_t)&frame->sigreturn_code,
> + (uintptr_t)&frame->sigreturn_code + sizeof(frame->sigreturn_code));
> regs->ra = (unsigned long)&frame->sigreturn_code;
Please add a local variable for the in-casted value of
&frame->sigreturn_code to actually make this readable.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
prev parent reply other threads:[~2023-04-06 5:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-06 0:11 [PATCH] riscv: add icache flush for nommu sigreturn trampoline Mathis Salmen
2023-04-06 5:33 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZC5ZpVlN9Ypgy/sC@infradead.org \
--to=hch@infradead.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mathis.salmen@matsal.de \
--cc=palmer@dabbelt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).