Re: [PATCH v2 04/15] spi: Replace open coded spi_controller_xfer_timeout()

AngeloGioacchino Del Regno
2023-07-11T13:29:41Z

Il 11/07/23 15:05, Mark Brown ha scritto:
> On Tue, Jul 11, 2023 at 10:28:13AM +0200, AngeloGioacchino Del Regno wrote:
>> Il 10/07/23 17:49, Andy Shevchenko ha scritto:
>
>>> + ms = spi_controller_xfer_timeout(ctlr, xfer);
>
>> I agree on using helpers, but the logic is slightly changing here: yes it is
>> unlikely (and also probably useless) to get ms == UINT_MAX, but the helper is
>> limiting the maximum timeout value to 500mS, which may not work for some slow
>> controllers/devices.
>
> The helper is limiting the *minimum* timeout value to 500ms - it's using
> max() not min(). The idea is the other way around, that for a very fast
> transfer we don't want to end up with such a short timeout that it false
> triggers due to scheduling issues.

After reading the code again, yeah, I've totally misread it the first time. Argh!
Thanks! :-)