Re: [PATCH v2 03/15] spi: Replace if-else-if by bitops and multiplications

Mark Brown
2023-07-10T16:57:27Z

[-- Attachment #1.1: Type: text/plain, Size: 619 bytes --]

On Mon, Jul 10, 2023 at 06:49:20PM +0300, Andy Shevchenko wrote:

> - if (xfer->bits_per_word <= 8)
> - maxsize = maxwords;
> - else if (xfer->bits_per_word <= 16)
> - maxsize = 2 * maxwords;
> - else
> - maxsize = 4 * maxwords;
> -
> + maxsize = maxwords * roundup_pow_of_two(BITS_TO_BYTES(xfer->bits_per_word));

This will change the behaviour if bits_per_word is more than 32. That
is validated out elsewhere but I shouldn't have had to go around
checking the code to confirm that this is the case. This is the sort of
thing that should be highlighted when doing this sort of edge case
stylistic change.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]