From: Jisheng Zhang <jszhang@kernel.org>
To: Andrew Jones <ajones@ventanamicro.com>
Cc: Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] riscv: vdso.lds.S: merge .data section into .rodata section
Date: Fri, 28 Jul 2023 22:11:08 +0800 [thread overview]
Message-ID: <ZMPMfMPoG/KnuWLN@xhacker> (raw)
In-Reply-To: <20230728-cec389a85a7dc8dcca803e06@orel>
On Fri, Jul 28, 2023 at 02:57:03PM +0200, Andrew Jones wrote:
> On Thu, Jul 27, 2023 at 01:30:23AM +0800, Jisheng Zhang wrote:
> > The .data section doesn't need to be separate from .rodata section,
> > they are both readonly.
> >
> > Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> > ---
> > arch/riscv/kernel/vdso/vdso.lds.S | 15 +++++++--------
> > 1 file changed, 7 insertions(+), 8 deletions(-)
> >
> > diff --git a/arch/riscv/kernel/vdso/vdso.lds.S b/arch/riscv/kernel/vdso/vdso.lds.S
> > index d43fd7c7dd11..671aa21769bc 100644
> > --- a/arch/riscv/kernel/vdso/vdso.lds.S
> > +++ b/arch/riscv/kernel/vdso/vdso.lds.S
> > @@ -29,7 +29,13 @@ SECTIONS
> > .eh_frame_hdr : { *(.eh_frame_hdr) } :text :eh_frame_hdr
> > .eh_frame : { KEEP (*(.eh_frame)) } :text
> >
> > - .rodata : { *(.rodata .rodata.* .gnu.linkonce.r.*) }
> > + .rodata : {
> > + *(.rodata .rodata.* .gnu.linkonce.r.*)
> > + *(.got.plt) *(.got)
> > + *(.data .data.* .gnu.linkonce.d.*)
> > + *(.dynbss)
> > + *(.bss .bss.* .gnu.linkonce.b.*)
>
> Looking at other architectures, it appears the last three lines of
> sections could be discarded, but I don't know enough about this to
Hi Andrew,
I checked x86, they still keep those sections. From another side,
even if those sections are not needed, removing unused sections could
be an independent patch, for safe reason or bisect reason.
Thanks
> state they should be.
>
> Thanks,
> drew
>
>
> > + }
> >
> > /*
> > * This linker script is used both with -r and with -shared.
> > @@ -44,13 +50,6 @@ SECTIONS
> > .alternative : {
> > *(.alternative)
> > }
> > -
> > - .data : {
> > - *(.got.plt) *(.got)
> > - *(.data .data.* .gnu.linkonce.d.*)
> > - *(.dynbss)
> > - *(.bss .bss.* .gnu.linkonce.b.*)
> > - }
> > }
> >
> > /*
> > --
> > 2.40.1
> >
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-07-28 14:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 17:30 [PATCH 0/3] riscv: vdso.lds.S: some improvement Jisheng Zhang
2023-07-26 17:30 ` [PATCH 1/3] riscv: vdso.lds.S: drop __alt_start and __alt_end symbols Jisheng Zhang
2023-07-26 17:30 ` [PATCH 2/3] riscv: vdso.lds.S: merge .data section into .rodata section Jisheng Zhang
2023-07-28 12:57 ` Andrew Jones
2023-07-28 14:11 ` Jisheng Zhang [this message]
2023-07-26 17:30 ` [PATCH 3/3] riscv: vdso.lds.S: remove hardcoded 0x800 .text start addr Jisheng Zhang
2023-07-28 12:58 ` Andrew Jones
2023-09-05 14:46 ` [PATCH 0/3] riscv: vdso.lds.S: some improvement Emil Renner Berthing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMPMfMPoG/KnuWLN@xhacker \
--to=jszhang@kernel.org \
--cc=ajones@ventanamicro.com \
--cc=aou@eecs.berkeley.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).