Re: [PATCH v4 21/36] arm64/mm: Implement map_shadow_stack()

Mark Brown
2023-08-15T21:02:18Z

[-- Attachment #1.1: Type: text/plain, Size: 886 bytes --]

On Tue, Aug 15, 2023 at 08:42:52PM +0000, Edgecombe, Rick P wrote:
> On Mon, 2023-08-07 at 23:00 +0100, Mark Brown wrote:
> > +       if (flags & ~(SHADOW_STACK_SET_TOKEN |
> > SHADOW_STACK_SET_MARKER))
> > +               return -EINVAL;

> Thanks for adding SHADOW_STACK_SET_MARKER. I don't see where it is
> defined in these patches though. Might have been left out on accident?

I added it to the dependency patches I've got which pull bits out of the
x86 series prior to you having rebased it, the ABI bits are mixed in
with the x86 architecture changes which I didn't feel like dealing with
the rebasing for so I pulled out the ABI portions. I'll resolve this
properly when I rebase back onto the x86 series (ideally after the next
merge window it'll be in mainline!). For these that'll probably boil
down to adding defines to prctl.h for the generic prctl API.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]