From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DA19FEE49AF for ; Wed, 23 Aug 2023 03:17:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=y9v5oVyf5mF+8lwCr0zEZwm6Cuc2E553ETInVeS7Iwk=; b=bMu5cUg9e8BtV8 uLqeMhhyJejdtke1R55kSk/5wzAuufAdjglOb5HYSFaSyVr2CUu4zzX0upFQW0JCSQobRVmi+L63y USO59SwN3xIfS71Lxul6+/0I4S0IEn5jG8sqkCICikurEzhIgAMVrIGi7qO8dHZJuNyG2wTSCu99+ gAfPEo1T8cypQTzKFJanUTup3AdoN8kDH7kRVsBloxbee5DL3/A9fZTNdHw14z8l2BreyubVfW3C8 nF2nlTvrMIWypyyYtEV7GeZGV5BvomY1/jZd3GKWQ1ADMskbGM+FOYOMKoNAsVMsPGOLXsik9hyqU kHercXZym+bpV595AjpA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qYeN7-00H8MY-2t; Wed, 23 Aug 2023 03:17:29 +0000 Received: from out-46.mta0.migadu.com ([91.218.175.46]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qYeN5-00H8Lc-2N for linux-riscv@lists.infradead.org; Wed, 23 Aug 2023 03:17:29 +0000 Date: Wed, 23 Aug 2023 13:16:57 +1000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jookia.org; s=key1; t=1692760640; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zahP6Lk7k9gO6ZWwdWZ4JSMtgXLMnFQ0XU2AxSSHQqk=; b=g10hba/RCjfZrCJZ6kvJA5qG83PfMboSMVC5DMuz1BkYsaHcEDYRQapCyCo3w7aQ428a2B TQaxZ2edx7VaWhoF9KHaKWzAfcAPwe0tjp9RQLB78Ta5Z4uc4fgzYEcoIzSLmZF6GgBew1 +WnlAOaB9pEiwPCuDLbs8nHzTpj2y7kFxZX9DJFLwX1N77WqMqKPKME2H7ULtZrQHDqlaR 1R15js3rAHYtZUgrB8CeaiNfV6QKyKZz8KVLwRFzJwLXoopsHTDIZXqY7o6lgeyb9DIi2t ekTP/JoNwBT8UamdiFVRN+drkQLekCyjlUoc+d92oR6WlLPKEfIcr9EROYyhvQ== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: John Watts To: Geert Uytterhoeven Cc: linux-sunxi@lists.linux.dev, Wolfgang Grandegger , Marc Kleine-Budde , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-can@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v2 4/4] can: sun4i_can: Add support for the Allwinner D1 Message-ID: References: <20230721221552.1973203-2-contact@jookia.org> <20230721221552.1973203-6-contact@jookia.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230822_201727_978495_56A08C07 X-CRM114-Status: GOOD ( 19.41 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Tue, Aug 22, 2023 at 02:30:16PM +0200, Geert Uytterhoeven wrote: > Hi John, > > This makes this question pop up when configuring a kernel for any RISC-V > platform, not just for Allwinner RISC-V platforms. Oh dear. > In comparison, drivers/clk/sunxi-ng/Kconfig does have some > > depends on MACH_SUNI || RISCV || COMPILE_TEST > > but these are gated by ARCH_SUNXI at the top of the file. Ah, that is what I copied. > I'm not sure what's the best way to fix this: > - Replace RISCV by ARCH_SUNXI? > This would expose it on more ARM suni platforms, making the > MACH_SUN4I || MACH_SUN7I superfluous? > - Replace RISCV by RISCV && ARCH_SUNXI? I'm not sure what the best approach here is. Just having it require ARCH_SUNXI would make sense to me but I'm not too sure why where's so many different MACH here in the first place. > Thanks for your comments! > > > help > > Say Y here if you want to use CAN controller found on Allwinner > > - A10/A20 SoCs. > > + A10/A20/D1 SoCs. > > > > To compile this driver as a module, choose M here: the module will > > be called sun4i_can. > > Gr{oetje,eeting}s, > > Geert John. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv