Re: [PATCH v2 4/4] can: sun4i_can: Add support for the Allwinner D1

John Watts
2023-08-23T03:17:34Z

On Tue, Aug 22, 2023 at 02:30:16PM +0200, Geert Uytterhoeven wrote:
> Hi John,
>
> This makes this question pop up when configuring a kernel for any RISC-V
> platform, not just for Allwinner RISC-V platforms.

Oh dear.

> In comparison, drivers/clk/sunxi-ng/Kconfig does have some
>
> depends on MACH_SUN<foo>I || RISCV || COMPILE_TEST
>
> but these are gated by ARCH_SUNXI at the top of the file.

Ah, that is what I copied.

> I'm not sure what's the best way to fix this:
> - Replace RISCV by ARCH_SUNXI?
> This would expose it on more ARM sun<foo>i platforms, making the
> MACH_SUN4I || MACH_SUN7I superfluous?
> - Replace RISCV by RISCV && ARCH_SUNXI?

I'm not sure what the best approach here is. Just having it require ARCH_SUNXI
would make sense to me but I'm not too sure why where's so many different MACH
here in the first place.

> Thanks for your comments!
>
> > help
> > Say Y here if you want to use CAN controller found on Allwinner
> > - A10/A20 SoCs.
> > + A10/A20/D1 SoCs.
> >
> > To compile this driver as a module, choose M here: the module will
> > be called sun4i_can.
>
> Gr{oetje,eeting}s,
>
> Geert

John.