[PATCH] riscv: alternative: remove alternative boundary symbols in vdso

[PATCH] riscv: alternative: remove alternative boundary symbols in vdso

[Xiao Wang]

Instruction patching for vdso is based on elf header parsing to get the
beginning and ending of .alternative section, the __alt_start and __alt_end
symbols defined in vdso linker script are not used, so this patch removes
them.

Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
---
 arch/riscv/kernel/vdso/vdso.lds.S | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/riscv/kernel/vdso/vdso.lds.S b/arch/riscv/kernel/vdso/vdso.lds.S
index 82ce64900f3d..d43fd7c7dd11 100644
--- a/arch/riscv/kernel/vdso/vdso.lds.S
+++ b/arch/riscv/kernel/vdso/vdso.lds.S
@@ -42,9 +42,7 @@ SECTIONS
 
 	. = ALIGN(4);
 	.alternative : {
-		__alt_start = .;
 		*(.alternative)
-		__alt_end = .;
 	}
 
 	.data		: {
-- 
2.25.1


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH] riscv: alternative: remove alternative boundary symbols in vdso

[Jisheng Zhang]

On Sat, Sep 02, 2023 at 10:25:10AM +0800, Xiao Wang wrote:
> Instruction patching for vdso is based on elf header parsing to get the
> beginning and ending of .alternative section, the __alt_start and __alt_end
> symbols defined in vdso linker script are not used, so this patch removes
> them.

The same patch has been in mailist since July:

https://lore.kernel.org/linux-riscv/20230726173024.3684-2-jszhang@kernel.org/

Thanks
> 
> Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
> ---
>  arch/riscv/kernel/vdso/vdso.lds.S | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/riscv/kernel/vdso/vdso.lds.S b/arch/riscv/kernel/vdso/vdso.lds.S
> index 82ce64900f3d..d43fd7c7dd11 100644
> --- a/arch/riscv/kernel/vdso/vdso.lds.S
> +++ b/arch/riscv/kernel/vdso/vdso.lds.S
> @@ -42,9 +42,7 @@ SECTIONS
>  
>  	. = ALIGN(4);
>  	.alternative : {
> -		__alt_start = .;
>  		*(.alternative)
> -		__alt_end = .;
>  	}
>  
>  	.data		: {
> -- 
> 2.25.1
> 

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

RE: [PATCH] riscv: alternative: remove alternative boundary symbols in vdso

[Wang, Xiao W]

> -----Original Message-----
> From: Jisheng Zhang <jszhang@kernel.org>
> Sent: Monday, September 4, 2023 10:35 PM
> To: Wang, Xiao W <xiao.w.wang@intel.com>
> Cc: paul.walmsley@sifive.com; palmer@dabbelt.com;
> aou@eecs.berkeley.edu; linux-riscv@lists.infradead.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH] riscv: alternative: remove alternative boundary symbols
> in vdso
> 
> On Sat, Sep 02, 2023 at 10:25:10AM +0800, Xiao Wang wrote:
> > Instruction patching for vdso is based on elf header parsing to get the
> > beginning and ending of .alternative section, the __alt_start and __alt_end
> > symbols defined in vdso linker script are not used, so this patch removes
> > them.
> 
> The same patch has been in mailist since July:
> 
> https://lore.kernel.org/linux-riscv/20230726173024.3684-2-
> jszhang@kernel.org/
> 
> Thanks

OK, then please go ahead with that patch review and ignore this one.

BRs,
Xiao

> >
> > Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
> > ---
> >  arch/riscv/kernel/vdso/vdso.lds.S | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/arch/riscv/kernel/vdso/vdso.lds.S
> b/arch/riscv/kernel/vdso/vdso.lds.S
> > index 82ce64900f3d..d43fd7c7dd11 100644
> > --- a/arch/riscv/kernel/vdso/vdso.lds.S
> > +++ b/arch/riscv/kernel/vdso/vdso.lds.S
> > @@ -42,9 +42,7 @@ SECTIONS
> >
> >  	. = ALIGN(4);
> >  	.alternative : {
> > -		__alt_start = .;
> >  		*(.alternative)
> > -		__alt_end = .;
> >  	}
> >
> >  	.data		: {
> > --
> > 2.25.1
> >
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv