From: Charlie Jenkins <charlie@rivosinc.com>
To: Conor Dooley <conor@kernel.org>
Cc: Albert Ou <aou@eecs.berkeley.edu>,
linux-kernel@vger.kernel.org, Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH v2 2/5] riscv: Add checksum library
Date: Thu, 7 Sep 2023 10:47:13 -0700 [thread overview]
Message-ID: <ZPoMoVnUjNzr+OXI@ghost> (raw)
In-Reply-To: <20230907-9d5d2e7ef2a20edd75514470@fedora>
On Thu, Sep 07, 2023 at 10:52:35AM +0100, Conor Dooley wrote:
> On Tue, Sep 05, 2023 at 09:46:51PM -0700, Charlie Jenkins wrote:
>
> > +#ifdef CONFIG_RISCV_ISA_ZBB
> > + if (IS_ENABLED(CONFIG_RISCV_ALTERNATIVE)) {
> > + /*
> > + * Zbb is likely available when the kernel is compiled with Zbb
> > + * support, so nop when Zbb is available and jump when Zbb is
> > + * not available.
> > + */
> > + asm_volatile_goto(ALTERNATIVE("j %l[no_zbb]", "nop", 0,
> > + RISCV_ISA_EXT_ZBB, 1)
> > + :
> > + :
> > + :
> > + : no_zbb);
> > + } else {
> > + if (!__riscv_isa_extension_available(NULL, RISCV_ISA_EXT_ZBB))
> > + goto no_zbb;
> > + }
>
> Again, do these constructs have an appreciable benefit over doing
> if (!riscv_has_extension_likely(<ZBB>)
> goto no_zbb;
>
> ?
>
> That encaspulates the fallback to a non-alternative mechanism for you,
> in case you had not noticed.
I got caught up in the other patch where I did not want to fall back, so
then in this patch I forgot I could use riscv_has_extension_likely. I will
make the change.
- Charlie
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-09-07 17:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-06 4:46 [PATCH v2 0/5] riscv: Add fine-tuned checksum functions Charlie Jenkins
2023-09-06 4:46 ` [PATCH v2 1/5] riscv: Checksum header Charlie Jenkins
2023-09-07 9:40 ` Conor Dooley
2023-09-07 17:44 ` Charlie Jenkins
2023-09-10 21:20 ` David Laight
2023-09-11 18:16 ` Charlie Jenkins
2023-09-06 4:46 ` [PATCH v2 2/5] riscv: Add checksum library Charlie Jenkins
2023-09-07 9:52 ` Conor Dooley
2023-09-07 17:47 ` Charlie Jenkins [this message]
2023-09-06 4:46 ` [PATCH v2 3/5] riscv: Vector checksum header Charlie Jenkins
2023-09-07 9:47 ` Conor Dooley
2023-09-07 17:43 ` Charlie Jenkins
2023-09-07 9:58 ` Conor Dooley
2023-09-07 17:41 ` Charlie Jenkins
2023-09-06 4:46 ` [PATCH v2 4/5] riscv: Vector checksum library Charlie Jenkins
2023-09-06 4:46 ` [PATCH v2 5/5] riscv: Test checksum functions Charlie Jenkins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZPoMoVnUjNzr+OXI@ghost \
--to=charlie@rivosinc.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).