From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8906BCE79A8 for ; Wed, 20 Sep 2023 03:18:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RJ20hUU2gIOUvuypZ+1XDvY78z0KsMXGvQYZ6u2hQjs=; b=SXfhyy4gyogN4y B0TEWltoXCiLOCBsxfI2jOyIs0RgQoU++toeURAm8pEYaWjz5PPvZFaMHPeZj1MNow6z/gk+fmPme tumX/ZRhhawcOIBy6oQsmOVDhPgqj6aAh99IkV3YxtG2civVXNXKTBuSUiT6LkhdYkXrhxD9N1/He i5Kduf3ZDFrGj1Xz8BylsaMaV0OAI/ci8DWR1oskIga8t3KXdt3DOIYcgG7lJIT+ZIREygQ0lrIy0 Fex6V7CORFq3PFC3GIOO6F29WPNWxBNLz1PGQZ88o7S7JXkH19yde4rj7LQmFdb8jNm7Byl2grJVp 8ZC1HWRmIG00ySkcQkhA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qinjE-001iGj-1U; Wed, 20 Sep 2023 03:18:16 +0000 Received: from 60-248-80-70.hinet-ip.hinet.net ([60.248.80.70] helo=Atcsqr.andestech.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qinjB-001iFx-0A for linux-riscv@lists.infradead.org; Wed, 20 Sep 2023 03:18:15 +0000 Received: from mail.andestech.com (ATCPCS16.andestech.com [10.0.1.222]) by Atcsqr.andestech.com with ESMTP id 38K3HiGf052118; Wed, 20 Sep 2023 11:17:44 +0800 (+08) (envelope-from peterlin@andestech.com) Received: from APC323 (10.0.12.98) by ATCPCS16.andestech.com (10.0.1.222) with Microsoft SMTP Server id 14.3.498.0; Wed, 20 Sep 2023 11:17:39 +0800 Date: Wed, 20 Sep 2023 11:17:36 +0800 From: Yu-Chien Peter Lin To: Conor Dooley CC: , , , , , , , , Subject: Re: [PATCH v2 1/3] riscv: Improve PTDUMP to show RSW with non-zero value Message-ID: References: <20230914014027.273002-1-peterlin@andestech.com> <20230918-cassette-exclusion-b2ce53745a5c@wendy> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230918-cassette-exclusion-b2ce53745a5c@wendy> User-Agent: Mutt/2.2.10 (2023-03-25) X-Originating-IP: [10.0.12.98] X-DNSRBL: X-MAIL: Atcsqr.andestech.com 38K3HiGf052118 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230919_201813_551451_80BF9FCA X-CRM114-Status: GOOD ( 10.34 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Mon, Sep 18, 2023 at 01:53:13PM +0100, Conor Dooley wrote: > On Thu, Sep 14, 2023 at 09:40:25AM +0800, Yu Chien Peter Lin wrote: > > > + val = st->current_prot & pte_bits[i].mask; > > + if (val) { > > + if (pte_bits[i].mask == _PAGE_SOFT) > > + sprintf(s, pte_bits[i].set, val >> 8); > > + else > > + sprintf(s, "%s", pte_bits[i].set); > > + } else > > + sprintf(s, "%s", pte_bits[i].clear); > > + > > just a nit, but checkpatch in the automation is whinging that you have > forgotten to add {} around both branches if this if statement. Hi Conor, Will fix the warning. Thanks, Peter Lin _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv