From: Charlie Jenkins <charlie@rivosinc.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "Wang, Xiao W" <xiao.w.wang@intel.com>,
Linux-Arch <linux-arch@vger.kernel.org>,
Albert Ou <aou@eecs.berkeley.edu>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Conor Dooley <conor@kernel.org>,
David Laight <David.Laight@aculab.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>
Subject: Re: [PATCH v7 2/4] riscv: Checksum header
Date: Wed, 25 Oct 2023 14:20:23 -0700 [thread overview]
Message-ID: <ZTmGl36A3X1UtnNu@ghost> (raw)
In-Reply-To: <571211a1-470a-43da-a603-fd12a640b7a8@app.fastmail.com>
On Wed, Oct 25, 2023 at 11:18:40PM +0200, Arnd Bergmann wrote:
> On Wed, Oct 25, 2023, at 23:11, Charlie Jenkins wrote:
> >
> > Thank you for pointing that out, I had not realized that macro existed.
> > Since riscv keeps NET_IP_ALIGN at 0 it should be expected that
> > ip_fast_csum is only called with 32-bit aligned addresses. I will update
> > the comment and refer to that macro. riscv supports misaligned accesses
> > but there are no guarantees of speed.
>
> Just to clarify for your comment: riscv gets the default value of '2',
> which is the one that makes the header aligned.
>
> Arnd
Oops, typo. I meant to write 2.
- Charlie
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-10-25 21:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-19 18:44 [PATCH v7 0/4] riscv: Add fine-tuned checksum functions Charlie Jenkins
2023-09-19 18:44 ` [PATCH v7 1/4] asm-generic: Improve csum_fold Charlie Jenkins
2023-09-19 18:44 ` [PATCH v7 2/4] riscv: Checksum header Charlie Jenkins
2023-10-12 14:54 ` Conor Dooley
2023-10-25 6:50 ` Wang, Xiao W
2023-10-25 20:37 ` Charlie Jenkins
2023-10-25 20:52 ` Arnd Bergmann
2023-10-25 21:11 ` Charlie Jenkins
2023-10-25 21:18 ` Arnd Bergmann
2023-10-25 21:20 ` Charlie Jenkins [this message]
2023-09-19 18:44 ` [PATCH v7 3/4] riscv: Add checksum library Charlie Jenkins
2023-10-12 14:51 ` Conor Dooley
2023-10-25 7:29 ` Wang, Xiao W
2023-09-19 18:44 ` [PATCH v7 4/4] riscv: Test checksum functions Charlie Jenkins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTmGl36A3X1UtnNu@ghost \
--to=charlie@rivosinc.com \
--cc=David.Laight@aculab.com \
--cc=aou@eecs.berkeley.edu \
--cc=arnd@arndb.de \
--cc=conor@kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=xiao.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox