public inbox for linux-riscv@lists.infradead.org
 help / color / mirror / Atom feed
From: Jisheng Zhang <jszhang@kernel.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Conor Dooley <conor.dooley@microchip.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	linux-riscv@lists.infradead.org, tobias.schaffner@siemens.com,
	Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH RT v2 0/3] riscv: add PREEMPT_RT support
Date: Fri, 3 Nov 2023 01:03:47 +0800	[thread overview]
Message-ID: <ZUPWc7sY47l34lV+@xhacker> (raw)
In-Reply-To: <20231102155423.SyuAibSe@linutronix.de>

On Thu, Nov 02, 2023 at 04:54:23PM +0100, Sebastian Andrzej Siewior wrote:
> On 2023-11-02 12:31:15 [+0000], Conor Dooley wrote:
> > [    1.130384] BUG: sleeping function called from invalid context at kernel/locking/spinlock_rt.c:48
> > [    1.130418]
> > [    1.130414] in_atomic(): 1, irqs_disabled(): 1, non_block: 0, pid: 0, name: swapper/1
> > [    1.130971] [<ffffffff80267d78>] __alloc_pages+0xac/0x1be
> > [    1.130978]   alloc_workqueue+0x96/0x6de
> > [    1.131005] [<ffffffff8000412a>] check_unaligned_access+0x34/0x336
> > [    1.131010]   kmem_cache_init_late+0x1c/0x36
> > [    1.131038] [<ffffffff80004660>] check_unaligned_access_nonboot_cpu+0x12/0x1a
> > [    1.131046]   start_kernel+0x204/0x7e6
> > [    1.131082] irq event stamp: 822
> > [    1.131071] [<ffffffff800fcba0>] __flush_smp_call_function_queue+0x1de/0x790
> > [    1.131093] hardirqs last  enabled at (821): [<ffffffff80bd75b0>] default_idle_call+0xfa/0x152
> > [    1.131111] [<ffffffff800fd3a0>] generic_smp_call_function_single_interrupt+0xe/0x1a
> > [    1.131124] hardirqs last disabled at (822): [<ffffffff80bd52a0>] do_irq+0x16/0xa6
> 
> Without the patch check_unaligned_access_boot_cpu() ->
> check_unaligned_access() is okay. The SMP/IPI variant (the patch imho)
> is bad. There must be no memory allocation from IRQ-off region - the
> smp-function call in this case.
> 
> Would it be okay if I delay it until this solved? If you have something,
> then I could apply the two patches plus the fixup for this.
> 

Hi Sebastian,

you can delay merge the series. I will check it

Thanks

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2023-11-02 17:16 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-31 14:35 [PATCH RT v2 0/3] riscv: add PREEMPT_RT support Jisheng Zhang
2023-10-31 14:35 ` [PATCH RT v2 1/2] riscv: add PREEMPT_AUTO support Jisheng Zhang
2023-10-31 14:35 ` [PATCH RT v2 2/2] riscv: allow to enable RT Jisheng Zhang
2023-10-31 15:32 ` [PATCH RT v2 0/3] riscv: add PREEMPT_RT support Sebastian Andrzej Siewior
2023-10-31 15:49   ` Jisheng Zhang
2023-10-31 16:44     ` Sebastian Andrzej Siewior
2023-11-01 11:41       ` Jisheng Zhang
2023-11-02 12:31         ` Conor Dooley
2023-11-02 15:54           ` Sebastian Andrzej Siewior
2023-11-02 17:03             ` Jisheng Zhang [this message]
2023-11-02 21:37             ` Palmer Dabbelt
2023-11-03  8:17               ` Sebastian Andrzej Siewior
2023-11-03  8:14             ` Conor Dooley
2023-11-03  8:24               ` Sebastian Andrzej Siewior
2023-11-03 17:19                 ` Evan Green
2023-11-03 17:39                   ` Sebastian Andrzej Siewior
2023-11-03 18:22                     ` Evan Green
2023-11-06  8:53                       ` Sebastian Andrzej Siewior
2023-11-06 16:25                         ` Evan Green
2023-11-06 21:58 ` Palmer Dabbelt
2023-11-10 15:37   ` Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZUPWc7sY47l34lV+@xhacker \
    --to=jszhang@kernel.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=arnd@arndb.de \
    --cc=bigeasy@linutronix.de \
    --cc=conor.dooley@microchip.com \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=tglx@linutronix.de \
    --cc=tobias.schaffner@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox