From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5D3EAC4332F for ; Mon, 6 Nov 2023 15:02:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Lncuh9essi4Lj27BzM9Dsi8nE1CXEqz9mEygJEWozPI=; b=defnUGr41cpImr lLS3dY4B9phOoWsDp45Odn/+9pL+E685LO4rH8nS7Amw8Yw1AJCoP2GimE3XBwCslKIroRC0kq7I3 xR5wFWr5DyfYgTaiQ9PCjuSsU/HNgJhYukhfUZ0TC5qgQ0hx3tqnkHwfSXirBtA9rjD3DWK7TbTxB 2qsNtzMkore9NuOZCuUVkRp7vLRZbYuSaoEytmKh5WGsuv7dxc0DfLIQn2sjWdEvbE0UCK7RalJy1 LM1EktNDp6CLssa37kNQhN2ZV68fi42beuPLJNZ90iifYL9SZzqXjFyfnQW8dPRj4Dw+ATP3XNbyr HzFRJoSvLq6e2crCL4sA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r0171-00GwB6-1H; Mon, 06 Nov 2023 15:01:59 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r016y-00Gw9F-1n for linux-riscv@lists.infradead.org; Mon, 06 Nov 2023 15:01:58 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 563FECE098F; Mon, 6 Nov 2023 15:01:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9EE65C433C7; Mon, 6 Nov 2023 15:01:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699282913; bh=R/cSiyOAFRrqVhth3W2n5h61tFeVSdShjJRDQj6czH0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZUTy7kEFxYsF/koXOeL9ejldwPeR/VMnlbzSAsKZczqy5XRzb+OfUaZG3VAlG2kQS thRBrISP/mcyuHif2TfZM7A/Yw106zfROyEIZTGQN8Om4RW1Aa8CDTVpzB+bckC+Vp yXa7s5lX1p0u2J3AcCTx/nOeNqf0KSkE9Nrm3hkO6YDmcg4gWoQtmoTIZN+LzXMnp1 YaBoFQohLbxhKyIM+1VaLfnPLwcvsm/7pZRnBKzz0+XsEXQf7UVHPv1J+obnd8Mi8V gN7hFzEdjVHwBRekbFUi0iRrUdb5bpiYeNlfb7kpvQIQ4bCormrcd9/Er50Vh/x+zj W5RSB+DvZf4Cg== Date: Mon, 6 Nov 2023 22:49:33 +0800 From: Jisheng Zhang To: Thierry Reding , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Guo Ren , Fu Wei Cc: linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v3 0/2] pwm: add driver for T-THEAD TH1520 SoC Message-ID: References: <20231005130519.3864-1-jszhang@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231005130519.3864-1-jszhang@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231106_070156_800067_B358B059 X-CRM114-Status: GOOD ( 19.42 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Thu, Oct 05, 2023 at 09:05:17PM +0800, Jisheng Zhang wrote: > T-HEAD SoCs such as the TH1520 contain a PWM controller used to > control the LCD backlight, fan and so on. Add the PWM driver support > for it. > > Since the clk part isn't mainlined, so SoC dts(i) changes are not > included in this series. However, it can be tested by using fixed-clock. > > since v2: > - collect Reviewed-by tag > - add CTRL_ prefix for THEAD_PWM_CTRL register bit macros > - use pm_runtime_resume_and_get() instead of pm_runtime_get_sync() and > check its return value. > - remove unnecessary casts > - call pm_runtime_put_sync() when pwm channel is disabled > - use devm_pm_runtime_enable() and then drop .remove() > - properly consider if pwm is programmed by bootloader or other > pre-linux env. > - simplify thead_pwm_runtime_resume() code as Uwe suggested > - bool ever_started -> u8 channel_ever_started since we have 6 channels > - use 3 for #pwm-cells > > since v1: > - update commit msg and yaml filename to address Conor's comment > - use devm_clk_get_enabled() and devm_pwmchip_add() > - implement .get_state() > - properly handle overflow > - introduce thead_pwm_from_chip() inline function > - document Limitations > - address pm_runtime_get/put pingpong comment > > > Jisheng Zhang (2): > dt-bindings: pwm: Add T-HEAD PWM controller > pwm: add T-HEAD PWM driver Hi Thierry, Uwe, Kind ping, is there any chance for this series to be merged for v6.7? Thanks > > .../bindings/pwm/thead,th1520-pwm.yaml | 44 +++ > drivers/pwm/Kconfig | 11 + > drivers/pwm/Makefile | 1 + > drivers/pwm/pwm-thead.c | 270 ++++++++++++++++++ > 4 files changed, 326 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pwm/thead,th1520-pwm.yaml > create mode 100644 drivers/pwm/pwm-thead.c > > -- > 2.40.1 > _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv