From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7A8A0C4167B for ; Mon, 4 Dec 2023 08:35:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=P/hkpzxSkqMtc/j8X574/1bR/tVId1I8roB8NbTUVN8=; b=JHaWtfLE237DTa nRg+R0K6Qshud6BzG2MSqUh8mPTIcn/dG006bTT6cKbatYtj/34hRG1o+Tq/FIhB5t43AWIgK1iZU O3geEcXJSPeDOhGFOz6QwnJqZxMksAZU+Mp1nGd1HKzVY4lIjR2rbOY+aTA6U0c5LBvYErdDuza4c ly1u+vM6nqI22R6PSIkU6w0gF7PQt8GTiUOnFz1xs0hgjMP2705euUpg5KVoXOzEJryyb+1tFlFWq OHE/Fr/ZQmpFqmaSc2XoUESAWgxwvF0GTzUQnpFHyFfHqickY3LZDXC61CTdUf9zCVzUDCVmSoOE2 l6TjqyuHaUnS6jAzSKnQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rA4Pm-003HC0-2p; Mon, 04 Dec 2023 08:34:54 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rA4Pj-003HAq-2r for linux-riscv@lists.infradead.org; Mon, 04 Dec 2023 08:34:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701678887; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9tcnzIexPrb0OUsvkaLGTMaO9LwJfJejgNnOdDmMeTA=; b=REHMVkef/g2hf8bXXO0gjK5B+omZLWmxW04I+84vNS7o7r+H/fzhszcvPFGAO1RoWCOMK8 6e1QkT1ddqClHBa3J6Q2aMScApX4gcrfoASsN6pUkyaMXy62x6VHPnWg7ISGSWg2E+zQji WFfEmKvcXFn7H3xjCF6HDYYP/sp0ROg= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-542-TP6E8WNAO9SqzRiAn5erpQ-1; Mon, 04 Dec 2023 03:34:40 -0500 X-MC-Unique: TP6E8WNAO9SqzRiAn5erpQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0B4DD38476C0; Mon, 4 Dec 2023 08:34:40 +0000 (UTC) Received: from localhost (unknown [10.72.113.121]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 09B38C1596F; Mon, 4 Dec 2023 08:34:38 +0000 (UTC) Date: Mon, 4 Dec 2023 16:34:36 +0800 From: Baoquan He To: linux-kernel@vger.kernel.org Cc: linux-riscv@lists.infradead.org, kexec@lists.infradead.org, akpm@linux-foundation.org, mick@ics.forth.gr, changbin.du@intel.com, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu Subject: Re: [PATCH] riscv, kexec: fix the ifdeffery for AFLAGS_kexec_relocate.o Message-ID: References: <20231201062538.27240-1-bhe@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231201062538.27240-1-bhe@redhat.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231204_003452_201055_A319D6BC X-CRM114-Status: GOOD ( 17.51 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org CC Andrew. On 12/01/23 at 02:25pm, Baoquan He wrote: > This was introduced in commit fba8a8674f68 ("RISC-V: Add kexec > support"). > > It should work on CONFIG_KEXEC_CORE, but not CONFIG_KEXEC only, since > we could set CONFIG_KEXEC_FILE=y and CONFIG_KEXEC=N, or only set > CONFIG_CRASH_DUMP=y and disable both CONFIG_KEXEC and CONFIG_KEXEC_FILE. > In these cases, the AFLAGS won't take effect with the current ifdeffery > for AFLAGS_kexec_relocate.o. > > So fix it now. > > Signed-off-by: Baoquan He > --- > arch/riscv/kernel/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Hi RISC-V people, I didn't test this, while believe this need be fixed. Please help check if this is necessary. Thanks Baoquan > > diff --git a/arch/riscv/kernel/Makefile b/arch/riscv/kernel/Makefile > index fee22a3d1b53..82940b6a79a2 100644 > --- a/arch/riscv/kernel/Makefile > +++ b/arch/riscv/kernel/Makefile > @@ -11,7 +11,7 @@ endif > CFLAGS_syscall_table.o += $(call cc-option,-Wno-override-init,) > CFLAGS_compat_syscall_table.o += $(call cc-option,-Wno-override-init,) > > -ifdef CONFIG_KEXEC > +ifdef CONFIG_KEXEC_CORE > AFLAGS_kexec_relocate.o := -mcmodel=medany $(call cc-option,-mno-relax) > endif > > -- > 2.41.0 > _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv