From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8B929C41535 for ; Fri, 22 Dec 2023 04:24:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YRLmNnvwHzaqjxrvgfMZsWqeVN+rxDX6VGIXOIJaDqE=; b=yjJIdxK+6EWnLz PLIYPEW4N/YARrhhfRHtjWMCRF/kVolqYRC8g0kDGRG78XtaviU5X4FPkaar7yVJ7TFd/B+85xUii A4XE6Wi3PhgmbA/Ym7NLJgIC2nQ0goRQZsrIK5upKLlaujhg/fAFfCFSrdwOf7V/zhqb0P7NNAgTr VXvnAT2E41YxBkYLwRgFQg6inebqd4ImfXTnl0GG7eIAwl9PYcyenZTfeOliOYZXX0ZGuc+znlxTr Y02s9k0S+Vuc2yg7QLs3yWVQRrrYqS/ov9QSjABeZK/yq/HdHzr6MS8+Gd1UV2WNG3lvGmAT6SIYf EEPYx81o+Q9g1A4kXNog==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rGX4o-004pEa-03; Fri, 22 Dec 2023 04:23:58 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rGX4l-004pDz-0e for linux-riscv@lists.infradead.org; Fri, 22 Dec 2023 04:23:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1703219034; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Cnx8DhX5IecGWHmZB5Qoq5HltIXeldgLEw/ZWTgki2w=; b=Rd3RhuE0lhvRJJCj44lv0wXH9PXcDIFT95QvS67sZNtFVKg3kn8Cb6zE4POOLNwXqm7kBp QL5jknOX37vBY5m8enowLCZTctDa9vtXgytguauo+9nmToC8f7s1wcBoGIU5QcUngszqXG F+vzW3RMs+1eE5lPP91NANbfbyt5Tds= Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-347-guuOXwVwOUOJr733LgzbQw-1; Thu, 21 Dec 2023 23:23:52 -0500 X-MC-Unique: guuOXwVwOUOJr733LgzbQw-1 Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-28bf98431d3so917339a91.3 for ; Thu, 21 Dec 2023 20:23:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703219031; x=1703823831; h=content-transfer-encoding:content-disposition:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Cnx8DhX5IecGWHmZB5Qoq5HltIXeldgLEw/ZWTgki2w=; b=hSv2bHlSUsN3/v3fUxG0cdY7EmKIjH1mwFaXY+Dk/jPxrg3b25KvOqBQr/K2leGsSx tipTJgQGFscqi0j3aZ93XbcBi/6FdyZlAQeEk/9kFnYYRrZzrejuu3ro/S0Tpxc0CBuA Ab2G4bk5tqXsGQCl59PcT/gi6mOMwTuQaOO8yFZNBhHip2VctKAEkFjjrhIrW5BFp6R4 R4mCZ7J4Gm+VI4IlxkZlsLPozRQYwOXhokO5EkwPTP/IPxO51Za9eLWATao++bH75D1p PkUyNBhwinlPozig9B0fZQAVhikDzoVklOn/S4Tv+61wf1xIifJcokMZrzzOeHryoglN LdgQ== X-Gm-Message-State: AOJu0Yww6DsiZ28RO5LXmMkT0LfOkh6TSnhnJACNT9HPEtNnmomo1sWd nWxdIPvUBfD4avH6JfFPtUUxISNEj8sgZ5kHMqTDB+gLBsn2Xi18yXooD9KQIPXswQOuIjjA4Mh 8ANGKRQ/azD9V6oSxZ4YqczJhN4yRSlxtM6ZC X-Received: by 2002:a17:903:41c9:b0:1d0:6ffd:9e06 with SMTP id u9-20020a17090341c900b001d06ffd9e06mr617803ple.88.1703219031132; Thu, 21 Dec 2023 20:23:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IEGPjTlXEJTe6N+AgEZwTc+WV8ng/X9Qz5/P34IiXFuimkgh7AxgOFC1oVCPdh5w/dkLxedfA== X-Received: by 2002:a17:903:41c9:b0:1d0:6ffd:9e06 with SMTP id u9-20020a17090341c900b001d06ffd9e06mr617788ple.88.1703219030811; Thu, 21 Dec 2023 20:23:50 -0800 (PST) Received: from localhost.localdomain ([2804:1b3:a802:7496:88a7:1b1a:a837:bebf]) by smtp.gmail.com with ESMTPSA id y2-20020a17090264c200b001d1d5fb96f9sm2497743pli.27.2023.12.21.20.23.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Dec 2023 20:23:50 -0800 (PST) From: Leonardo Bras To: Charlie Jenkins Cc: Leonardo Bras , guoren@kernel.org, linux-kernel@vger.kernel.org, paul.walmsley@sifive.com, palmer@dabbelt.com, alexghiti@rivosinc.com, xiao.w.wang@intel.com, david@redhat.com, panqinglin2020@iscas.ac.cn, rick.p.edgecombe@intel.com, willy@infradead.org, bjorn@rivosinc.com, conor.dooley@microchip.com, cleger@rivosinc.com, linux-riscv@lists.infradead.org, Guo Ren , stable@vger.kernel.org Subject: Re: [PATCH V2 2/4] riscv: mm: Fixup compat arch_get_mmap_end Date: Fri, 22 Dec 2023 01:23:29 -0300 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: <20231221154702.2267684-1-guoren@kernel.org> <20231221154702.2267684-3-guoren@kernel.org> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231221_202355_306933_66E885CB X-CRM114-Status: GOOD ( 39.85 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Thu, Dec 21, 2023 at 08:04:43PM -0800, Charlie Jenkins wrote: > On Fri, Dec 22, 2023 at 12:34:56AM -0300, Leonardo Bras wrote: > > On Thu, Dec 21, 2023 at 10:46:59AM -0500, guoren@kernel.org wrote: > > > From: Guo Ren > > > > > > When the task is in COMPAT mode, the arch_get_mmap_end should be 2GB, > > > not TASK_SIZE_64. The TASK_SIZE has contained is_compat_mode() > > > detection, so change the definition of STACK_TOP_MAX to TASK_SIZE > > > directly. > > > > ok > > > > > > > > Cc: stable@vger.kernel.org > > > Fixes: add2cc6b6515 ("RISC-V: mm: Restrict address space for sv39,sv48,sv57") > > > Signed-off-by: Guo Ren > > > Signed-off-by: Guo Ren > > > --- > > > arch/riscv/include/asm/processor.h | 6 ++---- > > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > > > diff --git a/arch/riscv/include/asm/processor.h b/arch/riscv/include/asm/processor.h > > > index f19f861cda54..1f538fc4448d 100644 > > > --- a/arch/riscv/include/asm/processor.h > > > +++ b/arch/riscv/include/asm/processor.h > > > @@ -16,15 +16,13 @@ > > > > > > #ifdef CONFIG_64BIT > > > #define DEFAULT_MAP_WINDOW (UL(1) << (MMAP_VA_BITS - 1)) > > > -#define STACK_TOP_MAX TASK_SIZE_64 > > > +#define STACK_TOP_MAX TASK_SIZE > > > > It means STACK_TOP_MAX will be in 64BIT: > > - TASK_SIZE_32 if compat_mode=y > > - TASK_SIZE_64 if compat_mode=n > > > > Makes sense for me. > > > > > > > > #define arch_get_mmap_end(addr, len, flags) \ > > > ({ \ > > > unsigned long mmap_end; \ > > > typeof(addr) _addr = (addr); \ > > > - if ((_addr) == 0 || (IS_ENABLED(CONFIG_COMPAT) && is_compat_task())) \ > > > - mmap_end = STACK_TOP_MAX; \ > > > - else if ((_addr) >= VA_USER_SV57) \ > > > + if ((_addr) == 0 || (_addr) >= VA_USER_SV57) \ > > > mmap_end = STACK_TOP_MAX; \ > > > else if ((((_addr) >= VA_USER_SV48)) && (VA_BITS >= VA_BITS_SV48)) \ > > > mmap_end = VA_USER_SV48; \ > > > > > > I don't think I got this change, or how it's connected to the commit msg. > > > > Before: > > - addr == 0, or addr > 2^57, or compat: mmap_end = STACK_TOP_MAX > > - 2^48 < addr < 2^57: mmap_end = 2^48 > > - 0 < addr < 2^48 : mmap_end = 2^39 > > > > Now: > > - addr == 0, or addr > 2^57: mmap_end = STACK_TOP_MAX > > - 2^48 < addr < 2^57: mmap_end = 2^48 > > - 0 < addr < 2^48 : mmap_end = 2^39 > > > > IIUC compat mode addr will be < 2^32, so will always have mmap_end = 2^39 > > if addr != 0. Is that desireable? > > (if not, above change is unneeded) > > I agree, this change does not make sense for compat mode. Compat mode > should never return an address that is greater than 2^32, but this > change allows that. > > > > > Also, unrelated to the change: > > - 2^48 < addr < 2^57: mmap_end = 2^48 > > Is the above correct? > > It looks like it should be 2^57 instead, and a new if clause for > > 2^32 < addr < 2^48 should have mmap_end = 2^48. > > That is not the case. I documented this behavior and reasoning in > Documentation/arch/riscv/vm-layout.rst in the "Userspace VAs" section. > > I can reiterate here though. The hint address to mmap (defined here as > "addr") is the maximum userspace address that mmap should provide. What > you are describing is a minimum. The purpose of this change was to allow > applications that are not compatible with a larger virtual address (such > as applications like Java that use the upper bits of the VA to store > data) to have a consistent way of specifying how many bits they would > like to be left free in the VA. This requires to take the next lowest > address space to guaruntee that all of the most-significant bits left > clear in hint address do not end up populated in the virtual address > returned by mmap. > > - Charlie Hello Charlie, thank you for helping me understand! Ok, that does make sense now! The addr value hints "don't allocate > addr" and thus: - 0 < addr < 2^48 : mmap_end = 2^39 - 2^48 < addr < 2^57: mmap_end = 2^48 Ok, but then - addr > 2^57: mmap_end = 2^57 right? I mean, probably STACK_TOP_MAX in non-compat mode means 2^57 already, but having it explicitly like: else if ((_addr) >= VA_USER_SV57) \ mmap_end = VA_USER_SV57; \ would not be better for a future full 64-bit addressing? (since it's already on a different if clause) I could add comment on top of the macro with a short version on your addr hint description above. Would that be ok? Thanks! Leo > > > > > Do I get it wrong? > > > > (I will send an RFC 'fixing' the code the way I am whinking it should look > > like) > > > > Thanks, > > Leo > > > > > > > > > > > > > -- > > > 2.40.1 > > > > > > _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv