From: Petr Mladek <pmladek@suse.com>
To: Ryo Takakura <ryotkkr98@gmail.com>
Cc: alex@ghiti.fr, aou@eecs.berkeley.edu, bigeasy@linutronix.de,
conor.dooley@microchip.com, gregkh@linuxfoundation.org,
jirislaby@kernel.org, john.ogness@linutronix.de,
palmer@dabbelt.com, paul.walmsley@sifive.com,
samuel.holland@sifive.com, u.kleine-koenig@baylibre.com,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-serial@vger.kernel.org
Subject: Re: [PATCH v2] serial: sifive: Switch to nbcon console
Date: Thu, 10 Apr 2025 14:29:33 +0200 [thread overview]
Message-ID: <Z_e5rWcJKUh7eozw@pathway.suse.cz> (raw)
In-Reply-To: <20250405145915.493173-1-ryotkkr98@gmail.com>
On Sat 2025-04-05 23:59:15, Ryo Takakura wrote:
> Add the necessary callbacks(write_atomic, write_thread, device_lock
> and device_unlock) and CON_NBCON flag to switch the sifive console
> driver to perform as nbcon console.
>
> Both ->write_atomic() and ->write_thread() will check for console
> ownership whenever they are accessing registers.
>
> The ->device_lock()/unlock() will provide the additional serilization
> necessary for ->write_thread() which is called from dedicated printing
> thread.
>
> Signed-off-by: Ryo Takakura <ryotkkr98@gmail.com>
> Reviewed-by: John Ogness <john.ogness@linutronix.de>
I do not have the hardware around so I could not test it.
But the code looks good. With the added comment (reported
by the robot):
Reviewed-by: Petr Mladek <pmladek@suse.com>
Best Regards,
Petr
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2025-04-10 12:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-05 14:59 [PATCH v2] serial: sifive: Switch to nbcon console Ryo Takakura
2025-04-06 0:48 ` kernel test robot
2025-04-07 12:39 ` Ryo Takakura
2025-04-10 12:29 ` Petr Mladek [this message]
2025-04-10 14:19 ` Ryo Takakura
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_e5rWcJKUh7eozw@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=bigeasy@linutronix.de \
--cc=conor.dooley@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=ryotkkr98@gmail.com \
--cc=samuel.holland@sifive.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox