* [PATCH 0/2] riscv: sophgo: cv18xx: add top misc system controller
@ 2024-02-14 1:35 Inochi Amaoto
2024-02-14 1:35 ` [PATCH 1/2] dt-bindings: clock: sophgo: Add top misc controller of CV18XX/SG200X series SoC Inochi Amaoto
2024-02-14 1:35 ` [PATCH 2/2] riscv: dts: sophgo: cv18xx: add top misc system controller Inochi Amaoto
0 siblings, 2 replies; 6+ messages in thread
From: Inochi Amaoto @ 2024-02-14 1:35 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Chao Wei,
Chen Wang, Paul Walmsley, Palmer Dabbelt, Albert Ou,
Inochi Amaoto
Cc: Jisheng Zhang, Liu Gui, Jingbao Qiu, dlan, devicetree,
linux-kernel, linux-riscv
Add top misc system controller to CV18XX/SG200X series.
At least for now, this topctrl dt node has no related driver, because
it only contains register for other devices, or the subdevice for some
other purposes. The patch is submitted for providing potential common
dependency for watchdog, sdhci, usb phy and maybe etc.
Inochi Amaoto (2):
dt-bindings: clock: sophgo: Add top misc controller of CV18XX/SG200X
series SoC
riscv: dts: sophgo: cv18xx: top misc system controller
.../soc/sophgo/sophgo,cv1800-top-syscon.yaml | 43 +++++++++++++++++++
arch/riscv/boot/dts/sophgo/cv18xx.dtsi | 8 ++++
2 files changed, 51 insertions(+)
create mode 100644 Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800-top-syscon.yaml
--
2.43.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] dt-bindings: clock: sophgo: Add top misc controller of CV18XX/SG200X series SoC
2024-02-14 1:35 [PATCH 0/2] riscv: sophgo: cv18xx: add top misc system controller Inochi Amaoto
@ 2024-02-14 1:35 ` Inochi Amaoto
2024-02-14 2:21 ` Rob Herring
2024-02-14 1:35 ` [PATCH 2/2] riscv: dts: sophgo: cv18xx: add top misc system controller Inochi Amaoto
1 sibling, 1 reply; 6+ messages in thread
From: Inochi Amaoto @ 2024-02-14 1:35 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Chao Wei,
Chen Wang, Paul Walmsley, Palmer Dabbelt, Albert Ou,
Inochi Amaoto
Cc: Jisheng Zhang, Liu Gui, Jingbao Qiu, dlan, devicetree,
linux-kernel, linux-riscv
CV18XX/SG200X series SoCs have a special top misc system controller,
which provides register access for several devices. In addition to
register access, this system controller also contains some subdevices
(such as dmamux).
Add bindings for top misc controller of CV18XX/SG200X series SoC.
Signed-off-by: Inochi Amaoto <inochiama@outlook.com>
---
.../soc/sophgo/sophgo,cv1800-top-syscon.yaml | 43 +++++++++++++++++++
1 file changed, 43 insertions(+)
create mode 100644 Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800-top-syscon.yaml
diff --git a/Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800-top-syscon.yaml b/Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800-top-syscon.yaml
new file mode 100644
index 000000000000..858f6a2e4c90
--- /dev/null
+++ b/Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800-top-syscon.yaml
@@ -0,0 +1,43 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/soc/starfive/starfive,jh7110-syscon.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Sophgo CV1800/SG2000 SoC top system controller
+
+maintainers:
+ - Inochi Amaoto <inochiama@outlook.com>
+
+description:
+ The Sophgo CV1800/SG2000 SoC top misc system controller provides
+ register access to configure related modules.
+
+properties:
+ compatible:
+ oneOf:
+ - items:
+ - const: sophgo,cv1800-top-syscon
+ - const: syscon
+ - const: simple-mfd
+
+ reg:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ syscon@3000000 {
+ compatible = "sophgo,cv1800-top-syscon",
+ "syscon", "simple-mfd";
+ reg = <0x03000000 0x1000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ };
+
+...
--
2.43.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] riscv: dts: sophgo: cv18xx: add top misc system controller
2024-02-14 1:35 [PATCH 0/2] riscv: sophgo: cv18xx: add top misc system controller Inochi Amaoto
2024-02-14 1:35 ` [PATCH 1/2] dt-bindings: clock: sophgo: Add top misc controller of CV18XX/SG200X series SoC Inochi Amaoto
@ 2024-02-14 1:35 ` Inochi Amaoto
2024-02-17 13:56 ` Jisheng Zhang
1 sibling, 1 reply; 6+ messages in thread
From: Inochi Amaoto @ 2024-02-14 1:35 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Chao Wei,
Chen Wang, Paul Walmsley, Palmer Dabbelt, Albert Ou,
Inochi Amaoto
Cc: Jisheng Zhang, Liu Gui, Jingbao Qiu, dlan, devicetree,
linux-kernel, linux-riscv
Add top misc system controller dt node for CV18XX/SG200x.
Signed-off-by: Inochi Amaoto <inochiama@outlook.com>
---
arch/riscv/boot/dts/sophgo/cv18xx.dtsi | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/riscv/boot/dts/sophgo/cv18xx.dtsi b/arch/riscv/boot/dts/sophgo/cv18xx.dtsi
index 2d6f4a4b1e58..dbf018e99c48 100644
--- a/arch/riscv/boot/dts/sophgo/cv18xx.dtsi
+++ b/arch/riscv/boot/dts/sophgo/cv18xx.dtsi
@@ -53,6 +53,14 @@ soc {
dma-noncoherent;
ranges;
+ topctrl: syscon@3000000 {
+ compatible = "sophgo,cv1800-top-syscon",
+ "syscon", "simple-mfd";
+ reg = <0x03000000 0x1000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ };
+
gpio0: gpio@3020000 {
compatible = "snps,dw-apb-gpio";
reg = <0x3020000 0x1000>;
--
2.43.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: clock: sophgo: Add top misc controller of CV18XX/SG200X series SoC
2024-02-14 1:35 ` [PATCH 1/2] dt-bindings: clock: sophgo: Add top misc controller of CV18XX/SG200X series SoC Inochi Amaoto
@ 2024-02-14 2:21 ` Rob Herring
2024-02-14 2:46 ` Inochi Amaoto
0 siblings, 1 reply; 6+ messages in thread
From: Rob Herring @ 2024-02-14 2:21 UTC (permalink / raw)
To: Inochi Amaoto
Cc: Paul Walmsley, Conor Dooley, devicetree, linux-riscv, Albert Ou,
dlan, Jingbao Qiu, Liu Gui, Palmer Dabbelt, Jisheng Zhang,
Rob Herring, Chen Wang, Chao Wei, linux-kernel,
Krzysztof Kozlowski
On Wed, 14 Feb 2024 09:35:54 +0800, Inochi Amaoto wrote:
> CV18XX/SG200X series SoCs have a special top misc system controller,
> which provides register access for several devices. In addition to
> register access, this system controller also contains some subdevices
> (such as dmamux).
>
> Add bindings for top misc controller of CV18XX/SG200X series SoC.
>
> Signed-off-by: Inochi Amaoto <inochiama@outlook.com>
> ---
> .../soc/sophgo/sophgo,cv1800-top-syscon.yaml | 43 +++++++++++++++++++
> 1 file changed, 43 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800-top-syscon.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
./Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800-top-syscon.yaml:35:1: [error] syntax error: found character '\t' that cannot start any token (syntax)
dtschema/dtc warnings/errors:
make[2]: *** Deleting file 'Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800-top-syscon.example.dts'
Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800-top-syscon.yaml:35:1: found a tab character where an indentation space is expected
make[2]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800-top-syscon.example.dts] Error 1
make[2]: *** Waiting for unfinished jobs....
./Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800-top-syscon.yaml:35:1: found a tab character where an indentation space is expected
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800-top-syscon.yaml: ignoring, error parsing file
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1428: dt_binding_check] Error 2
make: *** [Makefile:240: __sub-make] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/IA1PR20MB4953DA1000B825CA29E3BD11BB4E2@IA1PR20MB4953.namprd20.prod.outlook.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: clock: sophgo: Add top misc controller of CV18XX/SG200X series SoC
2024-02-14 2:21 ` Rob Herring
@ 2024-02-14 2:46 ` Inochi Amaoto
0 siblings, 0 replies; 6+ messages in thread
From: Inochi Amaoto @ 2024-02-14 2:46 UTC (permalink / raw)
To: Rob Herring
Cc: Inochi Amaoto, Paul Walmsley, Conor Dooley, devicetree,
linux-riscv, Albert Ou, dlan, Jingbao Qiu, Liu Gui,
Palmer Dabbelt, Jisheng Zhang, Rob Herring, Chen Wang, Chao Wei,
linux-kernel, Krzysztof Kozlowski
>On Wed, 14 Feb 2024 09:35:54 +0800, Inochi Amaoto wrote:
>> CV18XX/SG200X series SoCs have a special top misc system controller,
>> which provides register access for several devices. In addition to
>> register access, this system controller also contains some subdevices
>> (such as dmamux).
>>
>> Add bindings for top misc controller of CV18XX/SG200X series SoC.
>>
>> Signed-off-by: Inochi Amaoto <inochiama@outlook.com>
>> ---
>> .../soc/sophgo/sophgo,cv1800-top-syscon.yaml | 43 +++++++++++++++++++
>> 1 file changed, 43 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800-top-syscon.yaml
>>
>
>My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
>on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
>yamllint warnings/errors:
>./Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800-top-syscon.yaml:35:1: [error] syntax error: found character '\t' that cannot start any token (syntax)
>
>dtschema/dtc warnings/errors:
>make[2]: *** Deleting file 'Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800-top-syscon.example.dts'
>Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800-top-syscon.yaml:35:1: found a tab character where an indentation space is expected
>make[2]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800-top-syscon.example.dts] Error 1
>make[2]: *** Waiting for unfinished jobs....
>./Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800-top-syscon.yaml:35:1: found a tab character where an indentation space is expected
>/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800-top-syscon.yaml: ignoring, error parsing file
>make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1428: dt_binding_check] Error 2
>make: *** [Makefile:240: __sub-make] Error 2
>
>doc reference errors (make refcheckdocs):
>
>See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/IA1PR20MB4953DA1000B825CA29E3BD11BB4E2@IA1PR20MB4953.namprd20.prod.outlook.com
>
>The base for the series is generally the latest rc1. A different dependency
>should be noted in *this* patch.
>
>If you already ran 'make dt_binding_check' and didn't see the above
>error(s), then make sure 'yamllint' is installed and dt-schema is up to
>date:
>
>pip3 install dtschema --upgrade
>
>Please check and re-submit after running the above command yourself. Note
>that DT_SCHEMA_FILES can be set to your schema file to speed up checking
>your schema. However, it must be unset to test all examples with your schema.
>
Yes, you are right, I have made a fault when processing the bindings.
I have correct this in the new version, thanks.
Regards,
Inochi.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] riscv: dts: sophgo: cv18xx: add top misc system controller
2024-02-14 1:35 ` [PATCH 2/2] riscv: dts: sophgo: cv18xx: add top misc system controller Inochi Amaoto
@ 2024-02-17 13:56 ` Jisheng Zhang
0 siblings, 0 replies; 6+ messages in thread
From: Jisheng Zhang @ 2024-02-17 13:56 UTC (permalink / raw)
To: Inochi Amaoto
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Chao Wei,
Chen Wang, Paul Walmsley, Palmer Dabbelt, Albert Ou, Liu Gui,
Jingbao Qiu, dlan, devicetree, linux-kernel, linux-riscv
On Wed, Feb 14, 2024 at 09:35:55AM +0800, Inochi Amaoto wrote:
> Add top misc system controller dt node for CV18XX/SG200x.
it's better to delay this patch until users is seen.
>
> Signed-off-by: Inochi Amaoto <inochiama@outlook.com>
> ---
> arch/riscv/boot/dts/sophgo/cv18xx.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/riscv/boot/dts/sophgo/cv18xx.dtsi b/arch/riscv/boot/dts/sophgo/cv18xx.dtsi
> index 2d6f4a4b1e58..dbf018e99c48 100644
> --- a/arch/riscv/boot/dts/sophgo/cv18xx.dtsi
> +++ b/arch/riscv/boot/dts/sophgo/cv18xx.dtsi
> @@ -53,6 +53,14 @@ soc {
> dma-noncoherent;
> ranges;
>
> + topctrl: syscon@3000000 {
"sysctrl" is better, the TRM name this as system controller.
> + compatible = "sophgo,cv1800-top-syscon",
> + "syscon", "simple-mfd";
> + reg = <0x03000000 0x1000>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + };
> +
> gpio0: gpio@3020000 {
> compatible = "snps,dw-apb-gpio";
> reg = <0x3020000 0x1000>;
> --
> 2.43.1
>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-02-17 14:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-14 1:35 [PATCH 0/2] riscv: sophgo: cv18xx: add top misc system controller Inochi Amaoto
2024-02-14 1:35 ` [PATCH 1/2] dt-bindings: clock: sophgo: Add top misc controller of CV18XX/SG200X series SoC Inochi Amaoto
2024-02-14 2:21 ` Rob Herring
2024-02-14 2:46 ` Inochi Amaoto
2024-02-14 1:35 ` [PATCH 2/2] riscv: dts: sophgo: cv18xx: add top misc system controller Inochi Amaoto
2024-02-17 13:56 ` Jisheng Zhang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).