Re: [PATCH v11 00/11] Support page table check PowerPC

Rohan McLure
2024-04-02T03:05:39Z

On Thu, 2024-03-28 at 10:28 +0100, Ingo Molnar wrote:
>
> * Rohan McLure <rmclure@linux.ibm.com> wrote:
>
> > Rohan McLure (11):
> >   Revert "mm/page_table_check: remove unused parameter in
> > [__]page_table_check_pud_set"
> >   Revert "mm/page_table_check: remove unused parameter in
> > [__]page_table_check_pmd_set"
> >   Revert "mm/page_table_check: remove unused parameter in
> > [__]page_table_check_pud_clear"
> >   Revert "mm/page_table_check: remove unused parameter in
> > [__]page_table_check_pmd_clear"
> >   Revert "mm/page_table_check: remove unused parameter in
> > [__]page_table_check_pte_clear"
>
> Just a process request: please give these commits proper titles, they
> are not really 'reverts' in the classical sense, and this title hides
> what is being done in the commit. The typical use of reverts is to
> revert a bad change because it broke something. Here the goal is to
> reintroduce functionality.
>
> So please name these 5 patches accordingly, to shed light on what is
> being reintroduced. You can mention it at the end of the changelog
> that
> it's a functional revert of commit XYZ, but that's not the primary
> purpose of the commit.

Thanks for your email, I'll do just that.

>
> Thanks,
>
> Ingo

Cheers,
Rohan