Re: [PATCH v2 2/6] ACPI: RISCV: Add NUMA support based on SRAT and SLIT

Haibo Xu
2024-04-01T07:42:26Z

On Mon, Apr 1, 2024 at 3:06 PM Sunil V L <sunilvl@ventanamicro.com> wrote:
>
> On Thu, Mar 07, 2024 at 04:47:54PM +0800, Haibo Xu wrote:
> > Add acpi_numa.c file to enable parse NUMA information from
> > ACPI SRAT and SLIT tables. SRAT table provide CPUs(Hart) and
> > memory nodes to proximity domain mapping, while SLIT table
> > provide the distance metrics between proximity domains.
> >
> > Signed-off-by: Haibo Xu <haibo1.xu@intel.com>
> > ---
> > arch/riscv/include/asm/acpi.h | 15 +++-
> > arch/riscv/kernel/Makefile | 1 +
> > arch/riscv/kernel/acpi.c | 5 --
> > arch/riscv/kernel/acpi_numa.c | 131 ++++++++++++++++++++++++++++++++++
> > arch/riscv/kernel/setup.c | 4 +-
> > arch/riscv/kernel/smpboot.c | 2 -
> > include/linux/acpi.h | 6 ++
> > 7 files changed, 154 insertions(+), 10 deletions(-)

> > #ifndef PHYS_CPUID_INVALID
> > typedef u32 phys_cpuid_t;
> > #define PHYS_CPUID_INVALID (phys_cpuid_t)(-1)
> > --
> This is a large patch spanning across multiple files. Can we split this
> into multiple smaller patches? Changes look fine to me though.
>

Thanks for the review!
I will try to break them in v3.

> Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>