From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 70494C04FFE for ; Mon, 29 Apr 2024 18:50:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=h8dybEwH2Zu8sLf0mq4jW2e30WesKw+fVDJa9D4DLVc=; b=Oaf04nzSG75Nj2 8vuNxaZCvixwyAb5FE9lSWrb89OYDUmaoo8HE8E/f4TFcngRiHzpUR8ZE/4VunYWIK5oHtNnvpJLb TAsIO2gsR/haEY6MsZo0MF9Y8yafjGqweOs83r3vj0BK6Ble/GgyvpvMpRplI7UOmlXtiaX9DOMK3 hiQNr+/LlS4NPolr2DUtRzZLBn8+PvMJAae978RqeVRi/etzn9tBSz4FzeSzhcVtJoRz2dfba4SXY axFW5A0Br6EpfCGkv6S87uk6XWbGu9DmC/u82TGJKRUD7knqKjGIqFOUKWhivS1+AwyY6p+d9OvQ2 qhaI60vYSwW4ssG1cA0A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1W5M-00000003vPy-04mm; Mon, 29 Apr 2024 18:50:44 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1W5I-00000003vNl-3XKK; Mon, 29 Apr 2024 18:50:42 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 25B0760CE8; Mon, 29 Apr 2024 18:50:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D637C113CD; Mon, 29 Apr 2024 18:50:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714416637; bh=UUe9Ym8luVvg7SpvhcbVnB1HXHf9DLh6B2dgv/+wHJE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=I8MQPreSR7WM849pfNTwUgstd2lzMBqaFexD4EpmqXGh2Q62FSCMZz8DogZwRpP0C K1EAG8eB0WhQaqCJL6WhqB/c3CB9lw6Flxq+VXFuKGUyePhaKvpH6HvXK7h/Fie6Q4 zsZPAmn7koM6r+592OZ8g6EZxz4Chz4weTo+glzAbjy5Rt+pWW7s1tnT3wY31LekCH UMwakkLVKAvGZjWmX2NxNnrsR1xd6kJELxw0UW6UU73p1b1fioNyc1YnSTXqQxpqCN nnVBIEpm5p8dkXY+ItyNgXmkQGhx7pHQcNWR6pnyqwr60McMhu5aOia9XYu4KZa31i CYMeaihsj2PIQ== Date: Mon, 29 Apr 2024 15:50:34 -0300 From: Arnaldo Carvalho de Melo To: Shenlin Liang Cc: anup@brainfault.org, atishp@atishpatra.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com, linux-perf-users@vger.kernel.org Subject: Re: [PATCH v3 0/2] perf kvm: Add kvm stat support on riscv Message-ID: References: <20240422080833.8745-1-liangshenlin@eswincomputing.com> <5e830d33.45c7.18f287c8f73.Coremail.liangshenlin@eswincomputing.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5e830d33.45c7.18f287c8f73.Coremail.liangshenlin@eswincomputing.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240429_115040_997692_B204517C X-CRM114-Status: GOOD ( 22.93 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Mon, Apr 29, 2024 at 02:13:22PM +0800, Shenlin Liang wrote: > Gentle ping... It would be great to have people with such boards testing your patchkit and providing Tested-by tags. Also the patch set has both kernel and tooling support, thus needs to find a RiscV kernel maintainer to pick the kernel bits and then, when that was merged, I would look at reports of tests for the tooling side to then merge it. Hope this clarifies the process, - Arnaldo > > 'perf kvm stat report/record' generates a statistical analysis of KVM > > events and can be used to analyze guest exit reasons. This patch tries > > to add stat support on riscv. > > > > Map the return value of trace_kvm_exit() to the specific cause of the > > exception, and export it to userspace. > > > > It records on two available KVM tracepoints for riscv: "kvm:kvm_entry" > > and "kvm:kvm_exit", and reports statistical data which includes events > > handles time, samples, and so on. > > > > Cross compiling perf in X86 environment may encounter issues with missing > > libraries and tools. Suggest compiling nativly in RISC-V environment > > > > Simple tests go below: > > > > # ./perf kvm record -e "kvm:kvm_entry" -e "kvm:kvm_exit" > > Lowering default frequency rate from 4000 to 2500. > > Please consider tweaking /proc/sys/kernel/perf_event_max_sample_rate. > > [ perf record: Woken up 18 times to write data ] > > [ perf record: Captured and wrote 5.433 MB perf.data.guest (62519 samples) > > > > # ./perf kvm report > > 31K kvm:kvm_entry > > 31K kvm:kvm_exit > > > > # ./perf kvm stat record -a > > [ perf record: Woken up 3 times to write data ] > > [ perf record: Captured and wrote 8.502 MB perf.data.guest (99338 samples) ] > > > > # ./perf kvm stat report --event=vmexit > > Event name Samples Sample% Time (ns) Time% Max Time (ns) Min Time (ns) Mean Time (ns) > > STORE_GUEST_PAGE_FAULT 26968 54.00% 2003031800 40.00% 3361400 27600 74274 > > LOAD_GUEST_PAGE_FAULT 17645 35.00% 1153338100 23.00% 2513400 30800 65363 > > VIRTUAL_INST_FAULT 1247 2.00% 340820800 6.00% 1190800 43300 273312 > > INST_GUEST_PAGE_FAULT 1128 2.00% 340645800 6.00% 2123200 30200 301990 > > SUPERVISOR_SYSCALL 1019 2.00% 245989900 4.00% 1851500 29300 241403 > > LOAD_ACCESS 986 1.00% 671556200 13.00% 4180200 100700 681091 > > INST_ACCESS 655 1.00% 170054800 3.00% 1808300 54600 259625 > > HYPERVISOR_SYSCALL 21 0.00% 4276400 0.00% 716500 116000 203638 > > > > Changes from v1->v2: > > - Rebased on Linux 6.9-rc3. > > > > Changes from v2->v3: > > - Add the missing assignment for 'vcpu_id_str' in patch 2. > > - Remove parentheses that cause compilation errors > > > > Shenlin Liang (2): > > RISCV: KVM: add tracepoints for entry and exit events > > perf kvm/riscv: Port perf kvm stat to RISC-V > > > > arch/riscv/kvm/trace.h | 67 ++++++++++++++++ > > arch/riscv/kvm/vcpu.c | 7 ++ > > tools/perf/arch/riscv/Makefile | 1 + > > tools/perf/arch/riscv/util/Build | 1 + > > tools/perf/arch/riscv/util/kvm-stat.c | 79 +++++++++++++++++++ > > .../arch/riscv/util/riscv_exception_types.h | 35 ++++++++ > > 6 files changed, 190 insertions(+) > > create mode 100644 arch/riscv/kvm/trace.h > > create mode 100644 tools/perf/arch/riscv/util/kvm-stat.c > > create mode 100644 tools/perf/arch/riscv/util/riscv_exception_types.h > > > > -- > > 2.37.2 _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv