From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 127B2C25B10 for ; Fri, 10 May 2024 21:25:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9vZUDUp+AC/SBm11HVmt6zSmuVKJKry2RHLfXHvC4no=; b=wSoIN12sGwfl4t DG7XpjfwNsAzXkB3woMxCQ46GeaFIP4WvzOVCk2Y30vk2/bMFQoTchRfYIHJ5BFD+xTDINLTqn2Aj eigQ6y0kcXCBPnrhzEnbT9Msp7GHO0J5pCaj4riFl62QVLuB8ZFF3JKDK2/JW4qJLHexA9uFdbqbA lJxuZcJ3gwh03hkI9DW+JfmUDGRxN+YtZ3tlme3KLueUsnUOpBLuuFOi0SnT4RurYWJtgkmQN4QNK SspG4g7xB4Cmkudx7mGsQxb+4nA6pMZuXsOctHTlEKYaz3g2/Rz1b+L9WVhOhH93UtvyV1YK3jnyX qpulVgY+eNywiAlwawUQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s5XkE-00000006WND-1PDf; Fri, 10 May 2024 21:25:34 +0000 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s5XkB-00000006WLy-0LVS for linux-riscv@lists.infradead.org; Fri, 10 May 2024 21:25:32 +0000 Received: by mail-pl1-x634.google.com with SMTP id d9443c01a7336-1ecd9a81966so25645865ad.0 for ; Fri, 10 May 2024 14:25:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1715376330; x=1715981130; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=EbHwqyrBSxlaInOgJHXkpBV851gT6eWfUw4RtCMLqkQ=; b=R0hrid9iQ4lbjiCIUkZJQSg9uluSN7QIK6G54TBn8viof/Qlp844NZAhpEL78m4OjJ L+o8KwFFVoOp9UtQmySlsXhjGvC5tzx/wEosPLhW55mwFHO23AJ+2/Q/Z0ECQlQoJf0z ysGcogHY8o+IAHaMBzavCK4Wzl3HB7bdM6ts9axCgP1sEec0AHzIW/CuIQ8lFBh2kyl4 Y1Yw8sWrmgO/u/rKksGuvi2dUHISKvvpu0SLKwDaKJga1vLFq62xLh/vB9hqBRumo4Pl N0N1r/npuNbQqP6sC7+RVwzX+SSpE+gMD4XWxIggzToUSSEJNyokSmH9If71/xBg7gbE mEtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715376330; x=1715981130; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EbHwqyrBSxlaInOgJHXkpBV851gT6eWfUw4RtCMLqkQ=; b=oSyj6xTKpSdYxmGE01bDvcEauM0oyOEGcB7p6grbzqdc2uDqYz4yxTQ3c6wOlrmRaR s3CrFc+VJH5l+n+St2oh7wUznEc4zeXEPSNR0jBmN9RTef12yV7aFDLPt7y16Hw18umk tAuvFm2Pq0VMv09erJnDMhiY1+OJfDTWEFd0/2CEJUbG83rvTp9Ocspn0O8M4+K4wZ4S iNOlyiBveFc72jmDrMRZVtjAWgUMNZi7nakqGQef+A7KbaUUS9V13Bd6++DR1fIrPGfR Ppf+PTOLaeL2xAcqOZ5xJF84cUE8iAlWntRHUEUnIj+EwEmthCgFzMyZhPjyYocADKNh tJjw== X-Forwarded-Encrypted: i=1; AJvYcCXOEWf2lquiI2+thziwjDkt+G/hUxTWOSx+dBJLsKDTdwlLU0obJYVqUgKcWvy/P5bgSAqcpGcDC2x1AVodW/ncYrjr5vNCe+/b0v5nSDLI X-Gm-Message-State: AOJu0YxAm4Sp7hpfm0ClqyGi8VdpmHIksCdfMQWMw93onChNRz99C61z A5XIYq0ZkbRlYOenYVzAp/EhhKpSxllFm8+MbxE2DgxwQw9P51ImadsmcIWcwno= X-Google-Smtp-Source: AGHT+IEW69BEVO8myOChhepwVIMyAvXTkksrs6sLcKMonG9mCSm10McFQyRA5n6lZJBf+YbxIyRNZA== X-Received: by 2002:a17:903:2443:b0:1ec:b6e2:da8f with SMTP id d9443c01a7336-1eefa03a440mr105945135ad.12.1715376330278; Fri, 10 May 2024 14:25:30 -0700 (PDT) Received: from ghost ([2601:647:5700:6860:629e:3f2:f321:6c]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0bf30fddsm36780655ad.136.2024.05.10.14.25.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 May 2024 14:25:29 -0700 (PDT) Date: Fri, 10 May 2024 14:25:26 -0700 From: Charlie Jenkins To: Conor Dooley Cc: Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Guo Ren , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Conor Dooley , Evan Green , =?iso-8859-1?Q?Cl=E9ment_L=E9ger?= , Jonathan Corbet , Shuah Khan , linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Palmer Dabbelt , linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v6 06/17] riscv: Add vendor extensions to /proc/cpuinfo Message-ID: References: <20240503-dev-charlie-support_thead_vector_6_9-v6-0-cb7624e65d82@rivosinc.com> <20240503-dev-charlie-support_thead_vector_6_9-v6-6-cb7624e65d82@rivosinc.com> <20240507-divisive-swoop-c2737a2d9a9f@spud> <20240510-childcare-outlook-d18e3cc5ccb3@spud> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240510-childcare-outlook-d18e3cc5ccb3@spud> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240510_142531_148903_477986B3 X-CRM114-Status: GOOD ( 16.34 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Fri, May 10, 2024 at 09:50:32PM +0100, Conor Dooley wrote: > On Tue, May 07, 2024 at 06:03:19PM +0100, Conor Dooley wrote: > > On Fri, May 03, 2024 at 11:18:21AM -0700, Charlie Jenkins wrote: > > > All of the supported vendor extensions that have been listed in > > > riscv_isa_vendor_ext_list can be exported through /proc/cpuinfo. > > > > > > Signed-off-by: Charlie Jenkins > > > > This seems fine, thanks for updating this interface :) > > > > Reviewed-by: Conor Dooley > > Hmm, actually the automation on patchwork is complaining a bunch about > the series, but I think that's mostly false positives except for this > patch. The nommu defconfigs are prob the easiest way to reproduce this: > /build/tmp.QPMRM3oUNu/arch/riscv/kernel/vendor_extensions.c:41:55: error: 'struct riscv_isa_vendor_ext_data_list' has no member named 'vendor_bitmap' > /build/tmp.QPMRM3oUNu/arch/riscv/kernel/vendor_extensions.c:42:60: error: 'struct riscv_isa_vendor_ext_data_list' has no member named 'per_hart_vendor_bitmap'; did you mean 'per_hart_isa_bitmap'? > /build/tmp.QPMRM3oUNu/arch/riscv/kernel/vendor_extensions.c:43:60: error: 'struct riscv_isa_vendor_ext_data_list' has no member named 'bitmap_size' > > Cheers, > Conor. The false negatives always throw me off. The errors are also offset by one patch. This was actually introduced in the following patch "riscv: Introduce vendor variants of extension helpers" because I accidentally fixed this issue in the patch "riscv: cpufeature: Extract common elements from extension checking" instead of the one it was introduced in. - Charlie _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv