Re: [PATCH v4 37/66] selftests/nolibc: Drop define _GNU_SOURCE

Thomas Weißschuh
2024-05-10T06:58:27Z

Hi Edward,

On 2024-05-10 00:06:54+0000, Edward Liaw wrote:
> _GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
> redefinition warnings.

The nolibc tests do not use lib.mk.

This change breaks "make libc-test", please drop it.

> Signed-off-by: Edward Liaw <edliaw@google.com>
> ---
> tools/testing/selftests/nolibc/nolibc-test.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/tools/testing/selftests/nolibc/nolibc-test.c b/tools/testing/selftests/nolibc/nolibc-test.c
> index 94bb6e11c16f..a28813f4367f 100644
> --- a/tools/testing/selftests/nolibc/nolibc-test.c
> +++ b/tools/testing/selftests/nolibc/nolibc-test.c
> @@ -1,6 +1,4 @@
> /* SPDX-License-Identifier: GPL-2.0 */
> -
> -#define _GNU_SOURCE
> #define _LARGEFILE64_SOURCE
>
> /* libc-specific include files
> --
> 2.45.0.118.g7fe29c98d7-goog

Thomas