Re: [PATCH v2 0/4] riscv: Separate vendor extensions from standard extensions

Conor Dooley
2024-06-13T14:45:47Z

[-- Attachment #1.1: Type: text/plain, Size: 1289 bytes --]

On Sun, Jun 09, 2024 at 09:34:13PM -0700, Charlie Jenkins wrote:
> All extensions, both standard and vendor, live in one struct
> "riscv_isa_ext". There is currently one vendor extension, xandespmu, but
> it is likely that more vendor extensions will be added to the kernel in
> the future. As more vendor extensions (and standard extensions) are
> added, riscv_isa_ext will become more bloated with a mix of vendor and
> standard extensions.
>
> This also allows each vendor to be conditionally enabled through
> Kconfig.
>
> ---
> This has been split out from the previous series that contained the
> addition of xtheadvector due to lack of reviews. The xtheadvector
> support will be posted again separately from this.

I think that's a good call.

> The reviewed-bys on "riscv: Extend cpufeature.c to detect vendor extensions"
> and "riscv: Introduce vendor variants of extension helpers" have been
> dropped in this series. The majority of the code is the same in these
> patches, but thead-specific code is swapped out with andes-specific
> code. The changes are minimal, but I decided to drop the reviews in case
> I inadvertently introduced issues.

Actually, you only completely did that on the first of the two patches
you mention, but I don't mind.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]