From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 96257C30653 for ; Thu, 4 Jul 2024 14:32:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RIUPfvggzykpOr8HbCuQTRnp6B4WxlLftySX4mVolC0=; b=fB9Zm8NKuyJdH8 IuRD8Vn4P+b712z8C8X1cP+Q70QY+9AJ0x3TS/zKSJFTVeWU1LiI1nn/nfvS1hCCgWkhxLyDrV8Wv zg2GWRRzMqQVPXxnqq0AhuYD2UrdGbMM7HEVeR28ET+MhBB5q7cRWcmekwEIVm3snnz/A0p5Lu42/ YJKgQyK4FAqodHu8s5h2Jeq9rhrW1mN3H4heW7MIbp8ks4FJDdr91obDwsN6Jtl8g1DyCO08h9/vt t5n/Spu4enMhIgzfAFLfJgVuDaESeRBoOXwY0w7wz1CyZT4uUB24sfHMWYlh1iOhhAEu7mUPuPG00 jizZvNe26mp6FCvlaGEA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sPNVn-0000000DTax-386M; Thu, 04 Jul 2024 14:32:39 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sPNVk-0000000DTaV-2RhW for linux-riscv@lists.infradead.org; Thu, 04 Jul 2024 14:32:38 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 69CD9626E5; Thu, 4 Jul 2024 14:32:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 72EFBC3277B; Thu, 4 Jul 2024 14:32:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1720103555; bh=qIIdd4Y2oSY8Kqi9SCeYIA0qIOCeR/Y3ZDNe/1fwS/Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JclKHbiulTCgPGr8fznFvQ5IC+es8m7ecL4fUPNuet/7E3qRXOrPYbOKvKF1WKXmw GOJbYUthGWeq+FowyuJokOdkrGPwi2Q328AJZUIfqbEstrCTy/B3uszJzzxQKJsYgd k3jsCzGYEttELvM72ydv6OGRjDR217kRFiNY6HEpnrdB7GN7gtlgS4TkM2eZZuusX+ Xl7uDcogSiISdbm+99VsBlau3Y4jLT0Bp4W+XnsIz9e6MLJsEsXfKl3auVE6CBAmDb MA6H+7e2OgmBVis5yxP9P9a+Ca04sAL3f2ThS41cjVpySATHIu4xQty6m9Dx20J7iN +I7Mkg5/TsB8A== Date: Thu, 4 Jul 2024 22:18:26 +0800 From: Jisheng Zhang To: Yixun Lan Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Daniel Lezcano , Thomas Gleixner , Samuel Holland , Anup Patel , Greg Kroah-Hartman , Jiri Slaby , Lubomir Rintel , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Yangyu Chen , Inochi Amaoto , linux-serial@vger.kernel.org, linux-riscv@lists.infradead.org, Meng Zhang Subject: Re: [PATCH v3 08/11] riscv: dts: add initial SpacemiT K1 SoC device tree Message-ID: References: <20240703-k1-01-basic-dt-v3-0-12f73b47461e@gentoo.org> <20240703-k1-01-basic-dt-v3-8-12f73b47461e@gentoo.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240704_073236_888459_89101398 X-CRM114-Status: GOOD ( 27.84 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Thu, Jul 04, 2024 at 09:48:01PM +0800, Jisheng Zhang wrote: > On Wed, Jul 03, 2024 at 02:55:11PM +0000, Yixun Lan wrote: > > From: Yangyu Chen > > > > Banana Pi BPI-F3 motherboard is powered by SpacemiT K1[1]. > > > > Key features: > > - 4 cores per cluster, 2 clusters on chip > > - UART IP is Intel XScale UART > > > > Some key considerations: > > - ISA string is inferred from vendor documentation[2] > > - Cluster topology is inferred from datasheet[1] and L2 in vendor dts[3] > > - No coherent DMA on this board > > Inferred by taking vendor ethernet and MMC drivers to the mainline > > kernel. Without dma-noncoherent in soc node, the driver fails. > > - No cache nodes now > > The parameters from vendor dts are likely to be wrong. It has 512 > > sets for a 32KiB L1 Cache. In this case, each set is 64B in size. > > When the size of the cache line is 64B, it is a directly mapped > > cache rather than a set-associative cache, the latter is commonly > > used. Thus, I didn't use the parameters from vendor dts. > > > > Currently only support booting into console with only uart, other > > features will be added soon later. > > > > Link: https://docs.banana-pi.org/en/BPI-F3/SpacemiT_K1_datasheet [1] > > Link: https://developer.spacemit.com/#/documentation?token=BWbGwbx7liGW21kq9lucSA6Vnpb [2] > > Link: https://gitee.com/bianbu-linux/linux-6.1/blob/bl-v1.0.y/arch/riscv/boot/dts/spacemit/k1-x.dtsi [3] > > Signed-off-by: Yangyu Chen > > Signed-off-by: Yixun Lan > > --- > > arch/riscv/boot/dts/spacemit/k1.dtsi | 376 +++++++++++++++++++++++++++++++++++ > > 1 file changed, 376 insertions(+) > > > > diff --git a/arch/riscv/boot/dts/spacemit/k1.dtsi b/arch/riscv/boot/dts/spacemit/k1.dtsi > > new file mode 100644 > > index 0000000000000..a076e35855a2e > > --- /dev/null > > +++ b/arch/riscv/boot/dts/spacemit/k1.dtsi > > @@ -0,0 +1,376 @@ > > +// SPDX-License-Identifier: GPL-2.0 OR MIT > > +/* > > + * Copyright (C) 2024 Yangyu Chen > > + */ > > + > > +/dts-v1/; > > +/ { > > + #address-cells = <2>; > > + #size-cells = <2>; > > + model = "SpacemiT K1"; > > + compatible = "spacemit,k1"; > > + > > + aliases { > > + serial0 = &uart0; > > + serial1 = &uart2; > > + serial2 = &uart3; > > + serial3 = &uart4; > > + serial4 = &uart5; > > + serial5 = &uart6; > > + serial6 = &uart7; > > + serial7 = &uart8; > > + serial8 = &uart9; > > + }; > > + > > + cpus { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + timebase-frequency = <24000000>; > > + > > + cpu-map { > > + cluster0 { > > + core0 { > > + cpu = <&cpu_0>; > > + }; > > + core1 { > > + cpu = <&cpu_1>; > > + }; > > + core2 { > > + cpu = <&cpu_2>; > > + }; > > + core3 { > > + cpu = <&cpu_3>; > > + }; > > + }; > > + > > + cluster1 { > > + core0 { > > + cpu = <&cpu_4>; > > + }; > > + core1 { > > + cpu = <&cpu_5>; > > + }; > > + core2 { > > + cpu = <&cpu_6>; > > + }; > > + core3 { > > + cpu = <&cpu_7>; > > + }; > > + }; > > + }; > > + > > + cpu_0: cpu@0 { > > + compatible = "spacemit,x60", "riscv"; > > + device_type = "cpu"; > > + reg = <0>; > > + riscv,isa = "rv64imafdcv_zicbom_zicbop_zicboz_zicntr_zicond_zicsr_zifencei_zihintpause_zihpm_zfh_zba_zbb_zbc_zbs_zkt_zvfh_zvkt_sscofpmf_sstc_svinval_svnapot_svpbmt"; > > + riscv,isa-base = "rv64i"; > > + riscv,isa-extensions = "i", "m", "a", "f", "d", "c", "v", "zicbom", > > + "zicbop", "zicboz", "zicntr", "zicond", "zicsr", > > + "zifencei", "zihintpause", "zihpm", "zfh", "zba", > > + "zbb", "zbc", "zbs", "zkt", "zvfh", "zvkt", > > + "sscofpmf", "sstc", "svinval", "svnapot", "svpbmt"; > > + riscv,cbom-block-size = <64>; > > + riscv,cbop-block-size = <64>; > > + riscv,cboz-block-size = <64>; > > + mmu-type = "riscv,sv39"; > > + > > + cpu0_intc: interrupt-controller { > > + compatible = "riscv,cpu-intc"; > > + interrupt-controller; > > + #interrupt-cells = <1>; > > + }; > > + }; > > + > > + cpu_1: cpu@1 { > > + compatible = "spacemit,x60", "riscv"; > > + device_type = "cpu"; > > + reg = <1>; > > + riscv,isa = "rv64imafdcv_zicbom_zicbop_zicboz_zicntr_zicond_zicsr_zifencei_zihintpause_zihpm_zfh_zba_zbb_zbc_zbs_zkt_zvfh_zvkt_sscofpmf_sstc_svinval_svnapot_svpbmt"; > > + riscv,isa-base = "rv64i"; > > + riscv,isa-extensions = "i", "m", "a", "f", "d", "c", "v", "zicbom", > > + "zicbop", "zicboz", "zicntr", "zicond", "zicsr", > > + "zifencei", "zihintpause", "zihpm", "zfh", "zba", > > + "zbb", "zbc", "zbs", "zkt", "zvfh", "zvkt", > > + "sscofpmf", "sstc", "svinval", "svnapot", "svpbmt"; > > + riscv,cbom-block-size = <64>; > > + riscv,cbop-block-size = <64>; > > + riscv,cboz-block-size = <64>; > > + mmu-type = "riscv,sv39"; > > + > > + cpu1_intc: interrupt-controller { > > + compatible = "riscv,cpu-intc"; > > + interrupt-controller; > > + #interrupt-cells = <1>; > > + }; > > + }; > > + > > + cpu_2: cpu@2 { > > + compatible = "spacemit,x60", "riscv"; > > + device_type = "cpu"; > > + reg = <2>; > > + riscv,isa = "rv64imafdcv_zicbom_zicbop_zicboz_zicntr_zicond_zicsr_zifencei_zihintpause_zihpm_zfh_zba_zbb_zbc_zbs_zkt_zvfh_zvkt_sscofpmf_sstc_svinval_svnapot_svpbmt"; > > + riscv,isa-base = "rv64i"; > > + riscv,isa-extensions = "i", "m", "a", "f", "d", "c", "v", "zicbom", > > + "zicbop", "zicboz", "zicntr", "zicond", "zicsr", > > + "zifencei", "zihintpause", "zihpm", "zfh", "zba", > > + "zbb", "zbc", "zbs", "zkt", "zvfh", "zvkt", > > + "sscofpmf", "sstc", "svinval", "svnapot", "svpbmt"; > > + riscv,cbom-block-size = <64>; > > + riscv,cbop-block-size = <64>; > > + riscv,cboz-block-size = <64>; > > + mmu-type = "riscv,sv39"; > > + > > + cpu2_intc: interrupt-controller { > > + compatible = "riscv,cpu-intc"; > > + interrupt-controller; > > + #interrupt-cells = <1>; > > + }; > > + }; > > + > > + cpu_3: cpu@3 { > > + compatible = "spacemit,x60", "riscv"; > > + device_type = "cpu"; > > + reg = <3>; > > + riscv,isa = "rv64imafdcv_zicbom_zicbop_zicboz_zicntr_zicond_zicsr_zifencei_zihintpause_zihpm_zfh_zba_zbb_zbc_zbs_zkt_zvfh_zvkt_sscofpmf_sstc_svinval_svnapot_svpbmt"; > > + riscv,isa-base = "rv64i"; > > + riscv,isa-extensions = "i", "m", "a", "f", "d", "c", "v", "zicbom", > > + "zicbop", "zicboz", "zicntr", "zicond", "zicsr", > > + "zifencei", "zihintpause", "zihpm", "zfh", "zba", > > + "zbb", "zbc", "zbs", "zkt", "zvfh", "zvkt", > > + "sscofpmf", "sstc", "svinval", "svnapot", "svpbmt"; > > + riscv,cbom-block-size = <64>; > > + riscv,cbop-block-size = <64>; > > + riscv,cboz-block-size = <64>; > > + mmu-type = "riscv,sv39"; > > + > > + cpu3_intc: interrupt-controller { > > + compatible = "riscv,cpu-intc"; > > + interrupt-controller; > > + #interrupt-cells = <1>; > > + }; > > + }; > > + > > + cpu_4: cpu@4 { > > + compatible = "spacemit,x60", "riscv"; > > + device_type = "cpu"; > > + reg = <4>; > > + riscv,isa = "rv64imafdcv_zicbom_zicbop_zicboz_zicntr_zicond_zicsr_zifencei_zihintpause_zihpm_zfh_zba_zbb_zbc_zbs_zkt_zvfh_zvkt_sscofpmf_sstc_svinval_svnapot_svpbmt"; > > + riscv,isa-base = "rv64i"; > > + riscv,isa-extensions = "i", "m", "a", "f", "d", "c", "v", "zicbom", > > + "zicbop", "zicboz", "zicntr", "zicond", "zicsr", > > + "zifencei", "zihintpause", "zihpm", "zfh", "zba", > > + "zbb", "zbc", "zbs", "zkt", "zvfh", "zvkt", > > + "sscofpmf", "sstc", "svinval", "svnapot", "svpbmt"; > > + riscv,cbom-block-size = <64>; > > + riscv,cbop-block-size = <64>; > > + riscv,cboz-block-size = <64>; > > + mmu-type = "riscv,sv39"; > > + > > + cpu4_intc: interrupt-controller { > > + compatible = "riscv,cpu-intc"; > > + interrupt-controller; > > + #interrupt-cells = <1>; > > + }; > > + }; > > + > > + cpu_5: cpu@5 { > > + compatible = "spacemit,x60", "riscv"; > > + device_type = "cpu"; > > + reg = <5>; > > + riscv,isa = "rv64imafdcv_zicbom_zicbop_zicboz_zicntr_zicond_zicsr_zifencei_zihintpause_zihpm_zfh_zba_zbb_zbc_zbs_zkt_zvfh_zvkt_sscofpmf_sstc_svinval_svnapot_svpbmt"; > > + riscv,isa-base = "rv64i"; > > + riscv,isa-extensions = "i", "m", "a", "f", "d", "c", "v", "zicbom", > > + "zicbop", "zicboz", "zicntr", "zicond", "zicsr", > > + "zifencei", "zihintpause", "zihpm", "zfh", "zba", > > + "zbb", "zbc", "zbs", "zkt", "zvfh", "zvkt", > > + "sscofpmf", "sstc", "svinval", "svnapot", "svpbmt"; > > + riscv,cbom-block-size = <64>; > > + riscv,cbop-block-size = <64>; > > + riscv,cboz-block-size = <64>; > > + mmu-type = "riscv,sv39"; > > + > > + cpu5_intc: interrupt-controller { > > + compatible = "riscv,cpu-intc"; > > + interrupt-controller; > > + #interrupt-cells = <1>; > > + }; > > + }; > > + > > + cpu_6: cpu@6 { > > + compatible = "spacemit,x60", "riscv"; > > + device_type = "cpu"; > > + reg = <6>; > > + riscv,isa = "rv64imafdcv_zicbom_zicbop_zicboz_zicntr_zicond_zicsr_zifencei_zihintpause_zihpm_zfh_zba_zbb_zbc_zbs_zkt_zvfh_zvkt_sscofpmf_sstc_svinval_svnapot_svpbmt"; > > + riscv,isa-base = "rv64i"; > > + riscv,isa-extensions = "i", "m", "a", "f", "d", "c", "v", "zicbom", > > + "zicbop", "zicboz", "zicntr", "zicond", "zicsr", > > + "zifencei", "zihintpause", "zihpm", "zfh", "zba", > > + "zbb", "zbc", "zbs", "zkt", "zvfh", "zvkt", > > + "sscofpmf", "sstc", "svinval", "svnapot", "svpbmt"; > > + riscv,cbom-block-size = <64>; > > + riscv,cbop-block-size = <64>; > > + riscv,cboz-block-size = <64>; > > + mmu-type = "riscv,sv39"; > > + > > + cpu6_intc: interrupt-controller { > > + compatible = "riscv,cpu-intc"; > > + interrupt-controller; > > + #interrupt-cells = <1>; > > + }; > > + }; > > + > > + cpu_7: cpu@7 { > > + compatible = "spacemit,x60", "riscv"; > > + device_type = "cpu"; > > + reg = <7>; > > + riscv,isa = "rv64imafdcv_zicbom_zicbop_zicboz_zicntr_zicond_zicsr_zifencei_zihintpause_zihpm_zfh_zba_zbb_zbc_zbs_zkt_zvfh_zvkt_sscofpmf_sstc_svinval_svnapot_svpbmt"; > > + riscv,isa-base = "rv64i"; > > + riscv,isa-extensions = "i", "m", "a", "f", "d", "c", "v", "zicbom", > > + "zicbop", "zicboz", "zicntr", "zicond", "zicsr", > > + "zifencei", "zihintpause", "zihpm", "zfh", "zba", > > + "zbb", "zbc", "zbs", "zkt", "zvfh", "zvkt", > > + "sscofpmf", "sstc", "svinval", "svnapot", "svpbmt"; > > + riscv,cbom-block-size = <64>; > > + riscv,cbop-block-size = <64>; > > + riscv,cboz-block-size = <64>; > > + mmu-type = "riscv,sv39"; > > + > > + cpu7_intc: interrupt-controller { > > + compatible = "riscv,cpu-intc"; > > + interrupt-controller; > > + #interrupt-cells = <1>; > > + }; > > + }; > > + > > + }; > > + > > + soc { > > + compatible = "simple-bus"; > > + interrupt-parent = <&plic>; > > + #address-cells = <2>; > > + #size-cells = <2>; > > + dma-noncoherent; > > + ranges; > > + > > + uart0: serial@d4017000 { > > + compatible = "spacemit,k1-uart", "intel,xscale-uart"; > > no, this is not a correct hw modeling. Vendor's linux kernel source code also clearly indicates the FIFO size is 64B. > > IIRC, 8250_pxa is a xscale uart with 64 bytes FIFO, so this should be > "mrvl,pxa-uart" or "mrvl,mmp-uart" > > > + reg = <0x0 0xd4017000 0x0 0x100>; > > + interrupts = <42>; > > + clock-frequency = <14857000>; > > once clk is ready, you will remove this property and add clk phandles, > so why not bring clk, pinctrl, reset before hand? > _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv