Re: [PATCH v2 3/3] riscv: dts: thead: Add TH1520 ethernet nodes

Drew Fustini
2024-09-28T20:47:22Z

On Fri, Sep 27, 2024 at 05:55:04AM -0700, Emil Renner Berthing wrote:
> Drew Fustini wrote:
> > From: Emil Renner Berthing <emil.renner.berthing@canonical.com>
> >
> > Signed-off-by: Emil Renner Berthing <emil.renner.berthing@canonical.com>
> > [drew: change apb registers from syscon to second reg of gmac node]
> > [drew: add phy reset delay properties for beaglev ahead]
> > Signed-off-by: Drew Fustini <dfustini@tenstorrent.com>
> > ---
> > arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts | 91 ++++++++++++++
> > .../boot/dts/thead/th1520-lichee-module-4a.dtsi | 135 +++++++++++++++++++++
> > arch/riscv/boot/dts/thead/th1520.dtsi | 50 ++++++++
> > 3 files changed, 276 insertions(+)
>
> ...
>
> > diff --git a/arch/riscv/boot/dts/thead/th1520-lichee-module-4a.dtsi b/arch/riscv/boot/dts/thead/th1520-lichee-module-4a.dtsi
> > index ca84bc2039ef..d9d2e1f4dc68 100644
> > --- a/arch/riscv/boot/dts/thead/th1520-lichee-module-4a.dtsi
> > +++ b/arch/riscv/boot/dts/thead/th1520-lichee-module-4a.dtsi
> > @@ -11,6 +11,11 @@ / {
> > model = "Sipeed Lichee Module 4A";
> > compatible = "sipeed,lichee-module-4a", "thead,th1520";
> >
> > + aliases {
> > + ethernet0 = &gmac0;
> > + ethernet1 = &gmac1;
> > + };
> > +
> > memory@0 {
> > device_type = "memory";
> > reg = <0x0 0x00000000 0x2 0x00000000>;
> > @@ -25,6 +30,16 @@ &osc_32k {
> > clock-frequency = <32768>;
> > };
> >
> > +&dmac0 {
> > + status = "okay";
> > +};
> > +
> > +&aogpio {
> > + gpio-line-names = "", "", "",
> > + "GPIO00",
> > + "GPIO04";
> > +};
> > +
>
> These GPIO line names does not belong in this patch. They should
> already be included in your other patchset adding the names for the
> other lines.
>
> /Emil

Thanks, yeah, those sneaked in here.

Drew