From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3B592CF07B7 for ; Thu, 10 Oct 2024 06:54:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QSDjbAc0p9Mh9DI8i8WYTSHXib+K98Mm2NqYhTLnBbk=; b=InNYycJJ1KfJoS 8fUl9T7nWqw8j5er3wNfJe0SZ4fElj8C2KTnlxHVHU3QvwUqNv7qq0/HgGFBnNWEfgVBYWpLUqjK/ b24W3Tp609EMD4C/kf2VGZL93zLFh8CfH65ZcSIQpkHxf7+g68Ts3XE/xbrpKT3dVv3NDSyHiAgw6 GjL2xDBxl+tsJgeoWyzkIvRgLIEBGD02EsDvVubqyWt6FwezS6il7J4imUo4lsy888mVwcWXqadsG rPAJa6t7eTBkXHXHzTvHwPoeDsPJM1iAbjGJtjZj6GO7qxqYhbjx46Zf5L6dBLyoBh8KuE4C+X1D9 kbG7kPP2Ivp3kWCsrU2g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1syn3y-0000000BkJ4-0nIg; Thu, 10 Oct 2024 06:54:18 +0000 Received: from hch by bombadil.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1syn3r-0000000BkI0-1JPh; Thu, 10 Oct 2024 06:54:11 +0000 Date: Wed, 9 Oct 2024 23:54:11 -0700 From: Christoph Hellwig To: Mike Rapoport Cc: Andrew Morton , Andreas Larsson , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Borislav Petkov , Brian Cain , Catalin Marinas , Christoph Hellwig , Christophe Leroy , Dave Hansen , Dinh Nguyen , Geert Uytterhoeven , Guo Ren , Helge Deller , Huacai Chen , Ingo Molnar , Johannes Berg , John Paul Adrian Glaubitz , Kent Overstreet , "Liam R. Howlett" , Luis Chamberlain , Mark Rutland , Masami Hiramatsu , Matt Turner , Max Filippov , Michael Ellerman , Michal Simek , Oleg Nesterov , Palmer Dabbelt , Peter Zijlstra , Richard Weinberger , Russell King , Song Liu , Stafford Horne , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Uladzislau Rezki , Vineet Gupta , Will Deacon , bpf@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-trace-kernel@vger.kernel.org, linux-um@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v5 1/8] mm: vmalloc: group declarations depending on CONFIG_MMU together Message-ID: References: <20241009180816.83591-1-rppt@kernel.org> <20241009180816.83591-2-rppt@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20241009180816.83591-2-rppt@kernel.org> X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Wed, Oct 09, 2024 at 09:08:09PM +0300, Mike Rapoport wrote: > +/* for /proc/kcore */ > +extern long vread_iter(struct iov_iter *iter, const char *addr, size_t count); > + > +/* > + * Internals. Don't use.. > + */ > +extern __init void vm_area_add_early(struct vm_struct *vm); > +extern __init void vm_area_register_early(struct vm_struct *vm, size_t align); Please drop the externs while you're at it. (one more down below) Otherwise looks good: Reviewed-by: Christoph Hellwig _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv