From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 01D2AE674AA for ; Fri, 1 Nov 2024 07:15:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MnqMU8gV87BXQjTPpBrqpIaR+wNb0xYvteDRCdc7YkA=; b=x+Tc89duvRo/r9 1nIeVCDOBAF9nuxyQ7qmHQC2Ot5ipZCtfsxydekCmiUDkYIHKTkpfYcxY407AExzBWvaAA7pXIa4H N8udAA9j9fu8bhAVTIaxqNAyM9FfjzC0MUH6jaus4insGePY+eGcSq6AjZdudFwj3XFWlUCpg24kh SJEC2A8xfuVbNg1S9jyha1Q2Bv8saxN7i8X7R1j+Ecc/QR+b1T1LuoRhYtC+mFVRcpOsHFhf382Sz YhOAKPSgRpNYjxkz8hhLZw6/0BKGaHbcot0aOUoUZ7gBWINuHS1cN8geGh+qswiAo0FeMLRtNPeEt ni0GwTsvqkMxys9xt1/Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t6ls6-000000064op-42Kh; Fri, 01 Nov 2024 07:15:02 +0000 Received: from mail-qv1-xf32.google.com ([2607:f8b0:4864:20::f32]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t6lik-0000000631c-3UQl; Fri, 01 Nov 2024 07:05:24 +0000 Received: by mail-qv1-xf32.google.com with SMTP id 6a1803df08f44-6cbf340fccaso13860446d6.1; Fri, 01 Nov 2024 00:05:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730444721; x=1731049521; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:feedback-id:from:to:cc:subject:date :message-id:reply-to; bh=CeRtSAMS9mSdK5Z3YnzN1Gk/iNcxNQ7vtANptzs5s5s=; b=hQ8K6lEo7wSf03Nsb1J1u4dowc8SpXPbJHVwKDIl8EHXF8htuWXFye7Kr8xKg8MTGp 9/HTkx8xdJUfLnRx7b0zVGKiclGsupRGNwi49Ghb3n+gCck/MgCXdzC6H4ZeHZ2kVNgW r6iV8sueJLqNnOBonirl/cEdR5StW1RGVXaEMR5Z2T/FlfWT2LZU84H9V3+DqlKxyZHP lhTunOFrOXc6v+7se9Ny6btCoXUdMXGKY048eeb/0F8s8mMVMFh+vCUpraEHbEWdWHA+ xu49kKIRehFadfEdgYR39iqDcD+wk2/KJ4aAzrk3Mj72GFBecYAwwzik6SFV/vZvf5pl dNSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730444721; x=1731049521; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:feedback-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CeRtSAMS9mSdK5Z3YnzN1Gk/iNcxNQ7vtANptzs5s5s=; b=ocD9ojRTnaD6M+w4sBaYdDQjKext3SPAbW+Hcen5CHcFb4VkRBaY8lMRSxDLvMATBX ltfiRpB7XM/yEObevPje+VmUzmIa3oCdLnyGTZp2aIRVXcQK6es3JWXA7z2jjt2Bo+Q/ SbDRRBGAJlFq40eojOoYRYE9WG4BjX0X+njgLA7Z1NqxrVXudYGxm5DfmaEA3bPTzO36 n1+iN7pl8iEBylkU/byveJWvu6w6Bmfryi9n3DNbfw3I/rNitUEhNzdkLvaRL6B+oD6C vo3xNuMFquqE+74bJqTP/edjt7Xi1jzv8I0/3g0Y8/nyAUWytAE5ZAyPWaU8FsylZsuS K/wg== X-Forwarded-Encrypted: i=1; AJvYcCVr7JXEPf/C3Pd/2WSGkHH0RCCw58WFr3gsXvPQr1sVK2Am2xE5qxfWMEEddiDBQH7rU0G+i9fuIGc7XOY=@lists.infradead.org, AJvYcCXEY/lzOxE2mnzdgA8uXHGo9xUIZ1T6lrrXZZRlY+FF4umGRICo5AogeoPR3I6nLAx0bnYRx45gG0suKlgAUs8z@lists.infradead.org X-Gm-Message-State: AOJu0YzfRIYoQFXc5xI8TI63Iwo50lgB/VexCdIvQnwxwXqbqx9K1MTd w6atTIWpML/4ie3mu/4sIWPSa3DOGoS3rei0D7s+QEh2O6I7YyfR X-Google-Smtp-Source: AGHT+IFp7PFcA9Yv18ZEzkJXz4nXgYi4dBXhMW8cGjnyABXDu+HDq6u6pDyh6cUOwHEOB5KNw4VoqA== X-Received: by 2002:a05:6214:5d0d:b0:6cb:e9da:bd4 with SMTP id 6a1803df08f44-6d35424a1b4mr91380006d6.5.1730444721519; Fri, 01 Nov 2024 00:05:21 -0700 (PDT) Received: from fauth-a2-smtp.messagingengine.com (fauth-a2-smtp.messagingengine.com. [103.168.172.201]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6d353f9f1f6sm16124086d6.27.2024.11.01.00.05.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Nov 2024 00:05:21 -0700 (PDT) Received: from phl-compute-10.internal (phl-compute-10.phl.internal [10.202.2.50]) by mailfauth.phl.internal (Postfix) with ESMTP id 4AB8A1200043; Fri, 1 Nov 2024 03:05:20 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-10.internal (MEProxy); Fri, 01 Nov 2024 03:05:20 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdekkedguddttdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpeffhffvvefukfhfgggtuggjsehttdertddttddv necuhfhrohhmpeeuohhquhhnucfhvghnghcuoegsohhquhhnrdhfvghnghesghhmrghilh drtghomheqnecuggftrfgrthhtvghrnhephedugfduffffteeutddvheeuveelvdfhleel ieevtdeguefhgeeuveeiudffiedvnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrg hmpehmrghilhhfrhhomhepsghoqhhunhdomhgvshhmthhprghuthhhphgvrhhsohhnrghl ihhthidqieelvdeghedtieegqddujeejkeehheehvddqsghoqhhunhdrfhgvnhhgpeepgh hmrghilhdrtghomhesfhhigihmvgdrnhgrmhgvpdhnsggprhgtphhtthhopeehkedpmhho uggvpehsmhhtphhouhhtpdhrtghpthhtohepuggrvhhiughgohifsehgohhoghhlvgdrtg homhdprhgtphhtthhopehruhhsthdqfhhorhdqlhhinhhugiesvhhgvghrrdhkvghrnhgv lhdrohhrghdprhgtphhtthhopehrtghusehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtg hpthhtoheplhhinhhugidqkhgvrhhnvghlsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhr tghpthhtoheplhhinhhugidqrghrtghhsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtg hpthhtoheplhhlvhhmsehlihhsthhsrdhlihhnuhigrdguvghvpdhrtghpthhtoheplhhk mhhmsehlihhsthhsrdhlihhnuhigrdguvghvpdhrtghpthhtohepohhjvggurgeskhgvrh hnvghlrdhorhhgpdhrtghpthhtoheprghlvgigrdhgrgihnhhorhesghhmrghilhdrtgho mh X-ME-Proxy: Feedback-ID: iad51458e:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 1 Nov 2024 03:05:19 -0400 (EDT) Date: Fri, 1 Nov 2024 00:04:09 -0700 From: Boqun Feng To: David Gow Cc: rust-for-linux@vger.kernel.org, rcu@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, llvm@lists.linux.dev, lkmm@lists.linux.dev, Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Andreas Hindborg , Alice Ryhl , Alan Stern , Andrea Parri , Will Deacon , Peter Zijlstra , Nicholas Piggin , David Howells , Jade Alglave , Luc Maranget , "Paul E. McKenney" , Akira Yokosawa , Daniel Lustig , Joel Fernandes , Nathan Chancellor , Nick Desaulniers , kent.overstreet@gmail.com, Greg Kroah-Hartman , elver@google.com, Mark Rutland , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Catalin Marinas , torvalds@linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-fsdevel@vger.kernel.org, Trevor Gross , dakr@redhat.com, Frederic Weisbecker , Neeraj Upadhyay , Josh Triplett , Uladzislau Rezki , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-riscv@lists.infradead.org Subject: Re: [RFC v2 11/13] rust: sync: Add memory barriers Message-ID: References: <20241101060237.1185533-1-boqun.feng@gmail.com> <20241101060237.1185533-12-boqun.feng@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241101_000522_910238_B1A2AE58 X-CRM114-Status: GOOD ( 23.89 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Fri, Nov 01, 2024 at 02:55:23PM +0800, David Gow wrote: > On Fri, 1 Nov 2024 at 14:07, Boqun Feng wrote: > > > > Memory barriers are building blocks for concurrent code, hence provide > > a minimal set of them. > > > > The compiler barrier, barrier(), is implemented in inline asm instead of > > using core::sync::atomic::compiler_fence() because memory models are > > different: kernel's atomics are implemented in inline asm therefore the > > compiler barrier should be implemented in inline asm as well. > > > > Signed-off-by: Boqun Feng > > --- > > rust/helpers/helpers.c | 1 + > > rust/kernel/sync.rs | 1 + > > rust/kernel/sync/barrier.rs | 67 +++++++++++++++++++++++++++++++++++++ > > 3 files changed, 69 insertions(+) > > create mode 100644 rust/kernel/sync/barrier.rs > > > > diff --git a/rust/helpers/helpers.c b/rust/helpers/helpers.c > > index ab5a3f1be241..f4a94833b29d 100644 > > --- a/rust/helpers/helpers.c > > +++ b/rust/helpers/helpers.c > > @@ -8,6 +8,7 @@ > > */ > > > > #include "atomic.c" > > +#include "barrier.c" > > It looks like "barrier.c" is missing, so this isn't compiling for me. > I assume it was meant to be added in this patch...? > Yes, I just send an updated one. Glad being "checking missing files" buddies with you ;-) Thanks! Regards, Boqun > Thanks, > -- David _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv