From: Kishon Vijay Abraham I <kishon@ti.com>
To: Alan Mikhak <alan.mikhak@sifive.com>, <linux-pci@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <lorenzo.pieralisi@arm.com>,
<linux-riscv@lists.infradead.org>,
Palmer Dabbelt <palmer@sifive.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Bjorn Helgaas <bhelgaas@google.com>,
<gustavo.pimentel@synopsys.com>, <wen.yang99@zte.com.cn>,
<kjlu@umn.edu>
Subject: Re: [PATCH v2] PCI: endpoint: Allocate enough space for fixed size BAR
Date: Fri, 24 May 2019 14:14:47 +0530 [thread overview]
Message-ID: <a08ce87a-d515-b1c3-a903-6777e18c87ae@ti.com> (raw)
In-Reply-To: <CABEDWGxMXg7RAgrUL-7W6vgC0BpCj9ys+i7myjxdBgn3vn_P6Q@mail.gmail.com>
On 24/05/19 5:26 AM, Alan Mikhak wrote:
> +Bjorn Helgaas, +Gustavo Pimentel, +Wen Yang, +Kangjie Lu
>
> On Thu, May 23, 2019 at 2:48 PM Alan Mikhak <alan.mikhak@sifive.com> wrote:
>>
>> PCI endpoint test function code should honor the .bar_fixed_size parameter
>> from underlying endpoint controller drivers or results may be unexpected.
>>
>> In pci_epf_test_alloc_space(), check if BAR being used for test register
>> space is a fixed size BAR. If so, allocate the required fixed size.
>>
>> Signed-off-by: Alan Mikhak <alan.mikhak@sifive.com>
Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
>> ---
>> drivers/pci/endpoint/functions/pci-epf-test.c | 8 +++++++-
>> 1 file changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c
>> index 27806987e93b..7d41e6684b87 100644
>> --- a/drivers/pci/endpoint/functions/pci-epf-test.c
>> +++ b/drivers/pci/endpoint/functions/pci-epf-test.c
>> @@ -434,10 +434,16 @@ static int pci_epf_test_alloc_space(struct pci_epf *epf)
>> int bar;
>> enum pci_barno test_reg_bar = epf_test->test_reg_bar;
>> const struct pci_epc_features *epc_features;
>> + size_t test_reg_size;
>>
>> epc_features = epf_test->epc_features;
>>
>> - base = pci_epf_alloc_space(epf, sizeof(struct pci_epf_test_reg),
>> + if (epc_features->bar_fixed_size[test_reg_bar])
>> + test_reg_size = bar_size[test_reg_bar];
>> + else
>> + test_reg_size = sizeof(struct pci_epf_test_reg);
>> +
>> + base = pci_epf_alloc_space(epf, test_reg_size,
>> test_reg_bar, epc_features->align);
>> if (!base) {
>> dev_err(dev, "Failed to allocated register space\n");
>> --
>> 2.7.4
>>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-05-24 8:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 21:47 [PATCH v2] PCI: endpoint: Allocate enough space for fixed size BAR Alan Mikhak
2019-05-23 23:56 ` Alan Mikhak
2019-05-24 8:44 ` Kishon Vijay Abraham I [this message]
2019-06-11 10:08 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a08ce87a-d515-b1c3-a903-6777e18c87ae@ti.com \
--to=kishon@ti.com \
--cc=alan.mikhak@sifive.com \
--cc=bhelgaas@google.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
--cc=wen.yang99@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox