Re: [PATCH v1] riscv: dts: starfive: Append starfive,jh7110 compatible to VisionFive 2 Lite

From: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
To: Conor Dooley <conor@kernel.org>, E Shattow <e@freeshell.de>
Cc: Emil Renner Berthing <kernel@esmil.dk>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Paul Walmsley <pjw@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>,
	Hal Feng <hal.feng@starfivetech.com>,
	linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
	devicetree@vger.kernel.org,
	Emil Renner Berthing <emil.renner.berthing@canonical.com>,
	Conor Dooley <conor.dooley@microchip.com>
Subject: Re: [PATCH v1] riscv: dts: starfive: Append starfive,jh7110 compatible to VisionFive 2 Lite
Date: Mon, 8 Dec 2025 17:38:07 +0100	[thread overview]
Message-ID: <a18850ad-b6de-4444-9daf-a4a653f4f9ae@canonical.com> (raw)
In-Reply-To: <20251208-jogging-morally-9b787b7ab1b8@spud>

On 12/8/25 17:29, Conor Dooley wrote:
> On Sat, Dec 06, 2025 at 12:45:30PM -0800, E Shattow wrote:
>> Append starfive,jh7110 compatible to VisionFive 2 Lite and VisionFive 2
>> Lite eMMC in the "least compatible" end of the list. JH7110S on these
>> boards is the same tape-out as JH7110 however rated for thermal, voltage,
>> and frequency characteristics for a maximum of 1.25GHz operation.
>>
>> Link to previous discussion suggesting this change:
>> https://lore.kernel.org/lkml/1f96a267-f5c6-498e-a2c4-7a47a73ea7e7@canonical.com/
>>
>> Fixes: 900b32fd601b ("riscv: dts: starfive: Add VisionFive 2 Lite board device tree")
>> Fixes: ae264ae12442 ("riscv: dts: starfive: Add VisionFive 2 Lite eMMC board device tree")
>> Suggested-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
>> Signed-off-by: E Shattow <e@freeshell.de>
> 
> You can't do this without modifying the binding too, as this doesn't
> pass dtbs_check.
> 
> However, is this actually correct? The frequency of operation and the
> temperature range aren't a superset of what the jh7110 can do, what is
> the actual advantage of having it? If there's some software that this
> would make a difference for, please mention it in the commit message.

Appending "starfive,jh7110" would reduce the number of compatible 
strings to check in the OpenSBI platform driver.

Best regards

Heinrich

> 
> Cheers,
> Conor.
> 
>> ---
>>   .../dts/starfive/jh7110-starfive-visionfive-2-lite-emmc.dts     | 2 +-
>>   .../boot/dts/starfive/jh7110-starfive-visionfive-2-lite.dts     | 2 +-
>>   2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-lite-emmc.dts b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-lite-emmc.dts
>> index e27a662d4022..7544efa95de4 100644
>> --- a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-lite-emmc.dts
>> +++ b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-lite-emmc.dts
>> @@ -9,7 +9,7 @@
>>   
>>   / {
>>   	model = "StarFive VisionFive 2 Lite eMMC";
>> -	compatible = "starfive,visionfive-2-lite-emmc", "starfive,jh7110s";
>> +	compatible = "starfive,visionfive-2-lite-emmc", "starfive,jh7110s", "starfive,jh7110";
>>   };
>>   
>>   &mmc0 {
>> diff --git a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-lite.dts b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-lite.dts
>> index b96eea4fa7d5..b9913991a1b7 100644
>> --- a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-lite.dts
>> +++ b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-lite.dts
>> @@ -9,7 +9,7 @@
>>   
>>   / {
>>   	model = "StarFive VisionFive 2 Lite";
>> -	compatible = "starfive,visionfive-2-lite", "starfive,jh7110s";
>> +	compatible = "starfive,visionfive-2-lite", "starfive,jh7110s", "starfive,jh7110";
>>   };
>>   
>>   &mmc0 {
>>
>> base-commit: 5e5ea7f61610239fca058011e7d4f342b34d1558
>> -- 
>> 2.50.0
>>

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv