From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 98669C7618D for ; Mon, 20 Mar 2023 07:41:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gjQBTy2XkHgC4kElFztOuF3SAkFHyqJ4dKfLgXuY6x4=; b=F9jC7/ZsLdy2EH xwz6IAEFON85W6vl2MQfdgHU8fueNmpwuosaITDzt/uX3yYeTTLxCzQdpLOXBSJW3Te0I+euwkNzh wYCCNENPUPu1KisJieMmg9aS3StF4mWPVxPUg0spY+xHxUu2qsKx6OJaBnALOoyFIrIq4DeOExS7b j5aw9iKg2LomeRTw3O2zTSyOSNHWBLg5Dk5N79S+hnwiq+aKnYa4DWFWvj1bZk0TbwxktTxZFflBt J0UK0yqfZKf97D0MdXu2Ss5fRi7DmD8s9hFEk4Io01d+Ikn1YHOtI5gdU7HXgtmRn5EvzL1CdSFdO wcyMtetjSM/H6sRik5+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1peA8e-008Jzy-0D; Mon, 20 Mar 2023 07:41:04 +0000 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1peA8a-008Jyz-30 for linux-riscv@lists.infradead.org; Mon, 20 Mar 2023 07:41:02 +0000 Received: by mail-ed1-x532.google.com with SMTP id cy23so42868986edb.12 for ; Mon, 20 Mar 2023 00:40:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679298058; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=EEJwPUcj30LR1Jvi4gq3x/eDVKkkFRtCJxEfs4FDdm4=; b=K+smoDKcwnMxZrFNrJhdgowPDNaNTLyYz6zlEKxBEqQoEG3U+3ow0kJxlZknQwrGMB u04dEEYkv//4yL//8tVkINm9Ieh7vEfPxMPVPRU5Zxh3K6ves71YXuJonexO5/k0eruR Dw4HDFJYDAT8EGmLhsDNJTcXS/1bhC560OysoRkAxlvuoUCC4qx2VzVba6gN432Z3iCx JPMK8sefwNUC70ZxMHds79JkwuendtkP6KHYKc+KaAA9Yl+K1NY1bS7zb+5+KNlQ49cL 5foHjP4G5g5hHiEThk8XHd+37eot8QkVHdL358kCzBtbTA7CKD9Shn76OLsosAJ7tU9U BLLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679298058; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EEJwPUcj30LR1Jvi4gq3x/eDVKkkFRtCJxEfs4FDdm4=; b=tBaqhca0qHGV2qvjBlCa2xLLGjHqkpEUb/7WsznVYJnEWW6/A7BuYYv7FLragoTLfc i5nYX5h/lBdK3Ud7LGGFlj0H/VxKRB03zrPieH6Foo/GaHC8WuYE7ryQrdwMSz/NoXq/ nSYgBodbshYgqTpBlDhaeCE8lXie1GWTRvTeqK92tL2PelitEpW4tA9uJOWE7DZMmyHw wjdzKZmWwQN7zfMqoOmtA68O3BXMvUjy/1s4mPlbyKOCzABYZDvQcmEsWJOCGiVqTozu +BFeC165RljXwicjsIYHM0JR5Wd016+F+Kl32CQ5QTNG4ppvM6qofI/X/Zo3n7SvGiIn TM6g== X-Gm-Message-State: AO0yUKUezlYM8K4guPLCtJKIcKxM+KZQkZc3PwuRaNAmApHR3Qea02fn XymtTg1EtrI88PzocEi4QD94fg== X-Google-Smtp-Source: AK7set8K83XcDqgvWGsUDkVZexSnqd6rwD5aeLXBfdzVWwJ7+1NQq8zSCs4BDTyss9P7wWoUZ3G6Lw== X-Received: by 2002:a17:906:1f53:b0:931:91a:fa4f with SMTP id d19-20020a1709061f5300b00931091afa4fmr8808137ejk.41.1679298058663; Mon, 20 Mar 2023 00:40:58 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:4428:8354:afb6:2992? ([2a02:810d:15c0:828:4428:8354:afb6:2992]) by smtp.gmail.com with ESMTPSA id kj2-20020a170907764200b009324717b9f3sm3513196ejc.71.2023.03.20.00.40.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Mar 2023 00:40:58 -0700 (PDT) Message-ID: Date: Mon, 20 Mar 2023 08:40:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v2 3/6] dt-bindings: soc: starfive: syscon: Add optional patternProperties Content-Language: en-US To: Xingyu Wu Cc: linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, Michael Turquette , Stephen Boyd , Philipp Zabel , Conor Dooley , Emil Renner Berthing , Rob Herring , Paul Walmsley , Palmer Dabbelt , Albert Ou , Hal Feng , William Qiu , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org References: <20230316030514.137427-1-xingyu.wu@starfivetech.com> <20230316030514.137427-4-xingyu.wu@starfivetech.com> <1f352445-4677-e33b-be14-c76bd7ffa188@linaro.org> <45221a1c-dc01-2759-3e32-658636625529@starfivetech.com> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230320_004100_981809_232B8213 X-CRM114-Status: GOOD ( 18.78 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On 20/03/2023 08:29, Xingyu Wu wrote: > On 2023/3/20 14:37, Krzysztof Kozlowski wrote: >> On 20/03/2023 04:54, Xingyu Wu wrote: >>> On 2023/3/19 20:28, Krzysztof Kozlowski wrote: >>>> On 16/03/2023 04:05, Xingyu Wu wrote: >>>>> Add optional compatible and patternProperties. >>>>> >>>>> Signed-off-by: Xingyu Wu >>>>> --- >>>>> .../soc/starfive/starfive,jh7110-syscon.yaml | 39 ++++++++++++++++--- >>>>> 1 file changed, 33 insertions(+), 6 deletions(-) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-syscon.yaml b/Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-syscon.yaml >>>>> index ae7f1d6916af..b61d8921ef42 100644 >>>>> --- a/Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-syscon.yaml >>>>> +++ b/Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-syscon.yaml >>>>> @@ -15,16 +15,31 @@ description: | >>>>> >>>>> properties: >>>>> compatible: >>>>> - items: >>>>> - - enum: >>>>> - - starfive,jh7110-aon-syscon >>>>> - - starfive,jh7110-stg-syscon >>>>> - - starfive,jh7110-sys-syscon >>>>> - - const: syscon >>>>> + oneOf: >>>>> + - items: >>>>> + - enum: >>>>> + - starfive,jh7110-aon-syscon >>>>> + - starfive,jh7110-stg-syscon >>>>> + - starfive,jh7110-sys-syscon >>>>> + - const: syscon >>>>> + - items: >>>>> + - enum: >>>>> + - starfive,jh7110-aon-syscon >>>>> + - starfive,jh7110-stg-syscon >>>>> + - starfive,jh7110-sys-syscon >>>>> + - const: syscon >>>>> + - const: simple-mfd BTW, this also looks wrong. You just said that clock controller exists only in few variants. Also, why sometimes the same device goes with simple-mfd and sometimies without? It's the same device. >>>>> >>>>> reg: >>>>> maxItems: 1 >>>>> >>>>> +patternProperties: >>>>> + # Optional children >>>>> + "pll-clock-controller": >>>> >>>> It's not a pattern. >>> >>> Does it use 'properties' instead of 'patternProperties'? >> >> Yes. >> >>> >>>> >>>> Anyway should be clock-controller >>> >>> Will fix. >>> >>>> >>>>> + type: object >>>>> + $ref: /schemas/clock/starfive,jh7110-pll.yaml# >>>>> + description: Clock provider for PLL. >>>>> + >>>> >>>> You just added these bindings! So the initial submission was incomplete >>>> on purpose? >>>> >>>> No, add complete bindings. >>> >>> Does you mean that it should drop the 'description', or add complete 'description', >>> or add 'compatible', 'clocks' and 'clock-cells' of complete clock-controller bindings? >> >> It means it should be squashed with the patch which adds it. > > Should I drop the 'decription' here and keep the 'decription' in patch1? There should be no this patch at all. However I do not understand what you want to do with description. What's wrong with description? > >> >>> >>>> >>>>> required: >>>>> - compatible >>>>> - reg >>>>> @@ -38,4 +53,16 @@ examples: >>>>> reg = <0x10240000 0x1000>; >>>>> }; >>>>> >>>>> + - | >>>>> + syscon@13030000 { >>>> >>>> No need for new example... Just put it in existing one. >>>> >>> >>> Actually, the PLL clock-controller are just set in sys-syscon resgisters. The stg-syscon and >>> aon-syscon don't need it. So PLL clock-controller node only is added in sys-syscon node. >> >> So why having other examples if they are included here? Drop them. >> > > Should I drop the old example of stg-syscon and add a new example of sys-syscon which > include clock-controller child node? No, there should be no stg-syscon example, it's useless. Best regards, Krzysztof _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv