From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C986C369D3 for ; Sun, 27 Apr 2025 12:43:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vdXR92B4CZUGhQ9xHmcJdWy/L+Uw8IFI8UMMj3mUXRk=; b=IPr385sRom0oDK j+JM8t+9x35KpwRTISprjPU7Ar2OVdmF2+o4wGcZVLVZB1uHYe7B1beMO2InQljsNd+YTkQ2OcZQo ygeGLOCRFpgfLV4zdwHXf8VrIDeaq+enGW65z2p7xnPra7I4KWCtajEfwa3eJkYibIzVBCIgGlD4a qo1TE3Nw14qE1s2xLPlZ9TYQUEyDxVO+OX3pnv45UPB1FqplQfxEacYdrmQqWqEFA77bew4EqpjBU 4UNOWmSarDBTcyD4Jb4PiUvLpv4oo0aL8TGRyhQjCTC3kLkPtpFiNM32aroE+R6tSmSRjXQ2AqBlW w78FrgDjNfy8ofi2zq0w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u91MO-00000003Vz7-1q9O; Sun, 27 Apr 2025 12:43:52 +0000 Received: from abb.hmeau.com ([144.6.53.87]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u91KP-00000003VZQ-2fNd; Sun, 27 Apr 2025 12:41:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hmeau.com; s=formenos; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=8B83JaeVQLHgFCWXWffwqUb0JmXK1uEo4GZHcdcva+Y=; b=LB/WZAlfGOzyKCTr/sq7hB3Rdp 87DGEL/SX99F82X/5S3CEt+KMPNil4eQ5XKn9HKMnUxA4cfDf2PrRlmreWsvqfNqxji0Ahm+IqUQd wXdO33aEhGmFBOIXuWpE+8bZioYkuicGAN5B/jPJ2fK2P8K9cQiDFC/DlSxp1X3SHny4nVm15XAer aSB48aWcfnwfs22dSqJc1WnuG99u9FTL86VXIeZNZAw4NPoARt7CX+u2bzA4RtU1Kraqbddk4uCU/ yAMqvxfq3a/ZkqN2tSwmIOwRD7TQsIjCpK6QaSzQIFGD7u7OUwRc33CrLVfbIPdhLP99OmnTsWDY/ Uek3AdhQ==; Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.96 #2 (Debian)) id 1u91KE-001OSo-2c; Sun, 27 Apr 2025 20:41:39 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Sun, 27 Apr 2025 20:41:38 +0800 Date: Sun, 27 Apr 2025 20:41:38 +0800 From: Herbert Xu To: Eric Biggers Cc: Linux Crypto Mailing List , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, sparclinux@vger.kernel.org, linux-s390@vger.kernel.org, x86@kernel.org, Ard Biesheuvel , "Jason A . Donenfeld " , Linus Torvalds Subject: Re: [v2 PATCH 00/13] Architecture-optimized SHA-256 library API Message-ID: References: <20250427123514.GA1161@quark> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250427123514.GA1161@quark> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250427_054149_676875_26796AD6 X-CRM114-Status: GOOD ( 10.27 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Sun, Apr 27, 2025 at 05:35:14AM -0700, Eric Biggers wrote: > > Well, barely a day and you've already ruined my patch series. Now instead of a > clean design where the crypto_shash API is built on top of the normal library > API (sha256_update() etc.), there's now a special low-level API > "sha256_choose_blocks()" just for shash that it's built on top of instead, for > no good reason. You're also still pushing your broken BLOCK_HASH_UPDATE_BLOCKS > macro that doesn't work with size_t, and putting my name on your broken code > that uses it. Your design is unacceptable because you're forcing the partial block handling on shash where it's not needed, just as you're forcing the hardirq support on everything. I'll take your point about size_t and update the BLOCK_HASH helper. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv