From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0EEE4C3ABAA for ; Fri, 2 May 2025 21:05:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=i9WvtSiTLCagHaMbsrApRo7OYHj5SSOPyw4+9YFNBBc=; b=kQkFFymQHQFzHjrpICrjQK7UaY Lvezipi+n+zBRNFQd9CkTxafR/FdHYAdd7EVPhNZQMO7HttBJmfSYaPerVxvbi/TsAIHYa9B4F8/y Inwh2Ww8l0Wo073xHt+MzRdkGmxdizMnpWbiNGPpYH28nsR+nYAIDyhhSxbem4ZA/M+vAx85l4Yhh dTMZ1qeS6I6tPZGWJuaTZ+JUA1/u78p8L0LiPg2rV8R6gGn1IocXJZIA7J1Gx8z1/VsrWz+/IrXji OAo6KEQ/GZ39VnUWXLzigDA/c8puTOr6LZX29/BL9P5/v67iKfVUiab+mwbjjb0UJiQnxd+55PYkv L04UqtWQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uAxZg-000000031rI-245i; Fri, 02 May 2025 21:05:36 +0000 Received: from mail-pg1-x549.google.com ([2607:f8b0:4864:20::549]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uAxRc-000000030wN-40KE for linux-riscv@lists.infradead.org; Fri, 02 May 2025 20:57:18 +0000 Received: by mail-pg1-x549.google.com with SMTP id 41be03b00d2f7-b00e4358a34so1463544a12.0 for ; Fri, 02 May 2025 13:57:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1746219435; x=1746824235; darn=lists.infradead.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=ZjfhxP1aTkCqZKrd23sK3YHNUgKYVqxJbIVvYWHW5Vg=; b=CCO0UPAPEcW1FhpcdnqRa/5QVFCgirASa6Jiwx4U9bD+Vp3KjzJHRXyCHT2n/it0Mb r6nI1POCp3MEP/XmbhiUMxa7MWUyZ5o5Eo5+J1n7rFFEwTKuscqdNmEOa9R/ugI8XG9b N1JIV6e/PEd6Xui6QqpZWOIf+pgAmQMGSKopXrX0Wph015simffST1YfhI8QILPUFseu +jau8kiCVA9TnGeQA74LFT8b1DedWRtsv80TY4GxmjT+YlzI9JAJPVTzvylZr6eOntgU q5hbDR73pKU+Xn3fprfCU5ecG/aVVAVY040rQAl+uhAcrr9zxGZH+Fs/sJP2P6f2os0L 9T9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746219435; x=1746824235; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZjfhxP1aTkCqZKrd23sK3YHNUgKYVqxJbIVvYWHW5Vg=; b=Tjr5EMUH1tAbZngyhUIiUUmXOHUXEJN6AdeXsDrrW/NPlwb1nT0J2YEqs76kac8DEF GEOJk2O4BvJTvauhPJrTV7mZaUwc1AimMzPeACLeN1mOfJnj1QQGuFRykmOgVcdiVA5E 85Q5FFPLtQUwFP9J5JISr0HM49QrrIL1qsHA28MEDk1yhgngh6LjaLE0IU5dcDuZ4xdo Uwo4S/SpqHZa8fDCi569oAnPDr1Ytz23IM9DFmYsOhvJXtgZMtJ5gVmyFndW39TGEe/2 pHXSKaJNy5TaSr8jr7ks6PJvOvskdDbYkBvXFF4RrhRwIEU1fS0ixo7KnhpeEyEDImNL lepA== X-Forwarded-Encrypted: i=1; AJvYcCU4dMMFbnRzssJdejgJ+iuKVJyV3DN7XlTPpe9cdx4ssQ59eTG8E7b5EXPFRgkvwmPCglrm4OoEZGavoQ==@lists.infradead.org X-Gm-Message-State: AOJu0YzS4UhdpNGAqMIRZPU+aDa+enAiGAHMvi5xL88SFhbjNw01T+pa KQVe1auMEE7W/ijGdDQk+cmevmcobSgj7+ZiRMlPV3pzJOKpjV0tUjE3jIhUB8vNT3v3Z8h111r tzg== X-Google-Smtp-Source: AGHT+IFuPDTKjcdWvbnOJrt3XOUZC4A4co+KVYAa4VIdQzxs3SS2Bb249oxqj85YoS9Ls6YyYG5MsQtlc4s= X-Received: from pjbqb9.prod.google.com ([2002:a17:90b:2809:b0:2f5:63a:4513]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:2f0e:b0:2ff:618c:a1e0 with SMTP id 98e67ed59e1d1-30a4e6b2624mr6211245a91.29.1746219435414; Fri, 02 May 2025 13:57:15 -0700 (PDT) Date: Fri, 2 May 2025 13:57:13 -0700 In-Reply-To: <20250430203013.366479-6-mlevitsk@redhat.com> Mime-Version: 1.0 References: <20250430203013.366479-1-mlevitsk@redhat.com> <20250430203013.366479-6-mlevitsk@redhat.com> Message-ID: Subject: Re: [PATCH v4 5/5] x86: KVM: SEV: implement kvm_lock_all_vcpus and use it From: Sean Christopherson To: Maxim Levitsky Cc: kvm@vger.kernel.org, linux-riscv@lists.infradead.org, Kunkun Jiang , Waiman Long , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Catalin Marinas , Bjorn Helgaas , Boqun Feng , Borislav Petkov , Albert Ou , Anup Patel , Paul Walmsley , Suzuki K Poulose , Palmer Dabbelt , Alexandre Ghiti , Alexander Potapenko , Oliver Upton , Andre Przywara , x86@kernel.org, Joey Gouly , Thomas Gleixner , kvm-riscv@lists.infradead.org, Atish Patra , Ingo Molnar , Jing Zhang , "H. Peter Anvin" , Dave Hansen , kvmarm@lists.linux.dev, Will Deacon , Keisuke Nishimura , Sebastian Ott , Peter Zijlstra , Shusen Li , Paolo Bonzini , Randy Dunlap , Marc Zyngier , Zenghui Yu X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250502_135716_984671_DF865AD2 X-CRM114-Status: GOOD ( 15.18 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Wed, Apr 30, 2025, Maxim Levitsky wrote: > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index 834f08dfa24c..9211b07b0565 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -1392,6 +1392,31 @@ int kvm_trylock_all_vcpus(struct kvm *kvm) > } > EXPORT_SYMBOL_GPL(kvm_trylock_all_vcpus); > > +/* > + * Lock all of the VM's vCPUs. > + * Assumes that the kvm->lock is held. Add a lockdep assertion instead of a comment. > + * Returns -EINTR if the process is killed. > + */ > +int kvm_lock_all_vcpus(struct kvm *kvm) > +{ > + struct kvm_vcpu *vcpu; > + unsigned long i, j; > + > + kvm_for_each_vcpu(i, vcpu, kvm) Needs curly braces. > + if (mutex_lock_killable_nest_lock(&vcpu->mutex, &kvm->lock)) I'd rather return mutex_lock_killable_nest_lock()'s error code verbatim. Then the function comment can go away, because the only thing remaining would be: /* * Lock all of the VM's vCPUs. /* and that should be completely self-explanatory. E.g. int kvm_lock_all_vcpus(struct kvm *kvm) { struct kvm_vcpu *vcpu; unsigned long i, j; int r; lockdep_assert_held(&kvm->lock); kvm_for_each_vcpu(i, vcpu, kvm) { r = mutex_lock_killable_nest_lock(&vcpu->mutex, &kvm->lock); if (r) goto out_unlock; } return 0; out_unlock: kvm_for_each_vcpu(j, vcpu, kvm) { if (i == j) break; mutex_unlock(&vcpu->mutex); } return r; } EXPORT_SYMBOL_GPL(kvm_lock_all_vcpus); _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv