From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 20A8AC3ABAC for ; Fri, 2 May 2025 21:05:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=7ST1k14+egohjxH6lf19NaYEminD6BzeXe95Q34f8kg=; b=v3VwIc2oRMRm1s5rdXsfqMY0p+ mbdtpRtS7aKXsv5AgYEBkL8wZimVyCfQmrZ/WGqJMsRMMxr4WLghLz8gXjx3R4RpmwYp7V8cQorTB cRqSCYxvj+3NuoHQxYUeORf2Ke3jdpwiSNDwWR7bT8+6CV6WX49SBiP4o/F9oRiHzZvSLczRl5qSO XXfXSxYrI26QcGTEglNAmI1nXNmbTpDNcU3iWS/OW7MxbF6jhRZZK42VOggaJHeOqnu6gap03Q2FW vJbtP94PUqFOjtYxrhymRDpiCopwywUyMq27bdS1hPLzqN0C/b7MIh98vfRfuM0syOWdsV5eli4gA HxTBmhsQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uAxZh-000000031sD-3aPl; Fri, 02 May 2025 21:05:37 +0000 Received: from mail-pj1-x104a.google.com ([2607:f8b0:4864:20::104a]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uAxTC-0000000318n-1nH5 for linux-riscv@lists.infradead.org; Fri, 02 May 2025 20:58:56 +0000 Received: by mail-pj1-x104a.google.com with SMTP id 98e67ed59e1d1-30a59538b17so378281a91.3 for ; Fri, 02 May 2025 13:58:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1746219533; x=1746824333; darn=lists.infradead.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=z141FLEwqm2f5UKeV3GY2SvtY7oSxEMFO78Y0lhO4Mo=; b=L08LiuUwe9hAZ3bFgxSnWRHRf4z5pTSiM4tIRDrgAbeAwyyMZTuh3s4VYaesnziVIJ PnGZfytFfcv9/aaipiSXpQReQzGtygbWHVi9+spYoM4dw4Em6xxRMe1A6WwpEQ7ucijw xUVqiDN/ID1YoU0Bmdp/QONQ2hO0UtOFHZSNxP/Yhtb+FLII6eUyBd9yYXsKY2++PSB8 YrJXe/sCQvi0LoyXnoKz9YW+U1Ny3jokK6WSDIoszwOZR/6DphSBEPoYSH2R5u9fFbXw k3JPz04rhhOQYS6FINIQB5RyFFoyjMyrTLPXxjOfgWHt+ibBlFTZjuv32qHEZTv/1PoA QXcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746219533; x=1746824333; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=z141FLEwqm2f5UKeV3GY2SvtY7oSxEMFO78Y0lhO4Mo=; b=l94Y3fa9IYLvLi+Nv5JCBK8wjLr+i9XFnA1YxdWultwvAneV/nlP8g9tvyrBf9K9h8 iAlUb9IjDMbTAUw1+yUK4KnGEhlSIGRf0IC3K2u2dkv8osVoBoWMP3PrKbFVEBvwDU+Y YmRMgXmn1qC0AUmf6LBXl156FCPZjf0durPBT3nGQO4yh0t1eBtVP8k6UGlI8SJkP6JS cbFqObOk9lM80hk2FD0ofUNUnJ4t47iwOk0QIDkJseXx2ac81iiSCy38KAUHs2hKVwsm 7wAHWiYh1wcLkG68D+dtFXpu3R8D7JqbzzWvU97SU3NlqGHXGHHaFwhYW+jv/KdVlx+p 4JYA== X-Forwarded-Encrypted: i=1; AJvYcCWeDNDWgAUs8SQ3QrToKtS0hdlBe547U2P1GiFt48NGqpuEie7O5IlgmEN0OkYX+4Uoca3pHXZU+9u8FQ==@lists.infradead.org X-Gm-Message-State: AOJu0YwFw4zpFkwuS+9FarpJAXvrwsjm3lRBxFQw1g95QQMw8+lCMPBp r1MRau3tm1bgVnjqphlAnueuisqmVV9biy0LsWRbomkd1oPTHbfx6+Q7HArO7Oplyx3fPokgtw+ RMQ== X-Google-Smtp-Source: AGHT+IGm3fjnbZdZ0P5dTXEIDYUNeozyMh591wQHnGgOaKhf2rgPLaUDWxwxyDC2IuE6wOX5aAwhTk5qwaY= X-Received: from pjff8.prod.google.com ([2002:a17:90b:5628:b0:2ff:8471:8e53]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:1f8c:b0:305:5f32:d9f0 with SMTP id 98e67ed59e1d1-30a4e5c5e9dmr6320303a91.19.1746219533227; Fri, 02 May 2025 13:58:53 -0700 (PDT) Date: Fri, 2 May 2025 13:58:51 -0700 In-Reply-To: <864iy4ivro.wl-maz@kernel.org> Mime-Version: 1.0 References: <20250430203013.366479-1-mlevitsk@redhat.com> <20250430203013.366479-3-mlevitsk@redhat.com> <864iy4ivro.wl-maz@kernel.org> Message-ID: Subject: Re: [PATCH v4 2/5] arm64: KVM: use mutex_trylock_nest_lock when locking all vCPUs From: Sean Christopherson To: Marc Zyngier Cc: Maxim Levitsky , kvm@vger.kernel.org, linux-riscv@lists.infradead.org, Kunkun Jiang , Waiman Long , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Catalin Marinas , Bjorn Helgaas , Boqun Feng , Borislav Petkov , Albert Ou , Anup Patel , Paul Walmsley , Suzuki K Poulose , Palmer Dabbelt , Alexandre Ghiti , Alexander Potapenko , Oliver Upton , Andre Przywara , x86@kernel.org, Joey Gouly , Thomas Gleixner , kvm-riscv@lists.infradead.org, Atish Patra , Ingo Molnar , Jing Zhang , "H. Peter Anvin" , Dave Hansen , kvmarm@lists.linux.dev, Will Deacon , Keisuke Nishimura , Sebastian Ott , Peter Zijlstra , Shusen Li , Paolo Bonzini , Randy Dunlap , Zenghui Yu X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250502_135854_462350_C4DFD7FF X-CRM114-Status: GOOD ( 19.03 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Thu, May 01, 2025, Marc Zyngier wrote: > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > > index 69782df3617f..834f08dfa24c 100644 > > --- a/virt/kvm/kvm_main.c > > +++ b/virt/kvm/kvm_main.c > > @@ -1368,6 +1368,40 @@ static int kvm_vm_release(struct inode *inode, struct file *filp) > > return 0; > > } > > > > +/* > > + * Try to lock all of the VM's vCPUs. > > + * Assumes that the kvm->lock is held. > > Assuming is not enough. These assertions have caught a number of bugs, > and I'm not prepared to drop them. > > > + */ > > +int kvm_trylock_all_vcpus(struct kvm *kvm) > > +{ > > + struct kvm_vcpu *vcpu; > > + unsigned long i, j; > > + > > + kvm_for_each_vcpu(i, vcpu, kvm) > > + if (!mutex_trylock_nest_lock(&vcpu->mutex, &kvm->lock)) > > + goto out_unlock; > > + return 0; > > + > > +out_unlock: > > + kvm_for_each_vcpu(j, vcpu, kvm) { > > + if (i == j) > > + break; > > + mutex_unlock(&vcpu->mutex); > > + } > > + return -EINTR; > > +} > > +EXPORT_SYMBOL_GPL(kvm_trylock_all_vcpus); > > + > > +void kvm_unlock_all_vcpus(struct kvm *kvm) > > +{ > > + struct kvm_vcpu *vcpu; > > + unsigned long i; > > + > > + kvm_for_each_vcpu(i, vcpu, kvm) > > + mutex_unlock(&vcpu->mutex); > > +} > > +EXPORT_SYMBOL_GPL(kvm_unlock_all_vcpus); > > I don't mind you not including the assertions in these helpers, I do :-) I see no reason not to add assertions here, if locking all vCPUs is a hot path, we've probably got bigger problems. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv