Re: [PATCH v3 20/23] mailbox/riscv-sbi-mpxy: Add ACPI support

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Anup Patel <apatel@ventanamicro.com>
Cc: "Jassi Brar" <jassisinghbrar@gmail.com>,
	"Atish Patra" <atish.patra@linux.dev>,
	"Michael Turquette" <mturquette@baylibre.com>,
	"Uwe Kleine-König" <ukleinek@kernel.org>,
	linux-riscv@lists.infradead.org, linux-clk@vger.kernel.org,
	"Rob Herring" <robh@kernel.org>,
	"Anup Patel" <anup@brainfault.org>,
	"Bartosz Golaszewski" <brgl@bgdev.pl>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Andrew Jones" <ajones@ventanamicro.com>,
	devicetree@vger.kernel.org, "Conor Dooley" <conor+dt@kernel.org>,
	"Leyfoon Tan" <leyfoon.tan@starfivetech.com>,
	"Paul Walmsley" <paul.walmsley@sifive.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Mika Westerberg" <mika.westerberg@linux.intel.com>,
	"Stephen Boyd" <sboyd@kernel.org>,
	linux-kernel@vger.kernel.org,
	"Samuel Holland" <samuel.holland@sifive.com>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Rahul Pathak" <rpathak@ventanamicro.com>,
	"Len Brown" <lenb@kernel.org>
Subject: Re: [PATCH v3 20/23] mailbox/riscv-sbi-mpxy: Add ACPI support
Date: Mon, 12 May 2025 10:28:17 +0300	[thread overview]
Message-ID: <aCGjEdNVH3ughITd@smile.fi.intel.com> (raw)
In-Reply-To: <20250511133939.801777-21-apatel@ventanamicro.com>

On Sun, May 11, 2025 at 07:09:36PM +0530, Anup Patel wrote:
> From: Sunil V L <sunilvl@ventanamicro.com>
> 
> Add ACPI support for the RISC-V SBI message proxy (MPXY) based
> mailbox driver.

...

> -		if (is_of_node(dev_fwnode(dev)))
> +		if (is_of_node(dev_fwnode(dev))) {
>  			of_msi_configure(dev, to_of_node(dev_fwnode(dev)));
> +		} else {

You probably want to have this as

		} else if (is_acpi_..._node()) { // you should decide if it is data, device or any type of ACPI node you match with

> +			msi_domain = irq_find_matching_fwnode(imsic_acpi_get_fwnode(dev),
> +							      DOMAIN_BUS_PLATFORM_MSI);
> +			dev_set_msi_domain(dev, msi_domain);
> +		}
>  	}

...

> +#ifdef CONFIG_ACPI
> +	if (!acpi_disabled)

Hmm... Why do you need this check? What for?

> +		acpi_dev_clear_dependencies(ACPI_COMPANION(dev));
> +#endif

-- 
With Best Regards,
Andy Shevchenko

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv