linux-riscv.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Charlie Jenkins <charlie@rivosinc.com>
To: Palmer Dabbelt <palmer@dabbelt.com>
Cc: rabenda.cn@gmail.com, Alexandre Ghiti <alex@ghiti.fr>,
	linux-riscv@lists.infradead.org,
	Paul Walmsley <paul.walmsley@sifive.com>,
	aou@eecs.berkeley.edu, jesse@rivosinc.com, andybnac@gmail.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] riscv: vector: fix xtheadvector save/restore
Date: Tue, 10 Jun 2025 18:34:13 -0700	[thread overview]
Message-ID: <aEjdFYDO6AhtHEvf@ghost> (raw)
In-Reply-To: <mhng-08D1FAC4-22A7-424E-A1C8-89B71D89BF01@palmerdabbelt-mac>

On Tue, Jun 10, 2025 at 03:05:58PM -0700, Palmer Dabbelt wrote:
> On Fri, 23 May 2025 02:46:50 PDT (-0700), rabenda.cn@gmail.com wrote:
> > I will release v2 later to add explanation and add fix tag
> 
> Sorry if I missed it, but I don't see a v2 (I'm scrubbing through stuff post
> merge window).

v2 is here: https://lore.kernel.org/all/9b9eb2337f3d5336ce813721f8ebea51e0b2b553.1747994822.git.rabenda.cn@gmail.com/

- Charlie

> 
> > 
> > Thanks,
> > 
> > Han
> > 
> > On Fri, May 23, 2025 at 4:54 PM Alexandre Ghiti <alex@ghiti.fr> wrote:
> > > 
> > > Hi Han,
> > > 
> > > On 5/22/25 19:27, Han Gao wrote:
> > > > Fix [1] save/restore vector register error
> > > >
> > > > Link: https://lore.kernel.org/all/20241113-xtheadvector-v11-9-236c22791ef9@rivosinc.com/ [1]
> > > 
> > > 
> > > Would you mind rephrasing the log? It should explain what was wrong and
> > > how you fixed it.
> > > 
> > > Thanks,
> > > 
> > > Alex
> > > 
> > > 
> > > >
> > > > Signed-off-by: Han Gao <rabenda.cn@gmail.com>
> > > > ---
> > > >   arch/riscv/include/asm/vector.h | 12 ++++++------
> > > >   1 file changed, 6 insertions(+), 6 deletions(-)
> > > >
> > > > diff --git a/arch/riscv/include/asm/vector.h b/arch/riscv/include/asm/vector.h
> > > > index e8a83f55be2b..7df6355023a3 100644
> > > > --- a/arch/riscv/include/asm/vector.h
> > > > +++ b/arch/riscv/include/asm/vector.h
> > > > @@ -200,11 +200,11 @@ static inline void __riscv_v_vstate_save(struct __riscv_v_ext_state *save_to,
> > > >                       THEAD_VSETVLI_T4X0E8M8D1
> > > >                       THEAD_VSB_V_V0T0
> > > >                       "add            t0, t0, t4\n\t"
> > > > -                     THEAD_VSB_V_V0T0
> > > > +                     THEAD_VSB_V_V8T0
> > > >                       "add            t0, t0, t4\n\t"
> > > > -                     THEAD_VSB_V_V0T0
> > > > +                     THEAD_VSB_V_V16T0
> > > >                       "add            t0, t0, t4\n\t"
> > > > -                     THEAD_VSB_V_V0T0
> > > > +                     THEAD_VSB_V_V24T0
> > > >                       : : "r" (datap) : "memory", "t0", "t4");
> > > >       } else {
> > > >               asm volatile (
> > > > @@ -236,11 +236,11 @@ static inline void __riscv_v_vstate_restore(struct __riscv_v_ext_state *restore_
> > > >                       THEAD_VSETVLI_T4X0E8M8D1
> > > >                       THEAD_VLB_V_V0T0
> > > >                       "add            t0, t0, t4\n\t"
> > > > -                     THEAD_VLB_V_V0T0
> > > > +                     THEAD_VLB_V_V8T0
> > > >                       "add            t0, t0, t4\n\t"
> > > > -                     THEAD_VLB_V_V0T0
> > > > +                     THEAD_VLB_V_V16T0
> > > >                       "add            t0, t0, t4\n\t"
> > > > -                     THEAD_VLB_V_V0T0
> > > > +                     THEAD_VLB_V_V24T0
> > > >                       : : "r" (datap) : "memory", "t0", "t4");
> > > >       } else {
> > > >               asm volatile (

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2025-06-11  1:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-22 17:27 [PATCH] riscv: vector: fix xtheadvector save/restore Han Gao
2025-05-22 18:27 ` Xiongchuan Tan
2025-05-22 22:15   ` Han Gao
2025-05-23  3:15 ` Charlie Jenkins
2025-05-23  8:53 ` Alexandre Ghiti
2025-05-23  9:46   ` Han Gao
2025-06-10 22:05     ` Palmer Dabbelt
2025-06-11  1:34       ` Charlie Jenkins [this message]
2025-06-12 20:10 ` patchwork-bot+linux-riscv

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aEjdFYDO6AhtHEvf@ghost \
    --to=charlie@rivosinc.com \
    --cc=alex@ghiti.fr \
    --cc=andybnac@gmail.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=jesse@rivosinc.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=rabenda.cn@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).